)]}'
{"cinder/tests/unit/test_volume_configuration.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"3f46828de721c294f3addfec76bcfbffea0a43e7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.assertEqual(c.int_opt, 1)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # We get the right values, but they are coming from the backend_default"},{"line_number":61,"context_line":"        # group of CONF no the \u0027foo\u0027 one."},{"line_number":62,"context_line":"        self.assertEqual(c.str_opt, CONF.backend_defaults.str_opt)"},{"line_number":63,"context_line":"        self.assertEqual(c.bool_opt, CONF.backend_defaults.bool_opt)"},{"line_number":64,"context_line":"        self.assertEqual(c.int_opt, CONF.backend_defaults.int_opt)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_1fbbcac5","line":61,"updated":"2016-09-28 20:22:23.000000000","message":"no -\u003e not","commit_id":"962b26676cd5c9808ce5f89546801856a3784cd1"}],"cinder/tests/unit/volume/test_volume.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"2fdbd84119aca6fe02532b7fef8f73b58589f087","unresolved":false,"context_lines":[{"line_number":2650,"context_line":"            self.context)"},{"line_number":2651,"context_line":"        self.assertEqual(expected_result, result)"},{"line_number":2652,"context_line":""},{"line_number":2653,"context_line":"    def test_backup_use_temp_snapshot_config(self):"},{"line_number":2654,"context_line":"        local_conf \u003d self.volume.driver.configuration.local_conf"},{"line_number":2655,"context_line":"        self.assertFalse(local_conf.backup_use_temp_snapshot)"},{"line_number":2656,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_87869fb8","side":"PARENT","line":2653,"updated":"2017-06-27 23:49:59.000000000","message":"For anyone wondering, this was removed because it was broken, and doesn\u0027t appear to actually add any value testing-wise...","commit_id":"bfe6990a4e5d663a37415564c98d30773ccc7af5"}],"cinder/volume/configuration.py":[{"author":{"_account_id":23885,"name":"Shunei Shiono","email":"shunei.shiono@gmail.com","username":"s-shiono"},"change_message_id":"5d6bd9d55236c80dafe5e4f39a032a9108d667db","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            # the backend group and override its default value."},{"line_number":109,"context_line":"            if self.config_group !\u003d SHARED_CONF_GROUP:"},{"line_number":110,"context_line":"                self._safe_register(opt, self.config_group)"},{"line_number":111,"context_line":"                CONF.set_default(opt.name, None, group\u003dself.config_group)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def append_config_values(self, volume_opts):"},{"line_number":114,"context_line":"        self._ensure_config_values(volume_opts)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_82887fc6","line":111,"range":{"start_line":111,"start_character":43,"end_line":111,"end_character":47},"updated":"2017-06-30 06:17:31.000000000","message":"I think the 2nd argument should be opt.default.","commit_id":"3205c09f2033d7dc2618a711ad7071f86919f17e"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"b555049a080c5425e9f3b308db7f438b9ddfa5e5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            # the backend group and override its default value."},{"line_number":109,"context_line":"            if self.config_group !\u003d SHARED_CONF_GROUP:"},{"line_number":110,"context_line":"                self._safe_register(opt, self.config_group)"},{"line_number":111,"context_line":"                CONF.set_default(opt.name, None, group\u003dself.config_group)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def append_config_values(self, volume_opts):"},{"line_number":114,"context_line":"        self._ensure_config_values(volume_opts)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_594183a8","line":111,"range":{"start_line":111,"start_character":43,"end_line":111,"end_character":47},"in_reply_to":"3f1d235d_82887fc6","updated":"2017-07-06 18:22:00.000000000","message":"Nah, this is correct as-is, we override the default value in the \"config_group\" group and use the *real* default values that are in the \"shared_backend\" group, which all of the options are actually registered in as of Ia4766eb313e15adc92a92875519b22db64e95d65\n\nThese config groups are just one more layer to override the actual option defaults.\n\nAs noted in the config, we override them so that we can tell if the value was actually set in the config or not. The logic down in __getattr__ is where this comes into play.","commit_id":"3205c09f2033d7dc2618a711ad7071f86919f17e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"91d63b304e14c112639844a366c8f4451d070d14","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        # Don\u0027t use self.X to avoid reentrant call to __getattr__()"},{"line_number":130,"context_line":"        backend_conf \u003d object.__getattribute__(self, \u0027backend_conf\u0027)"},{"line_number":131,"context_line":"        opt_value \u003d getattr(backend_conf, opt_name)"},{"line_number":132,"context_line":"        if opt_value is None:"},{"line_number":133,"context_line":"            shared_conf \u003d object.__getattribute__(self, \u0027shared_backend_conf\u0027)"},{"line_number":134,"context_line":"            opt_value \u003d getattr(shared_conf, opt_name)"},{"line_number":135,"context_line":"        return opt_value"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_c40a4ad0","line":132,"updated":"2017-07-06 18:42:03.000000000","message":"I see, so here it will be None if not set so it can pick up the shared group default right below.","commit_id":"3205c09f2033d7dc2618a711ad7071f86919f17e"}]}