)]}'
{"cinder/api/contrib/quotas.py":[{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"400f5632420fa68eeb511717f495174d06edf66f","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    def _authorize_show(self, context_project, target_project):"},{"line_number":110,"context_line":"        \"\"\"Checks if show is allowed in the current hierarchy."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        With hierarchical projects, are allowed to perform quota show operation"},{"line_number":113,"context_line":"        users with admin role in, at least, one of the following projects: the"},{"line_number":114,"context_line":"        current project; the immediate parent project; or the root project."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_a6efbeaf","line":112,"updated":"2016-06-29 23:18:45.000000000","message":"This needs to be re-worded to:\n\nWith hierarchical projects, users with admin role are allowed to perform quota show operation in, at least, one of the following projects: the current project; the immediate parent project; or the root project.","commit_id":"12a2ff25c7ce09ec953deb8bb6397c286ad922aa"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"8a5cf27767cb9b5796f721c1a87ec68ca0134cfc","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    def _authorize_show(self, context_project, target_project):"},{"line_number":110,"context_line":"        \"\"\"Checks if show is allowed in the current hierarchy."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        With hierarchical projects, are allowed to perform quota show operation"},{"line_number":113,"context_line":"        users with admin role in, at least, one of the following projects: the"},{"line_number":114,"context_line":"        current project; the immediate parent project; or the root project."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_e9b6b9da","line":112,"in_reply_to":"3aaa91ec_a6efbeaf","updated":"2016-06-29 23:30:55.000000000","message":"Oh yeah, I noticed that but forgot to change it in the patch. Super confusing docstring, I\u0027ll get that updated in the next one.","commit_id":"12a2ff25c7ce09ec953deb8bb6397c286ad922aa"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"400f5632420fa68eeb511717f495174d06edf66f","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            # Get the children of the project which the token is scoped to"},{"line_number":378,"context_line":"            # in order to know if the target_project is in its hierarchy."},{"line_number":379,"context_line":"            context_project \u003d quota_utils.get_project_hierarchy("},{"line_number":380,"context_line":"                ctxt, ctxt.project_id, subtree_as_ids\u003dTrue)"},{"line_number":381,"context_line":"            self._authorize_update_or_delete(context_project,"},{"line_number":382,"context_line":"                                             target_project.id,"},{"line_number":383,"context_line":"                                             parent_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_09f505ec","line":380,"range":{"start_line":380,"start_character":58,"end_line":380,"end_character":59},"updated":"2016-06-29 23:18:45.000000000","message":"I believe we need to add admin_context parameter here as well.","commit_id":"12a2ff25c7ce09ec953deb8bb6397c286ad922aa"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"8a5cf27767cb9b5796f721c1a87ec68ca0134cfc","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            # Get the children of the project which the token is scoped to"},{"line_number":378,"context_line":"            # in order to know if the target_project is in its hierarchy."},{"line_number":379,"context_line":"            context_project \u003d quota_utils.get_project_hierarchy("},{"line_number":380,"context_line":"                ctxt, ctxt.project_id, subtree_as_ids\u003dTrue)"},{"line_number":381,"context_line":"            self._authorize_update_or_delete(context_project,"},{"line_number":382,"context_line":"                                             target_project.id,"},{"line_number":383,"context_line":"                                             parent_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_69d2c901","line":380,"range":{"start_line":380,"start_character":58,"end_line":380,"end_character":59},"in_reply_to":"3aaa91ec_09f505ec","updated":"2016-06-29 23:30:55.000000000","message":"Yep, thank you","commit_id":"12a2ff25c7ce09ec953deb8bb6397c286ad922aa"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8048dc6d543f1992bdb6fc424a57558bca67a1e1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                          want to perform an update or delete operation."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        if context_project.is_admin_project:"},{"line_number":89,"context_line":"            # The calling project has admin priveleges and should be able"},{"line_number":90,"context_line":"            # to operate on all quotas."},{"line_number":91,"context_line":"            return"},{"line_number":92,"context_line":"        if context_project.parent_id and parent_id !\u003d context_project.id:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_4a839b56","line":89,"updated":"2016-07-11 18:50:22.000000000","message":"privileges","commit_id":"547c8e304074dfecf9eaed270f8513a7b2246a87"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"93baa558659b418ff346c980c6861a9a5e6d7735","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                          want to perform an update or delete operation."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        if context_project.is_admin_project:"},{"line_number":89,"context_line":"            # The calling project has admin priveleges and should be able"},{"line_number":90,"context_line":"            # to operate on all quotas."},{"line_number":91,"context_line":"            return"},{"line_number":92,"context_line":"        if context_project.parent_id and parent_id !\u003d context_project.id:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_64004b02","line":89,"in_reply_to":"1aa78d24_4a839b56","updated":"2016-07-11 20:06:01.000000000","message":"Done","commit_id":"547c8e304074dfecf9eaed270f8513a7b2246a87"}],"cinder/quota_utils.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"8048dc6d543f1992bdb6fc424a57558bca67a1e1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.parent_id \u003d project_parent_id"},{"line_number":46,"context_line":"        self.subtree \u003d project_subtree"},{"line_number":47,"context_line":"        self.parents \u003d project_parent_tree"},{"line_number":48,"context_line":"        self.is_admin_project \u003d False"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def get_volume_type_reservation(ctxt, volume, type_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_eab88713","line":48,"updated":"2016-07-11 18:50:22.000000000","message":"self.is_admin_project \u003d is_project_admin","commit_id":"547c8e304074dfecf9eaed270f8513a7b2246a87"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"93baa558659b418ff346c980c6861a9a5e6d7735","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.parent_id \u003d project_parent_id"},{"line_number":46,"context_line":"        self.subtree \u003d project_subtree"},{"line_number":47,"context_line":"        self.parents \u003d project_parent_tree"},{"line_number":48,"context_line":"        self.is_admin_project \u003d False"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def get_volume_type_reservation(ctxt, volume, type_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_44054f0f","line":48,"in_reply_to":"1aa78d24_eab88713","updated":"2016-07-11 20:06:01.000000000","message":"Done","commit_id":"547c8e304074dfecf9eaed270f8513a7b2246a87"}]}
