)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"584fd3174f6fd2ae37d1e7a26371b7d21f4acc42","unresolved":false,"context_lines":[{"line_number":12,"context_line":"/types?is_public\u003dNone"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It\u0027s not easy to understand by end user, so we\u0027d"},{"line_number":15,"context_line":"better to let /types list all public and non-public"},{"line_number":16,"context_line":"types while is_public option is not specified."},{"line_number":17,"context_line":"And let /types?is_public\u003dFalse return all non-public ones,"},{"line_number":18,"context_line":"/types?is_public\u003dTrue list all public ones."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_40d93ef4","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":46},"updated":"2016-07-01 14:32:11.000000000","message":"This patch has API impact and requires a release note. I think it also need micro version.","commit_id":"07c946cc61a87d33a1b177f6a6c81c3a68d5fc3c"}],"cinder/api/v2/types.py":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"4375d894dddee6c0b1fa8c4ee061a258918cfbcc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            # Only admin has query access to all volume types"},{"line_number":102,"context_line":"            filters[\u0027is_public\u0027] \u003d self._parse_is_public(is_public)"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            # Non-admin user always only can access all public types"},{"line_number":105,"context_line":"            filters[\u0027is_public\u0027] \u003d True"},{"line_number":106,"context_line":"        utils.remove_invalid_filter_options(context,"},{"line_number":107,"context_line":"                                            filters,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_2bae992f","line":104,"range":{"start_line":104,"start_character":13,"end_line":104,"end_character":14},"updated":"2016-07-13 17:39:24.000000000","message":"I think it would be better to show all the types the user could use by default. There may be some private types that the user can access. My vote is to return all types visable to the user by default, and only filter by is_public if it is specified.","commit_id":"bde6b55347d808149e422fd1d84f631733333d80"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"6c107a32eb5ad46354ff9ede33891b86186b5352","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            # Only admin has query access to all volume types"},{"line_number":102,"context_line":"            filters[\u0027is_public\u0027] \u003d self._parse_is_public(is_public)"},{"line_number":103,"context_line":"        else:"},{"line_number":104,"context_line":"            # Non-admin user always only can access all public types"},{"line_number":105,"context_line":"            filters[\u0027is_public\u0027] \u003d True"},{"line_number":106,"context_line":"        utils.remove_invalid_filter_options(context,"},{"line_number":107,"context_line":"                                            filters,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ec7f7567","line":104,"range":{"start_line":104,"start_character":13,"end_line":104,"end_character":14},"in_reply_to":"1aa78d24_2bae992f","updated":"2016-07-14 01:43:28.000000000","message":"IIUC, just like the note message said, the original design is that \"Non-admin user\" has no permission to access the non-public volume types, i.e. it always returns the public ones no matter what value is specified to the \"is_public\" option.\nSo in this patch, we only tried to fix the admin user\u0027s behavior to make it more user-friendly.","commit_id":"bde6b55347d808149e422fd1d84f631733333d80"}]}