)]}'
{"cinder/volume/drivers/eqlx.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7e093ed6ff963a65c65841822c54ddf080febed6","unresolved":false,"context_lines":[{"line_number":528,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":529,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":530,"context_line":"            # Extend Volume if needed"},{"line_number":531,"context_line":"            if out and volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":532,"context_line":"                self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":533,"context_line":"                LOG.debug(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":534,"context_line":"                          \u0027%(current_size)sGB to %(new_size)sGB.\u0027,"},{"line_number":535,"context_line":"                          {\u0027name\u0027: volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_566394dc","line":532,"range":{"start_line":531,"start_character":0,"end_line":532,"end_character":58},"updated":"2016-07-04 14:20:56.000000000","message":"If I understand correctly, we want to extend a volume if snapshot has bigger size, right? Shouldn\u0027t this then be:\n\n            if out and snapshot[\u0027volume_size\u0027] \u003e volume[\u0027size\u0027]:\n                self.extend_volume(volume, snapshot[\u0027volume_size\u0027])\n\nExtending a volume to its own size doesn\u0027t seem to make sense…","commit_id":"a337fb3f804f9441bdecd0ff7357edfa3398d750"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"adcdc1964da64dce891c7e3a2468d947fe352b21","unresolved":false,"context_lines":[{"line_number":528,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":529,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":530,"context_line":"            # Extend Volume if needed"},{"line_number":531,"context_line":"            if out and volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":532,"context_line":"                self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":533,"context_line":"                LOG.debug(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":534,"context_line":"                          \u0027%(current_size)sGB to %(new_size)sGB.\u0027,"},{"line_number":535,"context_line":"                          {\u0027name\u0027: volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ea10d450","line":532,"range":{"start_line":531,"start_character":0,"end_line":532,"end_character":58},"in_reply_to":"1aa78d24_566394dc","updated":"2016-07-04 14:41:49.000000000","message":"Michal, IIUC we want to extend the volume in the backend if it is created from a source with size less than the user specified volume size. After line 526, the backend volume will be created with size \u003d snapshot[\u0027volume_size\u0027] and we should extend the volume if the snapshot size is less than the user specified volume size (volume[\u0027size\u0027]).","commit_id":"a337fb3f804f9441bdecd0ff7357edfa3398d750"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"52c135c55e1d3f6ebcb1e68a9b58eb219a9bc292","unresolved":false,"context_lines":[{"line_number":528,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":529,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":530,"context_line":"            # Extend Volume if needed"},{"line_number":531,"context_line":"            if out and volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":532,"context_line":"                self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":533,"context_line":"                LOG.debug(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":534,"context_line":"                          \u0027%(current_size)sGB to %(new_size)sGB.\u0027,"},{"line_number":535,"context_line":"                          {\u0027name\u0027: volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_f62280b8","line":532,"range":{"start_line":531,"start_character":0,"end_line":532,"end_character":58},"in_reply_to":"1aa78d24_566394dc","updated":"2016-07-04 14:38:27.000000000","message":"The logic of this is correct. The volume (let\u0027s says has 50G) in this case, was cloned from snapshot (let\u0027s say 30GB). When the backend clone the snapshot into the volume, it will use optimized copy, and therefore create a volume with 30GB. So, we need to extend to volume to the desired size (50G).","commit_id":"a337fb3f804f9441bdecd0ff7357edfa3398d750"}]}