)]}'
{"cinder/consistencygroup/api.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"71ee814503146640a82aea7de323e51924452dcb","unresolved":false,"context_lines":[{"line_number":785,"context_line":""},{"line_number":786,"context_line":"    def cgsnapshot_reset_status(self, context, cgsnapshot, body):"},{"line_number":787,"context_line":"        \"\"\"Reset the cgsnapshot\u0027s status.\"\"\""},{"line_number":788,"context_line":"        if body[\u0027status\u0027] not in c_fields.CgsnapshotStatus.ALL:"},{"line_number":789,"context_line":"            msg \u003d (_(\"New state is invalid.\"))"},{"line_number":790,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":791,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_40cf7e57","line":788,"range":{"start_line":788,"start_character":8,"end_line":788,"end_character":62},"updated":"2016-07-01 14:27:23.000000000","message":"Why do we need to allow resetting to any state? It doesn\u0027t make sense to set state from available to deleted.","commit_id":"f70d0506f934f10c4b637b2ec0394054a29f35df"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"aaf3b3575abb08931326e558c85cd809e0ee2a2c","unresolved":false,"context_lines":[{"line_number":786,"context_line":"    def cgsnapshot_reset_status(self, context, cgsnapshot, body):"},{"line_number":787,"context_line":"        \"\"\"Reset the cgsnapshot\u0027s status.\"\"\""},{"line_number":788,"context_line":"        if body[\u0027status\u0027] not in c_fields.CgsnapshotStatus.ALL:"},{"line_number":789,"context_line":"            msg \u003d (_(\"New state is invalid.\"))"},{"line_number":790,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        # Update status  in db now. No need to"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_6050bad5","line":789,"updated":"2016-07-01 14:25:00.000000000","message":"nit: we can also include the invalid state name in the message.","commit_id":"f70d0506f934f10c4b637b2ec0394054a29f35df"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"aaf3b3575abb08931326e558c85cd809e0ee2a2c","unresolved":false,"context_lines":[{"line_number":789,"context_line":"            msg \u003d (_(\"New state is invalid.\"))"},{"line_number":790,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        # Update status  in db now. No need to"},{"line_number":793,"context_line":"        # send them over through an RPC call."},{"line_number":794,"context_line":"        fields \u003d {\u0027updated_at\u0027: timeutils.utcnow(),"},{"line_number":795,"context_line":"                  \u0027status\u0027: body[\u0027status\u0027]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_206d129a","line":792,"range":{"start_line":792,"start_character":23,"end_line":792,"end_character":25},"updated":"2016-07-01 14:25:00.000000000","message":"nit: extra space","commit_id":"f70d0506f934f10c4b637b2ec0394054a29f35df"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"71ee814503146640a82aea7de323e51924452dcb","unresolved":false,"context_lines":[{"line_number":789,"context_line":"            msg \u003d (_(\"New state is invalid.\"))"},{"line_number":790,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        # Update status  in db now. No need to"},{"line_number":793,"context_line":"        # send them over through an RPC call."},{"line_number":794,"context_line":"        fields \u003d {\u0027updated_at\u0027: timeutils.utcnow(),"},{"line_number":795,"context_line":"                  \u0027status\u0027: body[\u0027status\u0027]}"},{"line_number":796,"context_line":"        cgsnapshot.update(fields)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e0b2eae4","line":793,"range":{"start_line":792,"start_character":36,"end_line":793,"end_character":45},"updated":"2016-07-01 14:27:23.000000000","message":"Why?","commit_id":"f70d0506f934f10c4b637b2ec0394054a29f35df"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"27d0c4b11fbdc7d1c21cee76f896d6f66f0449e0","unresolved":false,"context_lines":[{"line_number":793,"context_line":"        # send them over through an RPC call."},{"line_number":794,"context_line":"        fields \u003d {\u0027updated_at\u0027: timeutils.utcnow(),"},{"line_number":795,"context_line":"                  \u0027status\u0027: body[\u0027status\u0027]}"},{"line_number":796,"context_line":"        cgsnapshot.update(fields)"},{"line_number":797,"context_line":"        cgsnapshot.save()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_eb96513d","line":796,"updated":"2016-07-13 17:31:48.000000000","message":"We shouldn\u0027t blindly reset the state. We should allow only states which make sense as I mentioned in the previous patch set.","commit_id":"689eac01c8f76e9966de834672263fd7f715c410"}],"cinder/tests/unit/api/v3/test_cgsnapshots.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"27d0c4b11fbdc7d1c21cee76f896d6f66f0449e0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"import cinder.volume"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class CgsnapshotsAPITestCase(test.TestCase):"},{"line_number":31,"context_line":"    \"\"\"Test Case for cgsnapshots API.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ebe491e1","line":30,"updated":"2016-07-13 17:31:48.000000000","message":"We need unit test coverage for the error scenarios.","commit_id":"689eac01c8f76e9966de834672263fd7f715c410"}]}