)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"e3f65bf16d5b03d979e99f808926bdb434db0ae1","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"        except Exception as err:"},{"line_number":1429,"context_line":"            err_msg \u003d (_(\u0027Terminate volume connection failed: %(err)s\u0027)"},{"line_number":1430,"context_line":"                       % {\u0027err\u0027: six.text_type(err)})"},{"line_number":1431,"context_line":"            LOG.exception(err_msg, resource\u003dvolume_ref)"},{"line_number":1432,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":1433,"context_line":"        LOG.info(_LI(\"Terminate volume connection completed successfully.\"),"},{"line_number":1434,"context_line":"                 resource\u003dvolume_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_d5a3109d","line":1431,"updated":"2016-07-04 08:23:01.000000000","message":"How about using save_and_reraise_exception to log the call trace as well?\nusually this only logs the error from driver, but lose the details of problem occurs.\n\nThanks\nPeter","commit_id":"81066a05df3a4a9ba8c372a910af38768520a1b5"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"078d6b6bfe5d57f0d048dcf752c3a51396636644","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"        except Exception as err:"},{"line_number":1429,"context_line":"            err_msg \u003d (_(\u0027Terminate volume connection failed: %(err)s\u0027)"},{"line_number":1430,"context_line":"                       % {\u0027err\u0027: six.text_type(err)})"},{"line_number":1431,"context_line":"            LOG.exception(err_msg, resource\u003dvolume_ref)"},{"line_number":1432,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":1433,"context_line":"        LOG.info(_LI(\"Terminate volume connection completed successfully.\"),"},{"line_number":1434,"context_line":"                 resource\u003dvolume_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_364c08c7","line":1431,"in_reply_to":"1aa78d24_163bccd2","updated":"2016-07-04 14:35:47.000000000","message":"Thanks Vipin for the explanation.\nMaybe I missed something here.\nOne question, can LOG.exception log the stack trace?\n\nThanks\nPeter","commit_id":"81066a05df3a4a9ba8c372a910af38768520a1b5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5158efe8e6fa8ca6b2ebd25fef4e539ae5fe4695","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"        except Exception as err:"},{"line_number":1429,"context_line":"            err_msg \u003d (_(\u0027Terminate volume connection failed: %(err)s\u0027)"},{"line_number":1430,"context_line":"                       % {\u0027err\u0027: six.text_type(err)})"},{"line_number":1431,"context_line":"            LOG.exception(err_msg, resource\u003dvolume_ref)"},{"line_number":1432,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":1433,"context_line":"        LOG.info(_LI(\"Terminate volume connection completed successfully.\"),"},{"line_number":1434,"context_line":"                 resource\u003dvolume_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_38f97b81","line":1431,"in_reply_to":"1aa78d24_364c08c7","updated":"2016-07-05 07:48:32.000000000","message":"Yes, exception method will log the stack trace.","commit_id":"81066a05df3a4a9ba8c372a910af38768520a1b5"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f02e7e9732de3738b1ae876ef82f053d54aa6c67","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"        except Exception as err:"},{"line_number":1429,"context_line":"            err_msg \u003d (_(\u0027Terminate volume connection failed: %(err)s\u0027)"},{"line_number":1430,"context_line":"                       % {\u0027err\u0027: six.text_type(err)})"},{"line_number":1431,"context_line":"            LOG.exception(err_msg, resource\u003dvolume_ref)"},{"line_number":1432,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":1433,"context_line":"        LOG.info(_LI(\"Terminate volume connection completed successfully.\"),"},{"line_number":1434,"context_line":"                 resource\u003dvolume_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_163bccd2","line":1431,"in_reply_to":"1aa78d24_d5a3109d","updated":"2016-07-04 14:21:09.000000000","message":"@Peter, save_and_reraise_exception is useful if we are re-raising the original exception which is not the case here.","commit_id":"81066a05df3a4a9ba8c372a910af38768520a1b5"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d074292d423de38b58e1ed6e8c5a4a4e7c2b2443","unresolved":false,"context_lines":[{"line_number":1428,"context_line":"        except Exception as err:"},{"line_number":1429,"context_line":"            err_msg \u003d (_(\u0027Terminate volume connection failed: %(err)s\u0027)"},{"line_number":1430,"context_line":"                       % {\u0027err\u0027: six.text_type(err)})"},{"line_number":1431,"context_line":"            LOG.exception(err_msg, resource\u003dvolume_ref)"},{"line_number":1432,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":1433,"context_line":"        LOG.info(_LI(\"Terminate volume connection completed successfully.\"),"},{"line_number":1434,"context_line":"                 resource\u003dvolume_ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_5bfd7d39","line":1431,"in_reply_to":"1aa78d24_d5a3109d","updated":"2016-07-04 14:15:38.000000000","message":"We are not re-raising the exception here.","commit_id":"81066a05df3a4a9ba8c372a910af38768520a1b5"}]}