)]}'
{"cinder/backup/services/swift.py":[{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"39d3ce11a92a27556aa4f872e5fd02840d9ba487","unresolved":false,"context_lines":[{"line_number":58,"context_line":"               help\u003d\u0027Swift user name\u0027),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027backup_swift_key\u0027,"},{"line_number":60,"context_line":"               default\u003dNone,"},{"line_number":61,"context_line":"               help\u003d\u0027Swift auth token\u0027),"},{"line_number":62,"context_line":"    cfg.StrOpt(\u0027backup_swift_container\u0027,"},{"line_number":63,"context_line":"               default\u003d\u0027volumebackups\u0027,"},{"line_number":64,"context_line":"               help\u003d\u0027The default Swift container to use\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F0wU%3D","line":61,"updated":"2013-06-20 11:23:11.000000000","message":"Is this a swift token or password?\n\nIf a token, will it not be very short-lived (on the order of hours), and thus require a restart of the cinder backend and a conf change each time it expires?","commit_id":"ca0db2b305963bb2c3d5dba85b4b4d37feebb23c"},{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"39d3ce11a92a27556aa4f872e5fd02840d9ba487","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.swift_backoff \u003d CONF.backup_swift_retry_backoff"},{"line_number":113,"context_line":"        self.compressor \u003d \\"},{"line_number":114,"context_line":"            self._get_compressor(CONF.backup_compression_algorithm)"},{"line_number":115,"context_line":"        if (CONF.backup_swift_user):"},{"line_number":116,"context_line":"            self.conn \u003d swift.Connection(authurl\u003dCONF.backup_swift_url,"},{"line_number":117,"context_line":"                                         user\u003dCONF.backup_swift_user,"},{"line_number":118,"context_line":"                                         key\u003dCONF.backup_swift_key,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F0v8%3D","line":115,"updated":"2013-06-20 11:23:11.000000000","message":"should we login a message indicating this change in behaviour? It could be a source of confusion (this essentially means all volume backups will go to some other user\u0027s swift account rather than the user initiating the volume backup, right?)","commit_id":"ca0db2b305963bb2c3d5dba85b4b4d37feebb23c"}],"etc/cinder/cinder.conf.sample":[{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"39d3ce11a92a27556aa4f872e5fd02840d9ba487","unresolved":false,"context_lines":[{"line_number":333,"context_line":"# The URL of the Swift endpoint (string value)"},{"line_number":334,"context_line":"#backup_swift_url\u003dhttp://localhost:8080/v1/AUTH_"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"# The Swift user name"},{"line_number":337,"context_line":"#backup_swift_user\u003dusername"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"# The Swift key token"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAPn%2F%2F0vU%3D","line":336,"updated":"2013-06-20 11:23:11.000000000","message":"The backup_swift_url is required for a working backup to swift. backup_swift_user and backup_swift_key are optional, and actually change the behaviour of the backup service in a significant way if set. I wonder should we have a specific flag to trigger this change e.g. backup_swift_strategy\u003dper_user|single_user rather than an implied behaviour change based on presence/absence of backup_swift_user setting.\n\nAt the very least, we should make this behaviour clearer here I think.","commit_id":"ca0db2b305963bb2c3d5dba85b4b4d37feebb23c"}]}