)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f2d8c6899824dd9a56879b5972536796f957b58c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_volume_from_snapshot can specify a volume size larger than the"},{"line_number":10,"context_line":"orginal snapshot. Current code does not appear to handle this size"},{"line_number":11,"context_line":"difference.This patch fixes it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Xinli Guan \u003cxinli@us.ibm.com\u003e"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_3d9056ec","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":11},"updated":"2017-03-20 19:59:00.000000000","message":"Missing space here.","commit_id":"e729ee9b308456cb5773919055bbfbac845e9ecc"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"e7989b7711ebfb00880051f640e8c8d1904bd0f3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_volume_from_snapshot can specify a volume size larger than the"},{"line_number":10,"context_line":"orginal snapshot. Current code does not appear to handle this size"},{"line_number":11,"context_line":"difference.This patch fixes it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Xinli Guan \u003cxinli@us.ibm.com\u003e"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a1ced50_0192589e","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":11},"in_reply_to":"1a1ced50_3d9056ec","updated":"2017-03-20 22:24:36.000000000","message":"Jay;\n\nThank you very much for code reviewing. I will fix it in next patch set.\n\nXinli","commit_id":"e729ee9b308456cb5773919055bbfbac845e9ecc"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7150a95aaa926a448894517132543b886d5880da","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xinli Guan \u003cxinli@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-20 22:25:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Infortrend driver does not honor create from snapshot volume size Edit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_volume_from_snapshot can specify a volume size larger than the"},{"line_number":10,"context_line":"orginal snapshot. Current code does not appear to handle this size"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a1ced50_84851f5b","line":7,"updated":"2017-03-22 14:35:24.000000000","message":"Please also reformat the commit message to follow the guidelines:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nI would recommend something like:\n\nInfortrend: handle create volume from snapshot with different size\n\nOr something like that.","commit_id":"e98a658932d438102b1f69865864b9be03023ffe"}],"cinder/volume/drivers/infortrend/raidcmd_cli/common_cli.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f2d8c6899824dd9a56879b5972536796f957b58c","unresolved":false,"context_lines":[{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"        if volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":1212,"context_line":"            new_size \u003d volume[\u0027size\u0027]"},{"line_number":1213,"context_line":"            volume[\u0027size\u0027] \u003d snapshot[\u0027volume_size\u0027]"},{"line_number":1214,"context_line":"            self.extend_volume(volume, new_size)"},{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":"        LOG.info("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_9da06a45","line":1213,"range":{"start_line":1213,"start_character":12,"end_line":1213,"end_character":52},"updated":"2017-03-20 19:59:00.000000000","message":"Ok, maybe this is a nit, but changing the volume size before calling the extend makes me nervous. If something goes wrong with the extend do we not then have bad information for the volume?","commit_id":"e729ee9b308456cb5773919055bbfbac845e9ecc"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"e7989b7711ebfb00880051f640e8c8d1904bd0f3","unresolved":false,"context_lines":[{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"        if volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":1212,"context_line":"            new_size \u003d volume[\u0027size\u0027]"},{"line_number":1213,"context_line":"            volume[\u0027size\u0027] \u003d snapshot[\u0027volume_size\u0027]"},{"line_number":1214,"context_line":"            self.extend_volume(volume, new_size)"},{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":"        LOG.info("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_d569d626","line":1213,"range":{"start_line":1213,"start_character":12,"end_line":1213,"end_character":52},"in_reply_to":"1a1ced50_9da06a45","updated":"2017-03-20 22:24:36.000000000","message":"Jay;\n\nThank you very much for your code reviewing, I think that the variable \"new_size\" is to help to keep the volume expected  size in case extend_volume failed\n\n1) _create_volume_from_snapshot_id() creates the copy of snapshot\n2) after the function call, the volume real size is the size of snapshot[\u0027volume_size\u0027]\n3) then, the code updates the volume[\u0027size\u0027] as its real size\n4) finally the code extends volume to the expected size.\n\nThanks a lot;","commit_id":"e729ee9b308456cb5773919055bbfbac845e9ecc"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"13dceed00e32bb47775ea4cc201157dbf46015a9","unresolved":false,"context_lines":[{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"        if volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":1212,"context_line":"            new_size \u003d volume[\u0027size\u0027]"},{"line_number":1213,"context_line":"            volume[\u0027size\u0027] \u003d snapshot[\u0027volume_size\u0027]"},{"line_number":1214,"context_line":"            self.extend_volume(volume, new_size)"},{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":"        LOG.info("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_7419e4d6","line":1213,"range":{"start_line":1213,"start_character":12,"end_line":1213,"end_character":52},"in_reply_to":"1a1ced50_d569d626","updated":"2017-03-21 14:36:13.000000000","message":"I see.  For some reason I was thinking this is a resize.  Sorry.  So, this should be ok.","commit_id":"e729ee9b308456cb5773919055bbfbac845e9ecc"}]}