)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"a8c8e24f18a969f5340a437a0664f8c57f94254d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace use of mox with mock in test_netapp_nfs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch replaces the remaining cases of mox with mock in test_netapp_nfs.py"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0d8e63dd1c7c01deca317b98a92fd59626dc6d55"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_300bc525","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":78},"updated":"2016-07-21 19:57:19.000000000","message":"Wrap this line in 72 characters.","commit_id":"d88ad30741c7f11df235bad521f4563e9d21ee06"}],"cinder/tests/unit/test_netapp_nfs.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bffa4fc76a630b4ef8baea7c777b0c277a25564d","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        drv \u003d self._driver"},{"line_number":169,"context_line":"        with mock.patch.object("},{"line_number":170,"context_line":"                drv, \u0027_clone_backing_file_for_volume\u0027) as mock_clone_backing:"},{"line_number":171,"context_line":"            drv.create_snapshot(FakeSnapshot())"},{"line_number":172,"context_line":"            self.assertTrue(mock_clone_backing.called)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def test_create_volume_from_snapshot(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_ef404809","line":171,"updated":"2016-07-21 11:10:30.000000000","message":"Please, check that it\u0027s called with correct arguments","commit_id":"04790d5b177cdc7c064e2b5e44b5f5a6257023c3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bffa4fc76a630b4ef8baea7c777b0c277a25564d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                        \u002710.61.170.1:/share/path\u0027,"},{"line_number":278,"context_line":"                                        \u0027img-cache-12345\u0027)"},{"line_number":279,"context_line":"            drv._register_image_in_cache(volume, \u002712345\u0027)"},{"line_number":280,"context_line":"            mock_do_clone.assert_called()"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def test_register_img_in_cache_with_share(self):"},{"line_number":283,"context_line":"        volume \u003d {\u0027id\u0027: \u00271\u0027, \u0027name\u0027: \u0027testvol\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_0fc31c8a","line":280,"updated":"2016-07-21 11:10:30.000000000","message":"Please, check that it\u0027s called with correct arguments","commit_id":"04790d5b177cdc7c064e2b5e44b5f5a6257023c3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bffa4fc76a630b4ef8baea7c777b0c277a25564d","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                                        \u002710.61.170.1:/share/path\u0027,"},{"line_number":290,"context_line":"                                        \u0027img-cache-12345\u0027)"},{"line_number":291,"context_line":"            drv._register_image_in_cache(volume, \u002712345\u0027)"},{"line_number":292,"context_line":"            mock_do_clone.assert_called()"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test_find_image_in_cache_no_shares(self):"},{"line_number":295,"context_line":"        drv \u003d self._driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_efc968ad","line":292,"updated":"2016-07-21 11:10:30.000000000","message":"Please, check that it\u0027s called with correct arguments","commit_id":"04790d5b177cdc7c064e2b5e44b5f5a6257023c3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bffa4fc76a630b4ef8baea7c777b0c277a25564d","unresolved":false,"context_lines":[{"line_number":576,"context_line":"    def test_is_cloneable_share_badformats(self, strg):"},{"line_number":577,"context_line":"        drv \u003d self._driver"},{"line_number":578,"context_line":"        res \u003d drv._is_cloneable_share(strg)"},{"line_number":579,"context_line":"        if res:"},{"line_number":580,"context_line":"            msg \u003d \u0027Invalid format matched for url %s.\u0027 % strg"},{"line_number":581,"context_line":"            self.fail(msg)"},{"line_number":582,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2fb38051","line":579,"updated":"2016-07-21 11:10:30.000000000","message":"Please, use assertIsNone here","commit_id":"04790d5b177cdc7c064e2b5e44b5f5a6257023c3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bffa4fc76a630b4ef8baea7c777b0c277a25564d","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        with mock.patch.object(drv, \u0027_check_share_in_use\u0027) as mock_share:"},{"line_number":591,"context_line":"            mock_share.return_value \u003d \u0027share\u0027"},{"line_number":592,"context_line":"            drv._is_cloneable_share(strg)"},{"line_number":593,"context_line":"            self.assertTrue(mock_share.called)"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"    def test_check_share_in_use_no_conn(self):"},{"line_number":596,"context_line":"        drv \u003d self._driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_6f6298d9","line":593,"updated":"2016-07-21 11:10:30.000000000","message":"Please, check that it\u0027s called with correct arguments","commit_id":"04790d5b177cdc7c064e2b5e44b5f5a6257023c3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bffa4fc76a630b4ef8baea7c777b0c277a25564d","unresolved":false,"context_lines":[{"line_number":609,"context_line":"        mock_resolve_host \u003d self.mock_object(utils, \u0027resolve_hostname\u0027)"},{"line_number":610,"context_line":"        mock_resolve_host.side_effect \u003d Exception()"},{"line_number":611,"context_line":"        share \u003d drv._check_share_in_use(\u0027incorrect:8989\u0027, \u0027/dir\u0027)"},{"line_number":612,"context_line":"        if share:"},{"line_number":613,"context_line":"            self.fail(\u0027Unexpected share detected.\u0027)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    def test_check_share_in_use_success(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_4f46b44f","line":612,"updated":"2016-07-21 11:10:30.000000000","message":"the same, as below","commit_id":"04790d5b177cdc7c064e2b5e44b5f5a6257023c3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bffa4fc76a630b4ef8baea7c777b0c277a25564d","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        mock_resolve_host.return_value \u003d \u002710.22.33.44\u0027"},{"line_number":620,"context_line":"        drv._share_match_for_ip \u003d mock.Mock(return_value\u003d\u0027share\u0027)"},{"line_number":621,"context_line":"        share \u003d drv._check_share_in_use(\u0027127.0.0.1:8989\u0027, \u0027/dir/share\u0027)"},{"line_number":622,"context_line":"        if not share:"},{"line_number":623,"context_line":"            self.fail(\u0027Expected share not detected\u0027)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    def test_construct_image_url_loc(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2f3ee0c0","line":622,"range":{"start_line":622,"start_character":17,"end_line":622,"end_character":18},"updated":"2016-07-21 11:10:30.000000000","message":"Please, use assertIsNone here","commit_id":"04790d5b177cdc7c064e2b5e44b5f5a6257023c3"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"a8c8e24f18a969f5340a437a0664f8c57f94254d","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        else:"},{"line_number":301,"context_line":"            self.fail(\u0027Return result is unexpected\u0027)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @mock.patch.object(os.path, \u0027isfile\u0027, return_value\u003dTrue)"},{"line_number":304,"context_line":"    def test_find_image_in_cache_shares(self, mock_isfile):"},{"line_number":305,"context_line":"        drv \u003d self._driver"},{"line_number":306,"context_line":"        drv._mounted_shares \u003d [\u0027testshare\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_755c0f4b","line":303,"range":{"start_line":303,"start_character":4,"end_line":303,"end_character":60},"updated":"2016-07-21 19:57:19.000000000","message":"Why using mock with decorator only in this test? Wouldn\u0027t be better choose only one way between decorator/\"with mock\"/self.mock_object() to mock things?","commit_id":"d88ad30741c7f11df235bad521f4563e9d21ee06"}]}