)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"500f6a471869ccc7fd1d10b20e14180d2d0cc0af","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently if we pass a bool key like foo\u003dTrue as an extra-spec with the create"},{"line_number":10,"context_line":"volume, it errors with no valid host found. This is because as the comparisions"},{"line_number":11,"context_line":"are happening between unicode string and bool values. This patch corrects"},{"line_number":12,"context_line":"the same"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8112a6de9e6fa2f976950c70217a89246b2bd73a"},{"line_number":15,"context_line":"Closes-bug: #1599611"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_7908b7da","line":12,"updated":"2016-07-06 23:03:28.000000000","message":"Nit: the last two sentences are a bit confusing, maybe \"This is because the comparisons happen between unicode string and bool values. This patch corrects this behavior by converting bools to string\"","commit_id":"6a2bb881a1347fc3fd3794729ac8f2fddc991cf1"}],"cinder/scheduler/filters/extra_specs_ops.py":[{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"500f6a471869ccc7fd1d10b20e14180d2d0cc0af","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if op \u003d\u003d \u0027\u003cor\u003e\u0027:  # Ex: \u003cor\u003e v1 \u003cor\u003e v2 \u003cor\u003e v3"},{"line_number":66,"context_line":"        while True:"},{"line_number":67,"context_line":"            if words.pop(0) \u003d\u003d value:"},{"line_number":68,"context_line":"                return True"},{"line_number":69,"context_line":"            if not words:"},{"line_number":70,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_195093d3","line":67,"updated":"2016-07-06 23:03:28.000000000","message":"Is it impossible for value to be a bool at this point as well?","commit_id":"6a2bb881a1347fc3fd3794729ac8f2fddc991cf1"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"72f742fee5801b4c962c630941cdf57725cea362","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if op \u003d\u003d \u0027\u003cor\u003e\u0027:  # Ex: \u003cor\u003e v1 \u003cor\u003e v2 \u003cor\u003e v3"},{"line_number":66,"context_line":"        while True:"},{"line_number":67,"context_line":"            if words.pop(0) \u003d\u003d value:"},{"line_number":68,"context_line":"                return True"},{"line_number":69,"context_line":"            if not words:"},{"line_number":70,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_79ca771c","line":67,"in_reply_to":"1aa78d24_195093d3","updated":"2016-07-06 23:16:39.000000000","message":"It is possible for a value to be bool at this point. However if one does not use op(or) in extra-spec, this condition at line 65 op \u003d\u003d \u0027\u003cor\u003e never passes.\n\nA extra-spec like set QoS_support\u003dTrue will skip this condition and go to line 77","commit_id":"6a2bb881a1347fc3fd3794729ac8f2fddc991cf1"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"fc6376d9f3cea38a88184db9f7c956cfd2848151","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if op \u003d\u003d \u0027\u003cor\u003e\u0027:  # Ex: \u003cor\u003e v1 \u003cor\u003e v2 \u003cor\u003e v3"},{"line_number":66,"context_line":"        while True:"},{"line_number":67,"context_line":"            if words.pop(0) \u003d\u003d value:"},{"line_number":68,"context_line":"                return True"},{"line_number":69,"context_line":"            if not words:"},{"line_number":70,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_b96cdf08","line":67,"in_reply_to":"1aa78d24_79ca771c","updated":"2016-07-06 23:18:39.000000000","message":"got it, thanks","commit_id":"6a2bb881a1347fc3fd3794729ac8f2fddc991cf1"}]}