)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1643bd521581b67c59cdf1485b649998502be4c2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As snapshots are volumes in XtremIO, all this change does is route"},{"line_number":10,"context_line":"the snapshot manage calls to the appropriate volume manage calls."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I90432ace52d9c8b7ae48c843be86c1d51e8c875e"},{"line_number":13,"context_line":"Implements: blueprint xtremio-manage-snapshot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fad55976_59ec1a8f","line":11,"updated":"2016-07-17 06:01:36.000000000","message":"Please add a DocImpact flag here.","commit_id":"7f9a798c5918bdfdb2fbd12ef7e7b7aecebcbe87"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"ae6b4beaeed17b92aa3fbf848d3991b7f13afe30","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As snapshots are volumes in XtremIO, all this change does is route"},{"line_number":10,"context_line":"the snapshot manage calls to the appropriate volume manage calls."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I90432ace52d9c8b7ae48c843be86c1d51e8c875e"},{"line_number":13,"context_line":"Implements: blueprint xtremio-manage-snapshot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_f9d44c48","line":11,"in_reply_to":"fad55976_59ec1a8f","updated":"2016-07-18 12:02:16.000000000","message":"Done","commit_id":"7f9a798c5918bdfdb2fbd12ef7e7b7aecebcbe87"}],"cinder/volume/drivers/emc/xtremio.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8c85fb8cff0466da493f862da3ed9c76aeffa0a4","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                raise exception.ManageExistingInvalidReference(**kwargs)"},{"line_number":520,"context_line":"        except exception.NotFound:"},{"line_number":521,"context_line":"            kwargs \u003d {\u0027existing_ref\u0027: lv_name,"},{"line_number":522,"context_line":"                      \u0027reason\u0027: \u0027Specified logical volume does not exist.\u0027}"},{"line_number":523,"context_line":"            raise exception.ManageExistingInvalidReference(**kwargs)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Attempt to rename the LV to match the OpenStack internal name."}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_4880838b","line":522,"updated":"2016-07-12 20:03:32.000000000","message":"I think the message should say \"volume\" or \"snapshot\" depending on the is_snapshot flag.","commit_id":"33edcc7cf261cbe9dd2f1925c69aef25b1bab3a9"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"e12d5c5299030e01b308d735287b97463db75b33","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                raise exception.ManageExistingInvalidReference(**kwargs)"},{"line_number":520,"context_line":"        except exception.NotFound:"},{"line_number":521,"context_line":"            kwargs \u003d {\u0027existing_ref\u0027: lv_name,"},{"line_number":522,"context_line":"                      \u0027reason\u0027: \u0027Specified logical volume does not exist.\u0027}"},{"line_number":523,"context_line":"            raise exception.ManageExistingInvalidReference(**kwargs)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"        # Attempt to rename the LV to match the OpenStack internal name."}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_22fb8148","line":522,"in_reply_to":"1aa78d24_4880838b","updated":"2016-07-13 11:19:53.000000000","message":"Done","commit_id":"33edcc7cf261cbe9dd2f1925c69aef25b1bab3a9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8c85fb8cff0466da493f862da3ed9c76aeffa0a4","unresolved":false,"context_lines":[{"line_number":530,"context_line":"        \"\"\"Manages an existing LV.\"\"\""},{"line_number":531,"context_line":"        self._manage_existing(volume, existing_ref)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def manage_existing_get_size(self, volume, existing_ref):"},{"line_number":534,"context_line":"        \"\"\"Return size of an existing LV for manage_existing.\"\"\""},{"line_number":535,"context_line":"        # Check that the reference is valid"},{"line_number":536,"context_line":"        if \u0027source-name\u0027 not in existing_ref:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_2829b79b","line":533,"updated":"2016-07-12 20:03:32.000000000","message":"This is used by both so a flag should be passed in so the message can differentiate between volume and snapshot.","commit_id":"33edcc7cf261cbe9dd2f1925c69aef25b1bab3a9"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"e12d5c5299030e01b308d735287b97463db75b33","unresolved":false,"context_lines":[{"line_number":530,"context_line":"        \"\"\"Manages an existing LV.\"\"\""},{"line_number":531,"context_line":"        self._manage_existing(volume, existing_ref)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def manage_existing_get_size(self, volume, existing_ref):"},{"line_number":534,"context_line":"        \"\"\"Return size of an existing LV for manage_existing.\"\"\""},{"line_number":535,"context_line":"        # Check that the reference is valid"},{"line_number":536,"context_line":"        if \u0027source-name\u0027 not in existing_ref:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_7d0a4821","line":533,"in_reply_to":"1aa78d24_2829b79b","updated":"2016-07-13 11:19:53.000000000","message":"Done","commit_id":"33edcc7cf261cbe9dd2f1925c69aef25b1bab3a9"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ecd014022486313a49a9475fc4adeb7697592fc1","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        return self.manage_existing_get_size(snapshot, existing_ref)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def unmanage_snapshot(self, snapshot):"},{"line_number":573,"context_line":"        self.unmanage(snapshot)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":576,"context_line":"        \"\"\"Extend an existing volume\u0027s size.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_57dcbbe3","line":573,"range":{"start_line":573,"start_character":8,"end_line":573,"end_character":31},"updated":"2016-07-12 12:18:06.000000000","message":"The function \"self.unmanage\" is unmanage volume, and you use the param \"snapshot\" to unmanage snapshot, but the log in function unmanage is also \"volume\", maybe it\u0027s not correct.","commit_id":"33edcc7cf261cbe9dd2f1925c69aef25b1bab3a9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8c85fb8cff0466da493f862da3ed9c76aeffa0a4","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        return self.manage_existing_get_size(snapshot, existing_ref)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def unmanage_snapshot(self, snapshot):"},{"line_number":573,"context_line":"        self.unmanage(snapshot)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":576,"context_line":"        \"\"\"Extend an existing volume\u0027s size.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_c858f38c","line":573,"range":{"start_line":573,"start_character":8,"end_line":573,"end_character":31},"in_reply_to":"1aa78d24_3105ba79","updated":"2016-07-12 20:03:32.000000000","message":"Can you create a _unmanage with a flag is_snapshot so unmanage() will be passing in a False flag and unmanage_snapshot will pass in a True flag?  Just like what you did with the manage function.  Also messages in the common function should say either \"volume\" or \"snapshot\" depending on is_snapshot to avoid confusion.","commit_id":"33edcc7cf261cbe9dd2f1925c69aef25b1bab3a9"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"58b9749cabadf11074f2211d5e541243cb06010a","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        return self.manage_existing_get_size(snapshot, existing_ref)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def unmanage_snapshot(self, snapshot):"},{"line_number":573,"context_line":"        self.unmanage(snapshot)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":576,"context_line":"        \"\"\"Extend an existing volume\u0027s size.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_3105ba79","line":573,"range":{"start_line":573,"start_character":8,"end_line":573,"end_character":31},"in_reply_to":"1aa78d24_57dcbbe3","updated":"2016-07-12 13:12:02.000000000","message":"since the message refer to an XtremIO volume and in XtremIO snapshot is a volume, I don\u0027t see a problem here","commit_id":"33edcc7cf261cbe9dd2f1925c69aef25b1bab3a9"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"e12d5c5299030e01b308d735287b97463db75b33","unresolved":false,"context_lines":[{"line_number":570,"context_line":"        return self.manage_existing_get_size(snapshot, existing_ref)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def unmanage_snapshot(self, snapshot):"},{"line_number":573,"context_line":"        self.unmanage(snapshot)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":576,"context_line":"        \"\"\"Extend an existing volume\u0027s size.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_c06a6b80","line":573,"range":{"start_line":573,"start_character":8,"end_line":573,"end_character":31},"in_reply_to":"1aa78d24_c858f38c","updated":"2016-07-13 11:19:53.000000000","message":"Done","commit_id":"33edcc7cf261cbe9dd2f1925c69aef25b1bab3a9"}],"releasenotes/notes/xtremio-manage-snapshot-5737d3ad37df81d1.yaml":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8c85fb8cff0466da493f862da3ed9c76aeffa0a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Extend EMC XtremIO cinder volume driver with snapshot manage"},{"line_number":4,"context_line":"    and snapshot unmanage capabilities."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_6809ff94","line":2,"updated":"2016-07-12 20:03:32.000000000","message":"Should be under \"feature\" instead of \"prelude\".","commit_id":"33edcc7cf261cbe9dd2f1925c69aef25b1bab3a9"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"e12d5c5299030e01b308d735287b97463db75b33","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Extend EMC XtremIO cinder volume driver with snapshot manage"},{"line_number":4,"context_line":"    and snapshot unmanage capabilities."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_400afb79","line":2,"in_reply_to":"1aa78d24_6809ff94","updated":"2016-07-13 11:19:53.000000000","message":"Done","commit_id":"33edcc7cf261cbe9dd2f1925c69aef25b1bab3a9"}]}