)]}'
{"cinder/tests/unit/volume/drivers/hpe/test_hpe3par.py":[{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"70a0f570b21e30583fac980dce285affa2891d83","unresolved":false,"context_lines":[{"line_number":2068,"context_line":"            admin_context,"},{"line_number":2069,"context_line":"            name\u003dHPE3PARBaseDriver.VOLUME_NAME,"},{"line_number":2070,"context_line":"            id\u003dHPE3PARBaseDriver.CLONE_ID,"},{"line_number":2071,"context_line":"            display_name\u003d\u0027Foo Volume\u0027,"},{"line_number":2072,"context_line":"            volume_type_id\u003dNone,"},{"line_number":2073,"context_line":"            size\u003d2,"},{"line_number":2074,"context_line":"            status\u003d\u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_a32fdcf4","line":2071,"updated":"2016-09-15 08:29:02.000000000","message":"Could have used self.VOLUME_DISPLAY_NAME","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"465264a2c8ee7e1bccb45d5e5d6534016bc08834","unresolved":false,"context_lines":[{"line_number":2068,"context_line":"            admin_context,"},{"line_number":2069,"context_line":"            name\u003dHPE3PARBaseDriver.VOLUME_NAME,"},{"line_number":2070,"context_line":"            id\u003dHPE3PARBaseDriver.CLONE_ID,"},{"line_number":2071,"context_line":"            display_name\u003d\u0027Foo Volume\u0027,"},{"line_number":2072,"context_line":"            volume_type_id\u003dNone,"},{"line_number":2073,"context_line":"            size\u003d2,"},{"line_number":2074,"context_line":"            status\u003d\u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_e2f8454c","line":2071,"in_reply_to":"7a8ec9b2_a32fdcf4","updated":"2016-09-19 20:31:04.000000000","message":"Done","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"70a0f570b21e30583fac980dce285affa2891d83","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"            admin_context,"},{"line_number":2113,"context_line":"            name\u003dHPE3PARBaseDriver.VOLUME_NAME,"},{"line_number":2114,"context_line":"            id\u003dHPE3PARBaseDriver.CLONE_ID,"},{"line_number":2115,"context_line":"            display_name\u003d\u0027Foo Volume\u0027,"},{"line_number":2116,"context_line":"            volume_type_id\u003dNone,"},{"line_number":2117,"context_line":"            size\u003d2,"},{"line_number":2118,"context_line":"            status\u003d\u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_e339e442","line":2115,"updated":"2016-09-15 08:29:02.000000000","message":"self.VOLUME_DISPLAY_NAME","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"465264a2c8ee7e1bccb45d5e5d6534016bc08834","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"            admin_context,"},{"line_number":2113,"context_line":"            name\u003dHPE3PARBaseDriver.VOLUME_NAME,"},{"line_number":2114,"context_line":"            id\u003dHPE3PARBaseDriver.CLONE_ID,"},{"line_number":2115,"context_line":"            display_name\u003d\u0027Foo Volume\u0027,"},{"line_number":2116,"context_line":"            volume_type_id\u003dNone,"},{"line_number":2117,"context_line":"            size\u003d2,"},{"line_number":2118,"context_line":"            status\u003d\u0027available\u0027,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_22994d20","line":2115,"in_reply_to":"7a8ec9b2_e339e442","updated":"2016-09-19 20:31:04.000000000","message":"Done","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"70a0f570b21e30583fac980dce285affa2891d83","unresolved":false,"context_lines":[{"line_number":2164,"context_line":"            name\u003dHPE3PARBaseDriver.VOLUME_NAME,"},{"line_number":2165,"context_line":"            volume_type_id\u003dNone,"},{"line_number":2166,"context_line":"            id\u003dHPE3PARBaseDriver.CLONE_ID,"},{"line_number":2167,"context_line":"            display_name\u003d\u0027Foo Volume\u0027,"},{"line_number":2168,"context_line":"            size\u003d2,"},{"line_number":2169,"context_line":"            status\u003d\u0027in-use\u0027,"},{"line_number":2170,"context_line":"            host\u003dHPE3PARBaseDriver.FAKE_HOST,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_a316fca4","line":2167,"updated":"2016-09-15 08:29:02.000000000","message":"self.VOLUME_DISPLAY_NAME","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"465264a2c8ee7e1bccb45d5e5d6534016bc08834","unresolved":false,"context_lines":[{"line_number":2164,"context_line":"            name\u003dHPE3PARBaseDriver.VOLUME_NAME,"},{"line_number":2165,"context_line":"            volume_type_id\u003dNone,"},{"line_number":2166,"context_line":"            id\u003dHPE3PARBaseDriver.CLONE_ID,"},{"line_number":2167,"context_line":"            display_name\u003d\u0027Foo Volume\u0027,"},{"line_number":2168,"context_line":"            size\u003d2,"},{"line_number":2169,"context_line":"            status\u003d\u0027in-use\u0027,"},{"line_number":2170,"context_line":"            host\u003dHPE3PARBaseDriver.FAKE_HOST,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_e28f65ca","line":2167,"in_reply_to":"7a8ec9b2_a316fca4","updated":"2016-09-19 20:31:04.000000000","message":"Done","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"70a0f570b21e30583fac980dce285affa2891d83","unresolved":false,"context_lines":[{"line_number":2225,"context_line":"            name\u003dHPE3PARBaseDriver.VOLUME_NAME,"},{"line_number":2226,"context_line":"            volume_type_id\u003dNone,"},{"line_number":2227,"context_line":"            id\u003dHPE3PARBaseDriver.CLONE_ID,"},{"line_number":2228,"context_line":"            display_name\u003d\u0027Foo Volume\u0027,"},{"line_number":2229,"context_line":"            size\u003d2,"},{"line_number":2230,"context_line":"            status\u003d\u0027in-use\u0027,"},{"line_number":2231,"context_line":"            host\u003dHPE3PARBaseDriver.FAKE_HOST,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_e31004ab","line":2228,"updated":"2016-09-15 08:29:02.000000000","message":"self.VOLUME_DISPLAY_NAME","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"465264a2c8ee7e1bccb45d5e5d6534016bc08834","unresolved":false,"context_lines":[{"line_number":2225,"context_line":"            name\u003dHPE3PARBaseDriver.VOLUME_NAME,"},{"line_number":2226,"context_line":"            volume_type_id\u003dNone,"},{"line_number":2227,"context_line":"            id\u003dHPE3PARBaseDriver.CLONE_ID,"},{"line_number":2228,"context_line":"            display_name\u003d\u0027Foo Volume\u0027,"},{"line_number":2229,"context_line":"            size\u003d2,"},{"line_number":2230,"context_line":"            status\u003d\u0027in-use\u0027,"},{"line_number":2231,"context_line":"            host\u003dHPE3PARBaseDriver.FAKE_HOST,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_c29269f6","line":2228,"in_reply_to":"7a8ec9b2_e31004ab","updated":"2016-09-19 20:31:04.000000000","message":"Done","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"70a0f570b21e30583fac980dce285affa2891d83","unresolved":false,"context_lines":[{"line_number":2249,"context_line":"        fake_old_volume \u003d fake_volume.fake_volume_obj("},{"line_number":2250,"context_line":"            admin_context,"},{"line_number":2251,"context_line":"            id\u003dself.VOLUME_ID)"},{"line_number":2252,"context_line":"        provider_location \u003d \u0027foo\u0027"},{"line_number":2253,"context_line":"        fake_new_volume \u003d fake_volume.fake_volume_obj("},{"line_number":2254,"context_line":"            admin_context,"},{"line_number":2255,"context_line":"            id\u003dself.CLONE_ID,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_c384e8d5","line":2252,"updated":"2016-09-15 08:29:02.000000000","message":"Can we have Macro for provider_location?","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"465264a2c8ee7e1bccb45d5e5d6534016bc08834","unresolved":false,"context_lines":[{"line_number":2249,"context_line":"        fake_old_volume \u003d fake_volume.fake_volume_obj("},{"line_number":2250,"context_line":"            admin_context,"},{"line_number":2251,"context_line":"            id\u003dself.VOLUME_ID)"},{"line_number":2252,"context_line":"        provider_location \u003d \u0027foo\u0027"},{"line_number":2253,"context_line":"        fake_new_volume \u003d fake_volume.fake_volume_obj("},{"line_number":2254,"context_line":"            admin_context,"},{"line_number":2255,"context_line":"            id\u003dself.CLONE_ID,"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_02629116","line":2252,"in_reply_to":"7a8ec9b2_c384e8d5","updated":"2016-09-19 20:31:04.000000000","message":"you can do it in a follow up.  It has no relevance to this patch.","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"70a0f570b21e30583fac980dce285affa2891d83","unresolved":false,"context_lines":[{"line_number":3044,"context_line":"            admin_context,"},{"line_number":3045,"context_line":"            display_name\u003dNone,"},{"line_number":3046,"context_line":"            host\u003dself.FAKE_CINDER_HOST,"},{"line_number":3047,"context_line":"            volume_type\u003d\u0027gold\u0027,"},{"line_number":3048,"context_line":"            volume_type_id\u003d\u0027acfa9fa4-54a0-4340-a3d8-bfcf19aea65e\u0027,"},{"line_number":3049,"context_line":"            id\u003d\u0027007dbfce-7579-40bc-8f90-a20b3902283e\u0027)"},{"line_number":3050,"context_line":""},{"line_number":3051,"context_line":"        mock_client.getVolume.return_value \u003d self.MANAGE_VOLUME_INFO"},{"line_number":3052,"context_line":"        mock_client.modifyVolume.return_value \u003d (\"anyResponse\", {\u0027taskid\u0027: 1})"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_03041048","line":3049,"range":{"start_line":3047,"start_character":0,"end_line":3049,"end_character":54},"updated":"2016-09-15 08:29:02.000000000","message":"Macros can be used for these too!","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"465264a2c8ee7e1bccb45d5e5d6534016bc08834","unresolved":false,"context_lines":[{"line_number":3044,"context_line":"            admin_context,"},{"line_number":3045,"context_line":"            display_name\u003dNone,"},{"line_number":3046,"context_line":"            host\u003dself.FAKE_CINDER_HOST,"},{"line_number":3047,"context_line":"            volume_type\u003d\u0027gold\u0027,"},{"line_number":3048,"context_line":"            volume_type_id\u003d\u0027acfa9fa4-54a0-4340-a3d8-bfcf19aea65e\u0027,"},{"line_number":3049,"context_line":"            id\u003d\u0027007dbfce-7579-40bc-8f90-a20b3902283e\u0027)"},{"line_number":3050,"context_line":""},{"line_number":3051,"context_line":"        mock_client.getVolume.return_value \u003d self.MANAGE_VOLUME_INFO"},{"line_number":3052,"context_line":"        mock_client.modifyVolume.return_value \u003d (\"anyResponse\", {\u0027taskid\u0027: 1})"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_8276a1d6","line":3049,"range":{"start_line":3047,"start_character":0,"end_line":3049,"end_character":54},"in_reply_to":"7a8ec9b2_03041048","updated":"2016-09-19 20:31:04.000000000","message":"This has no relevance in this patch.","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"70a0f570b21e30583fac980dce285affa2891d83","unresolved":false,"context_lines":[{"line_number":3990,"context_line":""},{"line_number":3991,"context_line":"            # create a consistency group"},{"line_number":3992,"context_line":"            group \u003d self.fake_consistencygroup_object()"},{"line_number":3993,"context_line":"            self.driver.create_consistencygroup(context.get_admin_context(),"},{"line_number":3994,"context_line":"                                                group)"},{"line_number":3995,"context_line":""},{"line_number":3996,"context_line":"            expected \u003d ["}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_4e363fe7","line":3993,"range":{"start_line":3993,"start_character":48,"end_line":3993,"end_character":75},"updated":"2016-09-15 08:29:02.000000000","message":"Can it be replaced with admin_context?\n\nif yes, need to be replaced each places in file.","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"465264a2c8ee7e1bccb45d5e5d6534016bc08834","unresolved":false,"context_lines":[{"line_number":3990,"context_line":""},{"line_number":3991,"context_line":"            # create a consistency group"},{"line_number":3992,"context_line":"            group \u003d self.fake_consistencygroup_object()"},{"line_number":3993,"context_line":"            self.driver.create_consistencygroup(context.get_admin_context(),"},{"line_number":3994,"context_line":"                                                group)"},{"line_number":3995,"context_line":""},{"line_number":3996,"context_line":"            expected \u003d ["}],"source_content_type":"text/x-python","patch_set":22,"id":"7a8ec9b2_4243b96c","line":3993,"range":{"start_line":3993,"start_character":48,"end_line":3993,"end_character":75},"in_reply_to":"7a8ec9b2_4e363fe7","updated":"2016-09-19 20:31:04.000000000","message":"has no relevance in this patch.","commit_id":"9312a6e6de2528a5d36d16913fc5e0336af952ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        admin_context,"},{"line_number":161,"context_line":"        host\u003dFAKE_CINDER_HOST,"},{"line_number":162,"context_line":"        id\u003dVOLUME_ID,"},{"line_number":163,"context_line":"        name\u003dVOLUME_NAME,"},{"line_number":164,"context_line":"        display_name\u003dVOLUME_DISPLAY_NAME,"},{"line_number":165,"context_line":"        size\u003d2,"},{"line_number":166,"context_line":"        volume_type\u003dNone,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_d4364be6","line":163,"updated":"2016-09-30 09:14:34.000000000","message":"-1: name is not a field, it\u0027s a Python property, so it shouldn\u0027t be set.  It will be generated with:\n\n CONF.volume_name_template % self.name_id\n\nThis applies to the other cases in the file as well.","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        name\u003dVOLUME_NAME,"},{"line_number":164,"context_line":"        display_name\u003dVOLUME_DISPLAY_NAME,"},{"line_number":165,"context_line":"        size\u003d2,"},{"line_number":166,"context_line":"        volume_type\u003dNone,"},{"line_number":167,"context_line":"        volume_type_id\u003dNone)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    volume_src_cg \u003d {\u0027name\u0027: SRC_CG_VOLUME_NAME,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_f44c2772","line":166,"updated":"2016-09-30 09:14:34.000000000","message":"nit: If volume_type_id is set to None there should be no need to specify this one.  This applies to the other cases in the file as well.","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    volume_replicated \u003d fake_volume.fake_volume_obj("},{"line_number":178,"context_line":"        admin_context,"},{"line_number":179,"context_line":"        id\u003dVOLUME_ID,"},{"line_number":180,"context_line":"        name\u003dVOLUME_NAME,"},{"line_number":181,"context_line":"        display_name\u003dVOLUME_DISPLAY_NAME,"},{"line_number":182,"context_line":"        replication_status\u003d\u0027disabled\u0027,"},{"line_number":183,"context_line":"        provider_location\u003dCLIENT_ID,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_349ccfbf","line":180,"updated":"2016-09-30 09:14:34.000000000","message":"ditto","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        provider_location\u003dCLIENT_ID,"},{"line_number":184,"context_line":"        size\u003d2,"},{"line_number":185,"context_line":"        host\u003dFAKE_CINDER_HOST,"},{"line_number":186,"context_line":"        volume_type\u003d\u0027replicated\u0027,"},{"line_number":187,"context_line":"        volume_type_id\u003dVOLUME_TYPE_ID_REPLICATED)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    replication_targets \u003d [{\u0027backend_id\u0027: REPLICATION_BACKEND_ID,"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_f4ba6722","line":186,"updated":"2016-09-30 09:14:34.000000000","message":"-1: This is wrong, as volume_type should be an objects.VolumeType object","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        display_name\u003dVOLUME_DISPLAY_NAME,"},{"line_number":219,"context_line":"        size\u003d2,"},{"line_number":220,"context_line":"        host\u003dFAKE_CINDER_HOST,"},{"line_number":221,"context_line":"        volume_type\u003d\u0027dedup\u0027,"},{"line_number":222,"context_line":"        volume_type_id\u003dVOLUME_TYPE_ID_DEDUP)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    volume_pool \u003d fake_volume.fake_volume_obj("}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_7442d711","line":221,"updated":"2016-09-30 09:14:34.000000000","message":"ditto","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"875e7c141cb9c12080ee47ea1f3817da5ff29406","unresolved":false,"context_lines":[{"line_number":3029,"context_line":"                    # Make sure all volumes are fully synced."},{"line_number":3030,"context_line":"                    volumes \u003d rcg[\u0027volumes\u0027]"},{"line_number":3031,"context_line":"                    for volume in volumes:"},{"line_number":3032,"context_line":"                        remote_volumes \u003d volume.remoteVolumes"},{"line_number":3033,"context_line":"                        for remote_volume in remote_volumes:"},{"line_number":3034,"context_line":"                            if remote_volume.syncStatus !\u003d ("},{"line_number":3035,"context_line":"                               self.SYNC_STATUS_COMPLETED):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a98d1f4_7e7acdf2","line":3032,"updated":"2016-09-29 20:30:46.000000000","message":"\"remoteVolumes\" is not a field in the volume object:\n\nhttps://github.com/openstack/cinder/blob/master/cinder/objects/volume.py#L67\n\nAre you sure you can retrieve it like this?","commit_id":"f113ea4154199f5610ac73767676a153beab364f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"115d6cb6740b060f18112e6b3dd1f9e3d5319d9f","unresolved":false,"context_lines":[{"line_number":3029,"context_line":"                    # Make sure all volumes are fully synced."},{"line_number":3030,"context_line":"                    volumes \u003d rcg[\u0027volumes\u0027]"},{"line_number":3031,"context_line":"                    for volume in volumes:"},{"line_number":3032,"context_line":"                        remote_volumes \u003d volume.remoteVolumes"},{"line_number":3033,"context_line":"                        for remote_volume in remote_volumes:"},{"line_number":3034,"context_line":"                            if remote_volume.syncStatus !\u003d ("},{"line_number":3035,"context_line":"                               self.SYNC_STATUS_COMPLETED):"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a98d1f4_8161fc3b","line":3032,"in_reply_to":"3a98d1f4_7e7acdf2","updated":"2016-09-29 21:00:07.000000000","message":"Oops, this is actually a volume dictionary that comes back from the 3PAR, not a cinder volume object....","commit_id":"f113ea4154199f5610ac73767676a153beab364f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"875e7c141cb9c12080ee47ea1f3817da5ff29406","unresolved":false,"context_lines":[{"line_number":3031,"context_line":"                    for volume in volumes:"},{"line_number":3032,"context_line":"                        remote_volumes \u003d volume.remoteVolumes"},{"line_number":3033,"context_line":"                        for remote_volume in remote_volumes:"},{"line_number":3034,"context_line":"                            if remote_volume.syncStatus !\u003d ("},{"line_number":3035,"context_line":"                               self.SYNC_STATUS_COMPLETED):"},{"line_number":3036,"context_line":"                                return False"},{"line_number":3037,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a98d1f4_7e61ed38","line":3034,"updated":"2016-09-29 20:30:46.000000000","message":"Same as above.  \"syncStatus\" is not a field in the volume object.","commit_id":"f113ea4154199f5610ac73767676a153beab364f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"115d6cb6740b060f18112e6b3dd1f9e3d5319d9f","unresolved":false,"context_lines":[{"line_number":3031,"context_line":"                    for volume in volumes:"},{"line_number":3032,"context_line":"                        remote_volumes \u003d volume.remoteVolumes"},{"line_number":3033,"context_line":"                        for remote_volume in remote_volumes:"},{"line_number":3034,"context_line":"                            if remote_volume.syncStatus !\u003d ("},{"line_number":3035,"context_line":"                               self.SYNC_STATUS_COMPLETED):"},{"line_number":3036,"context_line":"                                return False"},{"line_number":3037,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a98d1f4_a1643849","line":3034,"in_reply_to":"3a98d1f4_7e61ed38","updated":"2016-09-29 21:00:07.000000000","message":"same","commit_id":"f113ea4154199f5610ac73767676a153beab364f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        new_comment[\u0027name\u0027] \u003d name"},{"line_number":748,"context_line":"        new_comment[\u0027type\u0027] \u003d \u0027OpenStack\u0027"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        volume_type \u003d None"},{"line_number":751,"context_line":"        if volume.volume_type_id:"},{"line_number":752,"context_line":"            try:"},{"line_number":753,"context_line":"                volume_type \u003d self._get_volume_type(volume.volume_type_id)"},{"line_number":754,"context_line":"            except Exception:"},{"line_number":755,"context_line":"                reason \u003d (_(\"Volume type ID \u0027%s\u0027 is invalid.\") %"},{"line_number":756,"context_line":"                          volume.volume_type_id)"},{"line_number":757,"context_line":"                raise exception.ManageExistingVolumeTypeMismatch(reason\u003dreason)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        new_vals \u003d {\u0027newName\u0027: new_vol_name,"},{"line_number":760,"context_line":"                    \u0027comment\u0027: json.dumps(new_comment)}"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_b1de316b","line":757,"range":{"start_line":750,"start_character":0,"end_line":757,"end_character":79},"updated":"2016-09-30 09:14:34.000000000","message":"-1: If we have an OVO we should be using volume.volume_type","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"    def _extend_volume(self, volume, volume_name, growth_size_mib,"},{"line_number":1006,"context_line":"                       _convert_to_base\u003dFalse):"},{"line_number":1007,"context_line":"        model_update \u003d None"},{"line_number":1008,"context_line":"        rcg_name \u003d self._get_3par_rcg_name(volume.id)"},{"line_number":1009,"context_line":"        is_volume_replicated \u003d self._volume_of_replicated_type(volume)"},{"line_number":1010,"context_line":"        try:"},{"line_number":1011,"context_line":"            if _convert_to_base:"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_31d4e11e","line":1008,"range":{"start_line":1008,"start_character":43,"end_line":1008,"end_character":52},"updated":"2016-09-30 09:14:34.000000000","message":"This should be volume.name_id, but that\u0027s a different bug and out of the scope of this patch.  If I\u0027m not mistaken this also happens other places like L1404, L1413, etc.","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":2320,"context_line":"        ret \u003d False, None"},{"line_number":2321,"context_line":""},{"line_number":2322,"context_line":"        if volume.status in [\u0027available\u0027, \u0027in-use\u0027]:"},{"line_number":2323,"context_line":"            volume_type \u003d None"},{"line_number":2324,"context_line":"            if volume.volume_type_id:"},{"line_number":2325,"context_line":"                volume_type \u003d self._get_volume_type(volume.volume_type_id)"},{"line_number":2326,"context_line":""},{"line_number":2327,"context_line":"            try:"},{"line_number":2328,"context_line":"                ret \u003d self.retype(volume, volume_type, None, host)"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_9102156e","line":2325,"range":{"start_line":2323,"start_character":0,"end_line":2325,"end_character":74},"updated":"2016-09-30 09:14:34.000000000","message":"-1:\n\n volume_type \u003d volume.volume_type","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":2363,"context_line":"                              \"%(orig)s failed because %(reason)s\"),"},{"line_number":2364,"context_line":"                          {\u0027tmp\u0027: current_name, \u0027orig\u0027: original_name,"},{"line_number":2365,"context_line":"                           \u0027reason\u0027: e})"},{"line_number":2366,"context_line":"                name_id \u003d new_volume._name_id or new_volume.id"},{"line_number":2367,"context_line":"                provider_location \u003d new_volume.provider_location"},{"line_number":2368,"context_line":"        else:"},{"line_number":2369,"context_line":"            # the backend can\u0027t change the name."}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_b1555151","line":2366,"updated":"2016-09-30 09:14:34.000000000","message":"-1:\n\n name_id \u003d new_volume.name_id","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":2367,"context_line":"                provider_location \u003d new_volume.provider_location"},{"line_number":2368,"context_line":"        else:"},{"line_number":2369,"context_line":"            # the backend can\u0027t change the name."},{"line_number":2370,"context_line":"            name_id \u003d new_volume._name_id or new_volume.id"},{"line_number":2371,"context_line":"            provider_location \u003d new_volume.provider_location"},{"line_number":2372,"context_line":""},{"line_number":2373,"context_line":"        return {\u0027_name_id\u0027: name_id, \u0027provider_location\u0027: provider_location}"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_51640d48","line":2370,"updated":"2016-09-30 09:14:34.000000000","message":"ditto","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"}],"cinder/volume/drivers/hpe/hpe_3par_fc.py":[{"author":{"_account_id":22257,"name":"Manish","email":"deolalkar.manish@hpe.com","username":"manishd"},"change_message_id":"bd6ce2893aaa662365dafb107ca1f4ecd5eca43f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        3.0.9 - Handling HTTP conflict 409, host WWN/iSCSI name already used"},{"line_number":114,"context_line":"                by another host, while creating 3PAR FC Host. bug #1597454"},{"line_number":115,"context_line":"        3.0.10 - Added Entry point tracing"},{"line_number":116,"context_line":"        3.1.0 - Convert over to using OSLO Version objected for volume."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_bd22afff","line":116,"range":{"start_line":116,"start_character":32,"end_line":116,"end_character":37},"updated":"2016-08-19 09:13:34.000000000","message":"Please change \u0027OSLO Version objected\u0027 to \u0027OSLO Versioned object\u0027.","commit_id":"9b55402a988a2644fd172477ea3e045dcac2b109"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"04a143663248acaa274e707c3f6f97d1befb8aad","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        3.0.9 - Handling HTTP conflict 409, host WWN/iSCSI name already used"},{"line_number":114,"context_line":"                by another host, while creating 3PAR FC Host. bug #1597454"},{"line_number":115,"context_line":"        3.0.10 - Added Entry point tracing"},{"line_number":116,"context_line":"        3.1.0 - Convert over to using OSLO Version objected for volume."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    \"\"\""},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_44ed68ee","line":116,"range":{"start_line":116,"start_character":32,"end_line":116,"end_character":37},"in_reply_to":"3ac371cc_bd22afff","updated":"2016-08-25 16:45:23.000000000","message":"Done","commit_id":"9b55402a988a2644fd172477ea3e045dcac2b109"}],"cinder/volume/drivers/hpe/hpe_3par_iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2925acc78df5186c16bbd839be95e8d0628bcfca","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            return model_update"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"        # CHAP username will be the hostname"},{"line_number":620,"context_line":"        chap_username \u003d volume.host.split(\u0027@\u0027)[0]"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"        chap_password \u003d None"},{"line_number":623,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a98d1f4_54f23b70","line":620,"updated":"2016-09-30 09:14:34.000000000","message":"nit: This should be using cinder.volume.utils.extract_host","commit_id":"b4f8f38de98b46671ea1ff108ab6ae79b1fd9495"}]}