)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5a612068e7d44f7425531379fa7f349678d2f207","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Not convert charset and engine of mysql tables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now, all new mysql db tables is created in utf8 charset"},{"line_number":10,"context_line":"and use InnoDB engine."},{"line_number":11,"context_line":"It\u0027s not necessary to do an extra convert action after"},{"line_number":12,"context_line":"tables are created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_4b27fc11","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":31},"updated":"2016-07-12 14:37:39.000000000","message":"are","commit_id":"ce5444a28b8821f0ae5c7779477bc1a501d83ab8"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"eb3cb3826b03fabf0f833db10086ada0c13c40e0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Not convert charset and engine of mysql tables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now, all new mysql db tables is created in utf8 charset"},{"line_number":10,"context_line":"and use InnoDB engine."},{"line_number":11,"context_line":"It\u0027s not necessary to do an extra convert action after"},{"line_number":12,"context_line":"tables are created."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_2ed89552","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":31},"in_reply_to":"1aa78d24_4b27fc11","updated":"2016-07-13 01:39:23.000000000","message":"Done","commit_id":"ce5444a28b8821f0ae5c7779477bc1a501d83ab8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5a612068e7d44f7425531379fa7f349678d2f207","unresolved":false,"context_lines":[{"line_number":12,"context_line":"tables are created."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Some comma is also added to keep consistency, which"},{"line_number":15,"context_line":"applys to our hacking rules [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PS, this change is submmited to address some unsolved comments of"},{"line_number":18,"context_line":"another patch[2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_8b1d64c0","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":6},"updated":"2016-07-12 14:37:39.000000000","message":"applies","commit_id":"ce5444a28b8821f0ae5c7779477bc1a501d83ab8"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"eb3cb3826b03fabf0f833db10086ada0c13c40e0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"tables are created."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Some comma is also added to keep consistency, which"},{"line_number":15,"context_line":"applys to our hacking rules [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PS, this change is submmited to address some unsolved comments of"},{"line_number":18,"context_line":"another patch[2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_8edb894e","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":6},"in_reply_to":"1aa78d24_8b1d64c0","updated":"2016-07-13 01:39:23.000000000","message":"Done","commit_id":"ce5444a28b8821f0ae5c7779477bc1a501d83ab8"}],"cinder/db/sqlalchemy/migrate_repo/versions/046_cinder_init.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7b8b2ff6be239619e311c784674c8441f28aa1fc","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                  \"volume_admin_metadata\","},{"line_number":538,"context_line":"                  \"driver_initiator_data\"]"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        migrate_engine.execute(\"SET foreign_key_checks \u003d 1\")"},{"line_number":541,"context_line":"        migrate_engine.execute("},{"line_number":542,"context_line":"            \"ALTER DATABASE %s DEFAULT CHARACTER SET utf8\" %"},{"line_number":543,"context_line":"            migrate_engine.url.database)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_15ed9d8e","line":540,"range":{"start_line":540,"start_character":0,"end_line":540,"end_character":60},"updated":"2016-07-08 11:11:43.000000000","message":"This one is not needed then.","commit_id":"e00dc2662c71621d6278b2cceb7172e7d63b49f9"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"e71b22ea0086940e7c54d90a9a904a27bc527ed1","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                  \"volume_admin_metadata\","},{"line_number":538,"context_line":"                  \"driver_initiator_data\"]"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        migrate_engine.execute(\"SET foreign_key_checks \u003d 1\")"},{"line_number":541,"context_line":"        migrate_engine.execute("},{"line_number":542,"context_line":"            \"ALTER DATABASE %s DEFAULT CHARACTER SET utf8\" %"},{"line_number":543,"context_line":"            migrate_engine.url.database)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_325886fa","line":540,"range":{"start_line":540,"start_character":0,"end_line":540,"end_character":60},"in_reply_to":"1aa78d24_15ed9d8e","updated":"2016-07-09 03:09:25.000000000","message":"Done","commit_id":"e00dc2662c71621d6278b2cceb7172e7d63b49f9"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7b8b2ff6be239619e311c784674c8441f28aa1fc","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        migrate_engine.execute("},{"line_number":542,"context_line":"            \"ALTER DATABASE %s DEFAULT CHARACTER SET utf8\" %"},{"line_number":543,"context_line":"            migrate_engine.url.database)"},{"line_number":544,"context_line":"        migrate_engine.execute(\"ALTER TABLE %s Engine\u003dInnoDB\" % table)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    # Set default quota class values"},{"line_number":547,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_95018d3c","line":544,"range":{"start_line":544,"start_character":0,"end_line":544,"end_character":70},"updated":"2016-07-08 11:11:43.000000000","message":"Do we need this one?","commit_id":"e00dc2662c71621d6278b2cceb7172e7d63b49f9"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"e71b22ea0086940e7c54d90a9a904a27bc527ed1","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        migrate_engine.execute("},{"line_number":542,"context_line":"            \"ALTER DATABASE %s DEFAULT CHARACTER SET utf8\" %"},{"line_number":543,"context_line":"            migrate_engine.url.database)"},{"line_number":544,"context_line":"        migrate_engine.execute(\"ALTER TABLE %s Engine\u003dInnoDB\" % table)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    # Set default quota class values"},{"line_number":547,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_72ce8e84","line":544,"range":{"start_line":544,"start_character":64,"end_line":544,"end_character":69},"updated":"2016-07-09 03:09:25.000000000","message":"The value \"table\" is the last value of list \"tables\"","commit_id":"e00dc2662c71621d6278b2cceb7172e7d63b49f9"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"e71b22ea0086940e7c54d90a9a904a27bc527ed1","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        migrate_engine.execute("},{"line_number":542,"context_line":"            \"ALTER DATABASE %s DEFAULT CHARACTER SET utf8\" %"},{"line_number":543,"context_line":"            migrate_engine.url.database)"},{"line_number":544,"context_line":"        migrate_engine.execute(\"ALTER TABLE %s Engine\u003dInnoDB\" % table)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    # Set default quota class values"},{"line_number":547,"context_line":"    quota_classes \u003d Table(\u0027quota_classes\u0027, meta, autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_f25d5eed","line":544,"range":{"start_line":544,"start_character":0,"end_line":544,"end_character":70},"in_reply_to":"1aa78d24_95018d3c","updated":"2016-07-09 03:09:25.000000000","message":"Yeah, we don\u0027t need it.\nAlso this line is out of the scope of loop, so we will only update the last table \"driver_initiator_data\" before this change.","commit_id":"e00dc2662c71621d6278b2cceb7172e7d63b49f9"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5a612068e7d44f7425531379fa7f349678d2f207","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        table.create()"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":515,"context_line":"        tables \u003d [\"consistencygroups\","},{"line_number":516,"context_line":"                  \"cgsnapshots\","},{"line_number":517,"context_line":"                  \"snapshots\","},{"line_number":518,"context_line":"                  \"snapshot_metadata\","},{"line_number":519,"context_line":"                  \"quality_of_service_specs\","},{"line_number":520,"context_line":"                  \"volume_types\","},{"line_number":521,"context_line":"                  \"volume_type_projects\","},{"line_number":522,"context_line":"                  \"volumes\","},{"line_number":523,"context_line":"                  \"volume_attachment\","},{"line_number":524,"context_line":"                  \"iscsi_targets\","},{"line_number":525,"context_line":"                  \"migrate_version\","},{"line_number":526,"context_line":"                  \"quotas\","},{"line_number":527,"context_line":"                  \"services\","},{"line_number":528,"context_line":"                  \"volume_metadata\","},{"line_number":529,"context_line":"                  \"volume_type_extra_specs\","},{"line_number":530,"context_line":"                  \"quota_classes\","},{"line_number":531,"context_line":"                  \"quota_usages\","},{"line_number":532,"context_line":"                  \"reservations\","},{"line_number":533,"context_line":"                  \"volume_glance_metadata\","},{"line_number":534,"context_line":"                  \"backups\","},{"line_number":535,"context_line":"                  \"transfers\","},{"line_number":536,"context_line":"                  \"encryption\","},{"line_number":537,"context_line":"                  \"volume_admin_metadata\","},{"line_number":538,"context_line":"                  \"driver_initiator_data\"]"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        migrate_engine.execute("},{"line_number":541,"context_line":"            \"ALTER DATABASE %s DEFAULT CHARACTER SET utf8\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_c0df3ed4","line":538,"range":{"start_line":515,"start_character":0,"end_line":538,"end_character":42},"updated":"2016-07-12 14:37:39.000000000","message":"So now it looks like we don\u0027t need tables variable as well…","commit_id":"ce5444a28b8821f0ae5c7779477bc1a501d83ab8"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"eb3cb3826b03fabf0f833db10086ada0c13c40e0","unresolved":false,"context_lines":[{"line_number":512,"context_line":"        table.create()"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    if migrate_engine.name \u003d\u003d \"mysql\":"},{"line_number":515,"context_line":"        tables \u003d [\"consistencygroups\","},{"line_number":516,"context_line":"                  \"cgsnapshots\","},{"line_number":517,"context_line":"                  \"snapshots\","},{"line_number":518,"context_line":"                  \"snapshot_metadata\","},{"line_number":519,"context_line":"                  \"quality_of_service_specs\","},{"line_number":520,"context_line":"                  \"volume_types\","},{"line_number":521,"context_line":"                  \"volume_type_projects\","},{"line_number":522,"context_line":"                  \"volumes\","},{"line_number":523,"context_line":"                  \"volume_attachment\","},{"line_number":524,"context_line":"                  \"iscsi_targets\","},{"line_number":525,"context_line":"                  \"migrate_version\","},{"line_number":526,"context_line":"                  \"quotas\","},{"line_number":527,"context_line":"                  \"services\","},{"line_number":528,"context_line":"                  \"volume_metadata\","},{"line_number":529,"context_line":"                  \"volume_type_extra_specs\","},{"line_number":530,"context_line":"                  \"quota_classes\","},{"line_number":531,"context_line":"                  \"quota_usages\","},{"line_number":532,"context_line":"                  \"reservations\","},{"line_number":533,"context_line":"                  \"volume_glance_metadata\","},{"line_number":534,"context_line":"                  \"backups\","},{"line_number":535,"context_line":"                  \"transfers\","},{"line_number":536,"context_line":"                  \"encryption\","},{"line_number":537,"context_line":"                  \"volume_admin_metadata\","},{"line_number":538,"context_line":"                  \"driver_initiator_data\"]"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        migrate_engine.execute("},{"line_number":541,"context_line":"            \"ALTER DATABASE %s DEFAULT CHARACTER SET utf8\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_cee911e8","line":538,"range":{"start_line":515,"start_character":0,"end_line":538,"end_character":42},"in_reply_to":"1aa78d24_c0df3ed4","updated":"2016-07-13 01:39:23.000000000","message":"Done","commit_id":"ce5444a28b8821f0ae5c7779477bc1a501d83ab8"}]}