)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"2ced2e209cff843d632b8865d065f23cc4c69890","unresolved":false,"context_lines":[{"line_number":9,"context_line":"the method _from_db_object should be classmethod"},{"line_number":10,"context_line":"instead of staticmethod."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch fixes the issues in OVOs, ConsistencyGroup and"},{"line_number":13,"context_line":"Volume."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If3037c4f0714e4c35ea0bc6b989d0cbae6ad56fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_efec19bd","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":7},"updated":"2016-07-11 18:39:51.000000000","message":"Is there a bug or something associated with this? Judging from the changes and no unit test changes that this is just refactoring, so its unclear what issue this is actually addressing.","commit_id":"667f5a74c104ecce07d5d03babc416cf0014a2f1"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"e968119b996be7907212393a8923c81a5795f2d0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"the method _from_db_object should be classmethod"},{"line_number":10,"context_line":"instead of staticmethod."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch fixes the issues in OVOs, ConsistencyGroup and"},{"line_number":13,"context_line":"Volume."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If3037c4f0714e4c35ea0bc6b989d0cbae6ad56fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_6427abb6","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":7},"in_reply_to":"1aa78d24_d0557a50","updated":"2016-07-11 20:07:27.000000000","message":"Ok, cool. Can you add some of this info into the commit message? Would be good to explain why the change is being made.","commit_id":"667f5a74c104ecce07d5d03babc416cf0014a2f1"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"0ab2d11bef29e14ea1f2c05f6aa121ac1c3a90ab","unresolved":false,"context_lines":[{"line_number":9,"context_line":"the method _from_db_object should be classmethod"},{"line_number":10,"context_line":"instead of staticmethod."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch fixes the issues in OVOs, ConsistencyGroup and"},{"line_number":13,"context_line":"Volume."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If3037c4f0714e4c35ea0bc6b989d0cbae6ad56fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_d0557a50","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":7},"in_reply_to":"1aa78d24_efec19bd","updated":"2016-07-11 19:59:54.000000000","message":"Patrick, \n\nthank you very much for your code review.\n\nThere are two improvements:\n\n1) As Michal Dulko figured out in Patch 251989, that the \u0027OPTIONAL_FILEDS\u0027 should be moved into class definition:\nhttps://review.openstack.org/#/c/251989/22/cinder/objects/qos_specs.py@24\nOVO Volume is this case.\n\n\n2) After moving the \u0027OPTIONAL_FILEDS\u0027 in the class definition, the method _from_db_object() should be @classmethod instead of @staticmethod.\nThe OVO ConsistencyGroup is this case.\n\nNo need to changing the unit test in this patch, since it\u0027s internal method.","commit_id":"667f5a74c104ecce07d5d03babc416cf0014a2f1"}]}