)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"ede49348757403dc940e1b81a668aa5f7e4e2762","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Consist terminate_connection function signature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The function signature in driver.py for terminate_connection is"},{"line_number":10,"context_line":"    def terminate_connection(self, volume, connector, force\u003dFalse, **kwargs)"},{"line_number":11,"context_line":"but some of the drivers use"},{"line_number":12,"context_line":"    def terminate_connection(self, volume, connector, **kwargs)"},{"line_number":13,"context_line":"This patch make all the signature consistent"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPn%2F%2FQ70%3D","line":10,"updated":"2013-07-05 17:41:45.000000000","message":"This is not true, you have added force\u003dFalse to driver.py as part of this patch. Is this a typo perhaps?","commit_id":"fdcda49a531095b14d85071dd2c9c9ad7d56826f"}],"cinder/volume/drivers/coraid.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"149beabe597c993973d93fadb4351aa90fc28c7c","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        pass"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def terminate_connection(self, volume, connector, force\u003dFalse, **kwargs):"},{"line_number":412,"context_line":"        pass"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def ensure_export(self, context, volume):"},{"line_number":415,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fprw%3D","line":412,"updated":"2013-06-25 22:18:04.000000000","message":"you can directly remove this function here.","commit_id":"fdcda49a531095b14d85071dd2c9c9ad7d56826f"}],"cinder/volume/drivers/glusterfs.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"149beabe597c993973d93fadb4351aa90fc28c7c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            \u0027data\u0027: data"},{"line_number":143,"context_line":"        }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def terminate_connection(self, volume, connector, force\u003dFalse, **kwargs):"},{"line_number":146,"context_line":"        \"\"\"Disallow connection from connector.\"\"\""},{"line_number":147,"context_line":"        pass"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fprc%3D","line":145,"updated":"2013-06-25 22:18:04.000000000","message":"remove it","commit_id":"fdcda49a531095b14d85071dd2c9c9ad7d56826f"},{"author":{"_account_id":6939,"name":"Xiaoxi Chen","email":"superdebuger@gmail.com","username":"xiaoxi-chen"},"change_message_id":"b2fe1343579de7d9b495afcb31c1aec69754665f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            \u0027data\u0027: data"},{"line_number":143,"context_line":"        }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def terminate_connection(self, volume, connector, force\u003dFalse, **kwargs):"},{"line_number":146,"context_line":"        \"\"\"Disallow connection from connector.\"\"\""},{"line_number":147,"context_line":"        pass"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FpWw%3D","line":145,"in_reply_to":"AAAAPn%2F%2Fprc%3D","updated":"2013-06-26 01:38:49.000000000","message":"I am not following.\nThere are really lots of drivers put placeholder for terminate_connection.\nSuch cleanup will change the driver behavior from \"do nothing\"\n to an \"Not Implement\" exception.","commit_id":"fdcda49a531095b14d85071dd2c9c9ad7d56826f"}]}