)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e8e59638334976635919d769c182c017e359a1ab","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Switch _create_temp_cloned_volume in driver to VO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit updates _create_temp_cloned_volume method in driver.py"},{"line_number":10,"context_line":"to use Volume object instead of dictionary."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I17eab820fd2cbc004960ae75a2dd4cab6ab6e055"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aa78d24_8b1a846d","line":10,"updated":"2016-07-12 10:42:42.000000000","message":"dictionary\u003d\u003e SQLAlchemy model","commit_id":"662c02b35a9621271abf8ebf77b0ef53ed05f8f7"}],"cinder/volume/driver.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a890fa1db2c3699774beb8dce59bea2d6d4ed16d","unresolved":false,"context_lines":[{"line_number":1374,"context_line":"        temp_vol_ref \u003d objects.Volume(context\u003dcontext, **kwargs)"},{"line_number":1375,"context_line":"        temp_vol_ref.create()"},{"line_number":1376,"context_line":"        try:"},{"line_number":1377,"context_line":"            # Some drivers return None, because they do not need to update the"},{"line_number":1378,"context_line":"            # model for the volume. For those cases we set the model_update to"},{"line_number":1379,"context_line":"            # an empty dictionary."},{"line_number":1380,"context_line":"            model_update \u003d self.create_cloned_volume(temp_vol_ref, volume)"},{"line_number":1381,"context_line":"            if model_update:"},{"line_number":1382,"context_line":"                temp_vol_ref.update(model_update)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_a1368100","line":1379,"range":{"start_line":1377,"start_character":11,"end_line":1379,"end_character":34},"updated":"2016-07-12 11:45:50.000000000","message":"Does this comment still makes sense? I don\u0027t see the empty dictionary being set.","commit_id":"3cf20dc2cd79475bbc2739ff940499223a4df767"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0d682808393b7f71d6b76505094d6a8d964cfc8d","unresolved":false,"context_lines":[{"line_number":1383,"context_line":"                temp_vol_ref.update(model_update)"},{"line_number":1384,"context_line":"        except Exception:"},{"line_number":1385,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1386,"context_line":"                self.db.volume_destroy(context.elevated(), temp_vol_ref.id)"},{"line_number":1387,"context_line":"                temp_vol_ref.destroy()"},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":"        temp_vol_ref.status \u003d \u0027available\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_66dae24c","line":1386,"range":{"start_line":1386,"start_character":16,"end_line":1386,"end_character":75},"updated":"2016-07-12 15:02:51.000000000","message":"Why do we need to destroy the volume twice - with DB and object method? objects.Volume.destroy() will elevate the context for us and execute db.volume_destroy.","commit_id":"de027a1160c6a2057e619ddb6efc056b53dd999c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0d682808393b7f71d6b76505094d6a8d964cfc8d","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"                temp_vol_ref.update(model_update)"},{"line_number":1400,"context_line":"        except Exception:"},{"line_number":1401,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1402,"context_line":"                self.db.volume_destroy(context.elevated(), temp_vol_ref.id)"},{"line_number":1403,"context_line":"                temp_vol_ref.destroy()"},{"line_number":1404,"context_line":""},{"line_number":1405,"context_line":"        temp_vol_ref.status \u003d \u0027available\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_c6ebd6da","line":1402,"range":{"start_line":1402,"start_character":0,"end_line":1402,"end_character":75},"updated":"2016-07-12 15:02:51.000000000","message":"ditto","commit_id":"de027a1160c6a2057e619ddb6efc056b53dd999c"}]}
