)]}'
{"cinder/volume/drivers/zfssa/zfssanfs.py":[{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"f948a33b68a9decfff205749fb768a5ceb367efc","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            cache_vol.provider_location \u003d self.mount_path"},{"line_number":442,"context_line":"            cache_vol.name \u003d cachevol_name"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            self.delete_volume(cache_vol)"},{"line_number":445,"context_line":"            return self._create_cache_volume(context,"},{"line_number":446,"context_line":"                                             img_meta,"},{"line_number":447,"context_line":"                                             img_service,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_78bd1fb0","line":444,"updated":"2016-07-13 14:39:48.000000000","message":"Don\u0027t you need to look now how delete_volume handles a class rather than a dict?","commit_id":"0cdad2c945b99799b367e4080c41653d5e508c9b"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"0de7f75fa00c67d957fb41ef9734df7b8c7e5187","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            cache_vol.provider_location \u003d self.mount_path"},{"line_number":442,"context_line":"            cache_vol.name \u003d cachevol_name"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            self.delete_volume(cache_vol)"},{"line_number":445,"context_line":"            return self._create_cache_volume(context,"},{"line_number":446,"context_line":"                                             img_meta,"},{"line_number":447,"context_line":"                                             img_service,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_f86d8f03","line":444,"in_reply_to":"1aa78d24_78bd1fb0","updated":"2016-07-13 14:45:01.000000000","message":"delete_volume of the parent class is called here. The parent class has already been fixed to handle objects instead of dict. That change was done as part of the versionedobjects change to remotefs.py.","commit_id":"0cdad2c945b99799b367e4080c41653d5e508c9b"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"12257c8cc55dfb872102bf5bbe28aac3a60299cb","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            cache_vol.provider_location \u003d self.mount_path"},{"line_number":442,"context_line":"            cache_vol.name \u003d cachevol_name"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            self.delete_volume(cache_vol)"},{"line_number":445,"context_line":"            return self._create_cache_volume(context,"},{"line_number":446,"context_line":"                                             img_meta,"},{"line_number":447,"context_line":"                                             img_service,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_632734ca","line":444,"in_reply_to":"1aa78d24_e3832454","updated":"2016-07-13 15:01:18.000000000","message":"Thanks. create_volume and delete_volume have been fixed to fetch object\u0027s properties instead of dict\u0027s elements.","commit_id":"0cdad2c945b99799b367e4080c41653d5e508c9b"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"6403f84e9bc7a4bbe9d6472b4b9233c0cf85ef8d","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            cache_vol.provider_location \u003d self.mount_path"},{"line_number":442,"context_line":"            cache_vol.name \u003d cachevol_name"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            self.delete_volume(cache_vol)"},{"line_number":445,"context_line":"            return self._create_cache_volume(context,"},{"line_number":446,"context_line":"                                             img_meta,"},{"line_number":447,"context_line":"                                             img_service,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_e3832454","line":444,"in_reply_to":"1aa78d24_f86d8f03","updated":"2016-07-13 14:52:02.000000000","message":"what I\u0027m talking about is for instance line 221: volume[name],\nNow it\u0027s is hard to know what attributes a class has","commit_id":"0cdad2c945b99799b367e4080c41653d5e508c9b"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"f948a33b68a9decfff205749fb768a5ceb367efc","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        LOG.debug(\u0027Creating cache volume %s\u0027, cache_vol.name, cache_vol.size)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        try:"},{"line_number":466,"context_line":"            self.create_volume(cache_vol)"},{"line_number":467,"context_line":"            LOG.debug(\u0027Copying image data:\u0027)"},{"line_number":468,"context_line":"            super(ZFSSANFSDriver, self).copy_image_to_volume(context,"},{"line_number":469,"context_line":"                                                             cache_vol,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_18fcdb70","line":466,"updated":"2016-07-13 14:39:48.000000000","message":"Same comments as delete_volume","commit_id":"0cdad2c945b99799b367e4080c41653d5e508c9b"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"0de7f75fa00c67d957fb41ef9734df7b8c7e5187","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        LOG.debug(\u0027Creating cache volume %s\u0027, cache_vol.name, cache_vol.size)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        try:"},{"line_number":466,"context_line":"            self.create_volume(cache_vol)"},{"line_number":467,"context_line":"            LOG.debug(\u0027Copying image data:\u0027)"},{"line_number":468,"context_line":"            super(ZFSSANFSDriver, self).copy_image_to_volume(context,"},{"line_number":469,"context_line":"                                                             cache_vol,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_98560b28","line":466,"in_reply_to":"1aa78d24_18fcdb70","updated":"2016-07-13 14:45:01.000000000","message":"Same comment as above. The create_volume() of parent class is called finally and that is already fixed to handle the object.","commit_id":"0cdad2c945b99799b367e4080c41653d5e508c9b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2b12301494a671708294db901c161ce841360a93","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    return zfssarest.ZFSSANfsApi()"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"class Volume(object):"},{"line_number":81,"context_line":"    pass"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_ac6b7f84","line":80,"updated":"2016-07-14 20:13:19.000000000","message":"Why do we need it? It looks confusing","commit_id":"a277eb4db81365231517ee651f01edcd39dded9a"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"de835efa3d72cf9683cd7bcd4267269f637d6b7c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    return zfssarest.ZFSSANfsApi()"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"class Volume(object):"},{"line_number":81,"context_line":"    pass"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_7b133d5d","line":80,"in_reply_to":"1aa78d24_ac6b7f84","updated":"2016-07-15 20:30:27.000000000","message":"thanks. removed it and used Volume VO instead.","commit_id":"a277eb4db81365231517ee651f01edcd39dded9a"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2b12301494a671708294db901c161ce841360a93","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        Returns name of the cache volume."},{"line_number":457,"context_line":"        \"\"\""},{"line_number":458,"context_line":"        cache_vol \u003d Volume()"},{"line_number":459,"context_line":"        cache_vol.provider_location \u003d self.mount_path"},{"line_number":460,"context_line":"        cache_vol.name \u003d cachevol_props[\u0027name\u0027]"},{"line_number":461,"context_line":"        cache_vol.size \u003d cachevol_props[\u0027size\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_ac025fb2","line":458,"updated":"2016-07-14 20:13:19.000000000","message":"I believe, it should be a Volume VO instead of class defined in line #80","commit_id":"a277eb4db81365231517ee651f01edcd39dded9a"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"de835efa3d72cf9683cd7bcd4267269f637d6b7c","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        Returns name of the cache volume."},{"line_number":457,"context_line":"        \"\"\""},{"line_number":458,"context_line":"        cache_vol \u003d Volume()"},{"line_number":459,"context_line":"        cache_vol.provider_location \u003d self.mount_path"},{"line_number":460,"context_line":"        cache_vol.name \u003d cachevol_props[\u0027name\u0027]"},{"line_number":461,"context_line":"        cache_vol.size \u003d cachevol_props[\u0027size\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fad55976_db03490c","line":458,"in_reply_to":"1aa78d24_ac025fb2","updated":"2016-07-15 20:30:27.000000000","message":"Done","commit_id":"a277eb4db81365231517ee651f01edcd39dded9a"}]}