)]}'
{"cinder/tests/unit/volume/drivers/test_lvm_driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9a2e9882880eaac7be1726f90b60ef4c9ffd5d94","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                             \u0027id\u0027: uuid,"},{"line_number":93,"context_line":"                             \u0027volume_size\u0027: 123}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            self.volume.driver._delete_volume(fake_snapshot, is_snapshot\u003dTrue)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @mock.patch.object(os.path, \u0027exists\u0027, return_value\u003dTrue)"},{"line_number":98,"context_line":"    @mock.patch.object(volutils, \u0027clear_volume\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_634d8799","line":95,"updated":"2016-08-01 20:26:11.000000000","message":"This test is fine, but I think for clarity/completeness it should assert that mock_clear was not called.  (Since it never is for thin.)","commit_id":"57cb2ce58e189caac5a5ac34e9561fd7031ee187"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9a2e9882880eaac7be1726f90b60ef4c9ffd5d94","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                             \u0027volume_size\u0027: 123}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"            self.volume.driver._delete_volume(fake_snapshot, is_snapshot\u003dTrue)"},{"line_number":115,"context_line":"            vg.activate_lv.assert_called_with(name, True)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @mock.patch.object(volutils, \u0027get_all_volume_groups\u0027,"},{"line_number":118,"context_line":"                       return_value\u003d[{\u0027name\u0027: \u0027cinder-volumes\u0027}])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_0353eb39","line":115,"updated":"2016-08-01 20:26:11.000000000","message":"This test is fine, but I think for clarity/completeness it should assert that mock_clear was not called.  (Since it never is for thin.)","commit_id":"57cb2ce58e189caac5a5ac34e9561fd7031ee187"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4d36ae88f733ff9aba587170684686ddb906ec1c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        if self.configuration.volume_clear !\u003d \u0027none\u0027 and \\"},{"line_number":131,"context_line":"                self.configuration.lvm_type !\u003d \u0027thin\u0027:"},{"line_number":132,"context_line":"            if not self.vg._lv_is_active(name):"},{"line_number":133,"context_line":"                self.vg.activate_lv(name, is_snapshot)"},{"line_number":134,"context_line":"            self._clear_volume(volume, is_snapshot)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.vg.delete(name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_a9bdcd69","line":133,"updated":"2016-10-13 20:00:22.000000000","message":"This should be called as vg.activate_lv(name, is_snapshot\u003dis_snapshot) for clarity, since there are other possible kwarg parameters.","commit_id":"fbde81ae9677865d4292fad8a325c98251f7aff4"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"4d672f6baf936b72e603c4c55c54d157f0813a52","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        if self.configuration.volume_clear !\u003d \u0027none\u0027 and \\"},{"line_number":131,"context_line":"                self.configuration.lvm_type !\u003d \u0027thin\u0027:"},{"line_number":132,"context_line":"            if not self.vg._lv_is_active(name):"},{"line_number":133,"context_line":"                self.vg.activate_lv(name, is_snapshot)"},{"line_number":134,"context_line":"            self._clear_volume(volume, is_snapshot)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        self.vg.delete(name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_7a1b7573","line":133,"in_reply_to":"fa6399be_a9bdcd69","updated":"2016-10-13 21:09:11.000000000","message":"Done","commit_id":"fbde81ae9677865d4292fad8a325c98251f7aff4"}]}