)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5b6555ef8c26738973936ae79d179b751267f94e","unresolved":false,"context_lines":[{"line_number":829,"context_line":"    def update_readonly_flag(self, lv_name, flag):"},{"line_number":830,"context_line":"        \"\"\"set the volume ro/rw.\"\"\""},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        lv_path \u003d self.vg_name + \u0027/\u0027 + self._mangle_lv_name(lv_name)"},{"line_number":833,"context_line":"        if flag:"},{"line_number":834,"context_line":"            cmd \u003d [\u0027lvchange\u0027, \u0027-p\u0027, \u0027r\u0027]"},{"line_number":835,"context_line":"        else:"},{"line_number":836,"context_line":"            cmd \u003d [\u0027lvchange\u0027, \u0027-p\u0027, \u0027rw\u0027]"},{"line_number":837,"context_line":"        cmd.append(lv_path)"},{"line_number":838,"context_line":"        try:"},{"line_number":839,"context_line":"            self._execute(*cmd,"},{"line_number":840,"context_line":"                          root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_9e379faf","line":837,"range":{"start_line":832,"start_character":0,"end_line":837,"end_character":27},"updated":"2016-09-06 09:32:13.000000000","message":"nit:\n\n lv_path \u003d self.vg_name + \u0027/\u0027 + self._mangle_lv_name(lv_name)\n cmd \u003d (\u0027lvchange\u0027, \u0027-p\u0027, \u0027r\u0027 if flag else \u0027rw\u0027, lv_path)","commit_id":"c6b3f4ab7ec1012c27d315f03054743bf1f8aaed"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5b6555ef8c26738973936ae79d179b751267f94e","unresolved":false,"context_lines":[{"line_number":841,"context_line":"                          run_as_root\u003dTrue)"},{"line_number":842,"context_line":"        except putils.ProcessExecutionError as err:"},{"line_number":843,"context_line":"            LOG.exception(_LE(\u0027Error lvchange logical volume\u0027))"},{"line_number":844,"context_line":"            LOG.error(_LE(\u0027Cmd     :%s\u0027), err.cmd)"},{"line_number":845,"context_line":"            LOG.error(_LE(\u0027StdOut  :%s\u0027), err.stdout)"},{"line_number":846,"context_line":"            LOG.error(_LE(\u0027StdErr  :%s\u0027), err.stderr)"},{"line_number":847,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_fe718ba9","line":846,"range":{"start_line":844,"start_character":0,"end_line":846,"end_character":53},"updated":"2016-09-06 09:32:13.000000000","message":"-1: This is already done with LOG.exception","commit_id":"c6b3f4ab7ec1012c27d315f03054743bf1f8aaed"}],"cinder/tests/unit/brick/test_brick_lvm.py":[{"author":{"_account_id":22257,"name":"Manish","email":"deolalkar.manish@hpe.com","username":"manishd"},"change_message_id":"bf2384b08df2b0fd8c0309a14fc5313ec01675f8","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                              self.vg.deactivate_lv, \u0027test\u0027)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def test_update_readonly_flag(self):"},{"line_number":394,"context_line":"        self.mox.StubOutWithMock(self.vg, \u0027_execute\u0027)"},{"line_number":395,"context_line":"        cmd \u003d [\u0027lvchange\u0027, \u0027-p\u0027, \u0027r\u0027, \u0027fake-vg/my-lv\u0027]"},{"line_number":396,"context_line":"        self.vg._execute(*cmd, root_helper\u003d\u0027sudo\u0027, run_as_root\u003dTrue)"},{"line_number":397,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_492d80a6","line":394,"range":{"start_line":394,"start_character":8,"end_line":394,"end_character":12},"updated":"2016-08-26 16:04:29.000000000","message":"I think we should write this test using mock, instead of mox as mox is not compatible with python 3 , and is being removed in V2 tests. Also the convention followed across all the tests written above is using mock.","commit_id":"2a4d25577ea4cfe56f7a1222d0fbe58d89ab8a83"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5b6555ef8c26738973936ae79d179b751267f94e","unresolved":false,"context_lines":[{"line_number":841,"context_line":"                                                       **kwargs)"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    def update_readonly_flag(self, volume, flag):"},{"line_number":844,"context_line":"        self.vg.update_readonly_flag(volume[\u0027name\u0027], flag)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_838f4ccb","line":844,"range":{"start_line":844,"start_character":37,"end_line":844,"end_character":51},"updated":"2016-09-06 09:32:13.000000000","message":"-1: volume.name","commit_id":"c6b3f4ab7ec1012c27d315f03054743bf1f8aaed"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"70a795509de820c9d7afbd06e3c176181f2f7df7","unresolved":false,"context_lines":[{"line_number":841,"context_line":"                                                       **kwargs)"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    def update_readonly_flag(self, volume, flag):"},{"line_number":844,"context_line":"        self.vg.update_readonly_flag(volume[\u0027name\u0027], flag)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_0c755cf8","line":844,"range":{"start_line":844,"start_character":37,"end_line":844,"end_character":51},"in_reply_to":"9a89bdaa_838f4ccb","updated":"2016-09-14 11:08:18.000000000","message":"Agree with Gorka. Use volume.name","commit_id":"c6b3f4ab7ec1012c27d315f03054743bf1f8aaed"}]}