)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"0499fbf803c772701944af64df3da1a0cee36a97","unresolved":false,"context_lines":[{"line_number":12,"context_line":"involve another backend."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, added another value of volume not found error."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I70dc8c3013c31c50fbcce7f3ff0b3ea677cf4f34"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_1cc5b78d","line":15,"updated":"2016-07-18 19:30:26.000000000","message":"What is the Bug it solves?","commit_id":"849915433f3e94a3d50fdc93ec3c6a9c38a9cad9"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"4eeb76443aa751bb5099982c4d1d78f16e3cb1c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matan Sabag \u003cmatan.sabag@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-20 08:01:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ScaleIO ignore rename of external volumes."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ScaleIO driver will ignore rename of volumes that"},{"line_number":10,"context_line":"are from other backend."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_dff79f8a","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":42},"updated":"2016-07-22 18:25:07.000000000","message":"Summary line doesn\u0027t require a \u0027.\u0027\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":18997,"name":"Matan Sabag","email":"matan.sabag@emc.com","username":"sabagm"},"change_message_id":"9875c40eb14800693e763600ed48dcc78d0a5659","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matan Sabag \u003cmatan.sabag@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-20 08:01:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ScaleIO ignore rename of external volumes."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ScaleIO driver will ignore rename of volumes that"},{"line_number":10,"context_line":"are from other backend."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_5f2f1cf6","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":42},"in_reply_to":"dada55a8_dff79f8a","updated":"2016-07-23 12:14:24.000000000","message":"Done","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"62d4ee38f7b7b389876b159d86f0aec355a23bf9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ScaleIO ignore rename of external volumes."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ScaleIO driver will ignore rename of volumes that"},{"line_number":10,"context_line":"are from other backend."},{"line_number":11,"context_line":"This is fixing a bug that migration is failed if you"},{"line_number":12,"context_line":"involve another backend."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_6bc3678b","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":23},"updated":"2016-07-22 13:16:01.000000000","message":"There is no mentioning about the retype operation from VNX to ScaleIO which this patch is fixing. Please add some more details.","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":18997,"name":"Matan Sabag","email":"matan.sabag@emc.com","username":"sabagm"},"change_message_id":"9875c40eb14800693e763600ed48dcc78d0a5659","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ScaleIO ignore rename of external volumes."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ScaleIO driver will ignore rename of volumes that"},{"line_number":10,"context_line":"are from other backend."},{"line_number":11,"context_line":"This is fixing a bug that migration is failed if you"},{"line_number":12,"context_line":"involve another backend."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_7f2ae0e8","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":23},"in_reply_to":"dada55a8_6bc3678b","updated":"2016-07-23 12:14:24.000000000","message":"It is not specific to VNX, it is relevant for every retype operation that involves other backends, and the details are in the bug. I really don\u0027t see any other relevant details that should be added in this commit message.","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9dc88aa0606a4ab0cebadf784a7273cfc415cc06","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This is fixing a bug that migration is failed if you"},{"line_number":12,"context_line":"involve another backend."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, added another value of volume not found error."},{"line_number":15,"context_line":"Closes-Bug: #1604703"},{"line_number":16,"context_line":"Change-Id: I70dc8c3013c31c50fbcce7f3ff0b3ea677cf4f34"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_c19fab4e","line":14,"updated":"2016-07-24 00:44:31.000000000","message":"Please add a blank line after the above line.\n\nAlso I don\u0027t understand why you have to add another volume not found error.  Can you please explain in this commit message?","commit_id":"821079befb38bbc42d6c79f7b8021b2917208b62"}],"cinder/tests/unit/volume/drivers/emc/scaleio/test_misc.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"62d4ee38f7b7b389876b159d86f0aec355a23bf9","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        )"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def test_rename_volume_non_sio(self):"},{"line_number":203,"context_line":"        self.set_https_response_mode(self.RESPONSE_MODE.BadStatus)"},{"line_number":204,"context_line":"        rc \u003d self.driver._rename_volume("},{"line_number":205,"context_line":"            self.volume, self.new_volume[\u0027id\u0027])"},{"line_number":206,"context_line":"        self.assertIsNone(rc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_ab48bfcd","line":203,"updated":"2016-07-22 13:16:01.000000000","message":"We also need to cover OLD_VOLUME_NOT_FOUND_ERROR error code.","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":18997,"name":"Matan Sabag","email":"matan.sabag@emc.com","username":"sabagm"},"change_message_id":"9875c40eb14800693e763600ed48dcc78d0a5659","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        )"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def test_rename_volume_non_sio(self):"},{"line_number":203,"context_line":"        self.set_https_response_mode(self.RESPONSE_MODE.BadStatus)"},{"line_number":204,"context_line":"        rc \u003d self.driver._rename_volume("},{"line_number":205,"context_line":"            self.volume, self.new_volume[\u0027id\u0027])"},{"line_number":206,"context_line":"        self.assertIsNone(rc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_9f1074aa","line":203,"in_reply_to":"dada55a8_ab48bfcd","updated":"2016-07-23 12:14:24.000000000","message":"Look at what I commented regarding that old_volume_not_found_error . \nIt is not really has to be covered, especially that we are not supporting retype and migration in our old versions.","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"}],"cinder/volume/drivers/emc/scaleio.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"62d4ee38f7b7b389876b159d86f0aec355a23bf9","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"BLOCK_SIZE \u003d 8"},{"line_number":89,"context_line":"OK_STATUS_CODE \u003d 200"},{"line_number":90,"context_line":"OLD_VOLUME_NOT_FOUND_ERROR \u003d 78"},{"line_number":91,"context_line":"VOLUME_NOT_FOUND_ERROR \u003d 79"},{"line_number":92,"context_line":"VOLUME_NOT_MAPPED_ERROR \u003d 84"},{"line_number":93,"context_line":"VOLUME_ALREADY_MAPPED_ERROR \u003d 81"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_8bd7bbec","line":90,"updated":"2016-07-22 13:16:01.000000000","message":"Why we need this new code?","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":18997,"name":"Matan Sabag","email":"matan.sabag@emc.com","username":"sabagm"},"change_message_id":"9875c40eb14800693e763600ed48dcc78d0a5659","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"BLOCK_SIZE \u003d 8"},{"line_number":89,"context_line":"OK_STATUS_CODE \u003d 200"},{"line_number":90,"context_line":"OLD_VOLUME_NOT_FOUND_ERROR \u003d 78"},{"line_number":91,"context_line":"VOLUME_NOT_FOUND_ERROR \u003d 79"},{"line_number":92,"context_line":"VOLUME_NOT_MAPPED_ERROR \u003d 84"},{"line_number":93,"context_line":"VOLUME_ALREADY_MAPPED_ERROR \u003d 81"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_5f16fca7","line":90,"in_reply_to":"dada55a8_8bd7bbec","updated":"2016-07-23 12:14:24.000000000","message":"For people that are working with older ScaleIO systems. we can say it is deprecated but it\u0027s mainly for bug prevention.","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"62d4ee38f7b7b389876b159d86f0aec355a23bf9","unresolved":false,"context_lines":[{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"        if r.status_code !\u003d OK_STATUS_CODE:"},{"line_number":1081,"context_line":"            response \u003d r.json()"},{"line_number":1082,"context_line":"            if ((response[\u0027errorCode\u0027] \u003d\u003d VOLUME_NOT_FOUND_ERROR or"},{"line_number":1083,"context_line":"                 response[\u0027errorCode\u0027] \u003d\u003d OLD_VOLUME_NOT_FOUND_ERROR)):"},{"line_number":1084,"context_line":"                LOG.info(_LI(\"Ignoring renaming action because the volume\""},{"line_number":1085,"context_line":"                             \"%(vol)s is not a ScaleIO volume.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_ebb8f7ea","line":1082,"range":{"start_line":1082,"start_character":15,"end_line":1082,"end_character":17},"updated":"2016-07-22 13:16:01.000000000","message":"nit: (","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":18997,"name":"Matan Sabag","email":"matan.sabag@emc.com","username":"sabagm"},"change_message_id":"9875c40eb14800693e763600ed48dcc78d0a5659","unresolved":false,"context_lines":[{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"        if r.status_code !\u003d OK_STATUS_CODE:"},{"line_number":1081,"context_line":"            response \u003d r.json()"},{"line_number":1082,"context_line":"            if ((response[\u0027errorCode\u0027] \u003d\u003d VOLUME_NOT_FOUND_ERROR or"},{"line_number":1083,"context_line":"                 response[\u0027errorCode\u0027] \u003d\u003d OLD_VOLUME_NOT_FOUND_ERROR)):"},{"line_number":1084,"context_line":"                LOG.info(_LI(\"Ignoring renaming action because the volume\""},{"line_number":1085,"context_line":"                             \"%(vol)s is not a ScaleIO volume.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_9f399444","line":1082,"range":{"start_line":1082,"start_character":15,"end_line":1082,"end_character":17},"in_reply_to":"dada55a8_ebb8f7ea","updated":"2016-07-23 12:14:24.000000000","message":"If i\u0027m doing that I get this PEP8 error that I can\u0027t get rid off, i saw in some places that people are doing this, please approve it like this.","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"62d4ee38f7b7b389876b159d86f0aec355a23bf9","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"        if r.status_code !\u003d OK_STATUS_CODE:"},{"line_number":1081,"context_line":"            response \u003d r.json()"},{"line_number":1082,"context_line":"            if ((response[\u0027errorCode\u0027] \u003d\u003d VOLUME_NOT_FOUND_ERROR or"},{"line_number":1083,"context_line":"                 response[\u0027errorCode\u0027] \u003d\u003d OLD_VOLUME_NOT_FOUND_ERROR)):"},{"line_number":1084,"context_line":"                LOG.info(_LI(\"Ignoring renaming action because the volume\""},{"line_number":1085,"context_line":"                             \"%(vol)s is not a ScaleIO volume.\"),"},{"line_number":1086,"context_line":"                         {\u0027vol\u0027: vol_id})"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_0bb8ebe4","line":1083,"range":{"start_line":1083,"start_character":68,"end_line":1083,"end_character":70},"updated":"2016-07-22 13:16:01.000000000","message":")","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"62d4ee38f7b7b389876b159d86f0aec355a23bf9","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            response \u003d r.json()"},{"line_number":1082,"context_line":"            if ((response[\u0027errorCode\u0027] \u003d\u003d VOLUME_NOT_FOUND_ERROR or"},{"line_number":1083,"context_line":"                 response[\u0027errorCode\u0027] \u003d\u003d OLD_VOLUME_NOT_FOUND_ERROR)):"},{"line_number":1084,"context_line":"                LOG.info(_LI(\"Ignoring renaming action because the volume\""},{"line_number":1085,"context_line":"                             \"%(vol)s is not a ScaleIO volume.\"),"},{"line_number":1086,"context_line":"                         {\u0027vol\u0027: vol_id})"},{"line_number":1087,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_abf0bfca","line":1084,"range":{"start_line":1084,"start_character":67,"end_line":1084,"end_character":73},"updated":"2016-07-22 13:16:01.000000000","message":"nit: need a space after volume","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":18997,"name":"Matan Sabag","email":"matan.sabag@emc.com","username":"sabagm"},"change_message_id":"9875c40eb14800693e763600ed48dcc78d0a5659","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            response \u003d r.json()"},{"line_number":1082,"context_line":"            if ((response[\u0027errorCode\u0027] \u003d\u003d VOLUME_NOT_FOUND_ERROR or"},{"line_number":1083,"context_line":"                 response[\u0027errorCode\u0027] \u003d\u003d OLD_VOLUME_NOT_FOUND_ERROR)):"},{"line_number":1084,"context_line":"                LOG.info(_LI(\"Ignoring renaming action because the volume\""},{"line_number":1085,"context_line":"                             \"%(vol)s is not a ScaleIO volume.\"),"},{"line_number":1086,"context_line":"                         {\u0027vol\u0027: vol_id})"},{"line_number":1087,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_df3b0c37","line":1084,"range":{"start_line":1084,"start_character":67,"end_line":1084,"end_character":73},"in_reply_to":"dada55a8_abf0bfca","updated":"2016-07-23 12:14:24.000000000","message":"Done","commit_id":"84f3a0d0415d4d343e20d365be72267972a2c3c6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9dc88aa0606a4ab0cebadf784a7273cfc415cc06","unresolved":false,"context_lines":[{"line_number":88,"context_line":"BLOCK_SIZE \u003d 8"},{"line_number":89,"context_line":"OK_STATUS_CODE \u003d 200"},{"line_number":90,"context_line":"OLD_VOLUME_NOT_FOUND_ERROR \u003d 78"},{"line_number":91,"context_line":"VOLUME_NOT_FOUND_ERROR \u003d 79"},{"line_number":92,"context_line":"VOLUME_NOT_MAPPED_ERROR \u003d 84"},{"line_number":93,"context_line":"VOLUME_ALREADY_MAPPED_ERROR \u003d 81"},{"line_number":94,"context_line":"MIN_BWS_SCALING_SIZE \u003d 128"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_41ba9bc1","line":91,"updated":"2016-07-24 00:44:31.000000000","message":"Why do you need two volume not found error codes  OLD_VOLUME_NOT_FOUND_ERROR and VOLUME_NOT_FOUND_ERROR?  Please add a comment before these two error codes.  Is the intention to keep both forever or is the plan to remove the old code in the future?","commit_id":"821079befb38bbc42d6c79f7b8021b2917208b62"},{"author":{"_account_id":18997,"name":"Matan Sabag","email":"matan.sabag@emc.com","username":"sabagm"},"change_message_id":"eae1c74f64cbae2167f076137c43666c8583bd9c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"BLOCK_SIZE \u003d 8"},{"line_number":89,"context_line":"OK_STATUS_CODE \u003d 200"},{"line_number":90,"context_line":"OLD_VOLUME_NOT_FOUND_ERROR \u003d 78"},{"line_number":91,"context_line":"VOLUME_NOT_FOUND_ERROR \u003d 79"},{"line_number":92,"context_line":"VOLUME_NOT_MAPPED_ERROR \u003d 84"},{"line_number":93,"context_line":"VOLUME_ALREADY_MAPPED_ERROR \u003d 81"},{"line_number":94,"context_line":"MIN_BWS_SCALING_SIZE \u003d 128"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_5459ba5a","line":91,"in_reply_to":"dada55a8_41ba9bc1","updated":"2016-07-24 07:47:03.000000000","message":"OLD_VOLUME_NOT_FOUND_ERROR is an error code that exists in older versions of ScaleIO, it can occur in some scenarios and in the newer versions it doesn\u0027t exist.","commit_id":"821079befb38bbc42d6c79f7b8021b2917208b62"}]}