)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"460aca7b13b6f80b184e17dbc8eb18318ec46b3d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix HNAS stats reporting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HNAS driver pools are not reporting thin_provisioing to scheduler,"},{"line_number":10,"context_line":"so when creating a volume, is not possible to limit the usage of"},{"line_number":11,"context_line":"the backend space."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa7ab95a_5dd073f6","line":9,"updated":"2016-08-29 19:51:18.000000000","message":"nit: thin_provisioning","commit_id":"17275e29d8824301f731d787e07fe0538e4bc05f"}],"cinder/tests/unit/test_hitachi_hnas_backend.py":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"92c4e887de504b966282e988b1f4a92c63fff2ed","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        self.assertEqual(expected_out, out[\u0027172.24.44.20\u0027])"},{"line_number":442,"context_line":"        self.assertEqual(expected_out2, out[\u0027172.24.44.21\u0027])"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def test_get_fs_info(self):"},{"line_number":445,"context_line":"        self.mock_object(self.hnas_backend, \u0027_run_cmd\u0027,"},{"line_number":446,"context_line":"                         mock.Mock(side_effect\u003d[(df_f, \u0027\u0027),"},{"line_number":447,"context_line":"                                                (evsfs_list, \u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_df80c8f9","line":444,"range":{"start_line":444,"start_character":8,"end_line":444,"end_character":24},"updated":"2016-07-20 14:27:50.000000000","message":"What you think about adding a test for a fs without logical units?","commit_id":"db4e3a862bfb48ca0f43dc08dd3ed0ae0932f295"}],"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_hnas_backend.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6bf297139ef6666414170613b2af2d2f55651749","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    def test_get_fs_info(self):"},{"line_number":443,"context_line":"        self.mock_object(self.hnas_backend, \u0027_run_cmd\u0027,"},{"line_number":444,"context_line":"                         mock.Mock(side_effect\u003d[(df_f, \u0027\u0027),"},{"line_number":445,"context_line":"                                                (evsfs_list, \u0027\u0027),"},{"line_number":446,"context_line":"                                                (hnas_fs_list, \u0027\u0027)]))"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_1a64f1b6","line":444,"updated":"2016-08-30 15:13:22.000000000","message":"If Gorka\u0027s patch gets merged before yours, you should remove mock.Mock here.","commit_id":"95f32e95cb8d993b32668a8e9203c689971441c0"}],"cinder/volume/drivers/hitachi/hnas_backend.py":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"92c4e887de504b966282e988b1f4a92c63fff2ed","unresolved":false,"context_lines":[{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def _parse_lu_info(self, output):"},{"line_number":625,"context_line":"        lu_info \u003d {}"},{"line_number":626,"context_line":"        if \u0027does not exist.\u0027 not in output:"},{"line_number":627,"context_line":"            aux \u003d output.split(\u0027\\n\u0027)"},{"line_number":628,"context_line":"            lu_info[\u0027name\u0027] \u003d aux[0].split(\u0027:\u0027)[1].strip()"},{"line_number":629,"context_line":"            lu_info[\u0027comment\u0027] \u003d aux[1].split(\u0027:\u0027)[1].strip()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_6480318c","line":626,"range":{"start_line":626,"start_character":8,"end_line":626,"end_character":43},"updated":"2016-07-20 14:27:50.000000000","message":"It shouldn\u0027t be \u0027No logical units\u0027?","commit_id":"db4e3a862bfb48ca0f43dc08dd3ed0ae0932f295"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"5a9e0fbdc68fc42405000fc208e52119d52fcca0","unresolved":false,"context_lines":[{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        return lu_info"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def _parse_lu_info(self, output):"},{"line_number":620,"context_line":"        lu_info \u003d {}"},{"line_number":621,"context_line":"        if \u0027does not exist.\u0027 not in output:"},{"line_number":622,"context_line":"            aux \u003d output.split(\u0027\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_bf33ddf5","line":619,"range":{"start_line":619,"start_character":4,"end_line":619,"end_character":22},"updated":"2016-08-12 17:18:49.000000000","message":"It would be nice to add docstrings here since all the other functions have it.","commit_id":"b7e69d1862830b9af5e0f41e0df197a78dde5faf"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"5a9e0fbdc68fc42405000fc208e52119d52fcca0","unresolved":false,"context_lines":[{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        return lu_info"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def _parse_lu_info(self, output):"},{"line_number":620,"context_line":"        lu_info \u003d {}"},{"line_number":621,"context_line":"        if \u0027does not exist.\u0027 not in output:"},{"line_number":622,"context_line":"            aux \u003d output.split(\u0027\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_3c437b6e","line":619,"range":{"start_line":619,"start_character":29,"end_line":619,"end_character":35},"updated":"2016-08-12 17:18:49.000000000","message":"nit: This is actually the input of the function","commit_id":"b7e69d1862830b9af5e0f41e0df197a78dde5faf"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"5fb5a088755781daf4520d71dc4ce104957958f3","unresolved":false,"context_lines":[{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        return lu_info"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def _parse_lu_info(self, output):"},{"line_number":620,"context_line":"        lu_info \u003d {}"},{"line_number":621,"context_line":"        if \u0027does not exist.\u0027 not in output:"},{"line_number":622,"context_line":"            aux \u003d output.split(\u0027\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_a16057a6","line":619,"range":{"start_line":619,"start_character":29,"end_line":619,"end_character":35},"in_reply_to":"9ad45d7e_3c437b6e","updated":"2016-08-17 11:54:47.000000000","message":"output: is the output of storage command.","commit_id":"b7e69d1862830b9af5e0f41e0df197a78dde5faf"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"5fb5a088755781daf4520d71dc4ce104957958f3","unresolved":false,"context_lines":[{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        return lu_info"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def _parse_lu_info(self, output):"},{"line_number":620,"context_line":"        lu_info \u003d {}"},{"line_number":621,"context_line":"        if \u0027does not exist.\u0027 not in output:"},{"line_number":622,"context_line":"            aux \u003d output.split(\u0027\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_616bff85","line":619,"range":{"start_line":619,"start_character":4,"end_line":619,"end_character":22},"in_reply_to":"9ad45d7e_bf33ddf5","updated":"2016-08-17 11:54:47.000000000","message":"Docstrings are only in the interface methods. This is private, so no need to document.","commit_id":"b7e69d1862830b9af5e0f41e0df197a78dde5faf"}],"cinder/volume/drivers/hitachi/hnas_iscsi.py":[{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"082c24895e0f55b3b643a104b9e8ad2baacf6421","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return service"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _get_stats(self):"},{"line_number":242,"context_line":"        \"\"\"Get FS stats from HNAS."},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        :returns: dictionary with the stats from HNAS"},{"line_number":245,"context_line":"        \"\"\""},{"line_number":246,"context_line":"        hnas_stat \u003d {}"},{"line_number":247,"context_line":"        be_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":248,"context_line":"        hnas_stat[\"volume_backend_name\"] \u003d be_name or \u0027HNASISCSIDriver\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_cb584935","line":245,"range":{"start_line":242,"start_character":0,"end_line":245,"end_character":11},"updated":"2016-08-09 18:33:35.000000000","message":"Please update the method documentation to include the new status (as described on NFS driver)","commit_id":"eab177c9e818b9a79ae53a55d09731ec21d9ef47"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"460aca7b13b6f80b184e17dbc8eb18318ec46b3d","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        _stats[\u0027pools\u0027] \u003d {"},{"line_number":278,"context_line":"            \u0027total_capacity_gb\u0027: total size of the pool,"},{"line_number":279,"context_line":"            \u0027free_capacity_gb\u0027: the available size,"},{"line_number":280,"context_line":"            \u0027allocated_capacity_gb\u0027: current allocated size,"},{"line_number":281,"context_line":"            \u0027QoS_support\u0027: bool to indicate if QoS is supported,"},{"line_number":282,"context_line":"            \u0027reserved_percentage\u0027: percentage of size reserved,"},{"line_number":283,"context_line":"            \u0027max_over_subscription_ratio\u0027: oversubscription rate,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_55c20735","line":280,"updated":"2016-08-29 19:51:18.000000000","message":"Driver should not be reporting allocated_capacity_gb.  Scheduler is keeping track of this one:\n\nhttps://github.com/openstack/cinder/blob/master/cinder/scheduler/host_manager.py#L280","commit_id":"17275e29d8824301f731d787e07fe0538e4bc05f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e72e379327a06caaa2926ef26275b377ce44e1e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        _stats[\u0027pools\u0027] \u003d {"},{"line_number":278,"context_line":"            \u0027total_capacity_gb\u0027: total size of the pool,"},{"line_number":279,"context_line":"            \u0027free_capacity_gb\u0027: the available size,"},{"line_number":280,"context_line":"            \u0027allocated_capacity_gb\u0027: current allocated size,"},{"line_number":281,"context_line":"            \u0027QoS_support\u0027: bool to indicate if QoS is supported,"},{"line_number":282,"context_line":"            \u0027reserved_percentage\u0027: percentage of size reserved,"},{"line_number":283,"context_line":"            \u0027max_over_subscription_ratio\u0027: oversubscription rate,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_6edc6646","line":280,"in_reply_to":"fa7ab95a_55c20735","updated":"2016-08-30 13:55:13.000000000","message":"Done","commit_id":"17275e29d8824301f731d787e07fe0538e4bc05f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"460aca7b13b6f80b184e17dbc8eb18318ec46b3d","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            pool[\u0027total_capacity_gb\u0027] \u003d (float(fs_info[\u0027total_size\u0027]))"},{"line_number":299,"context_line":"            pool[\u0027free_capacity_gb\u0027] \u003d ("},{"line_number":300,"context_line":"                float(fs_info[\u0027total_size\u0027]) - float(fs_info[\u0027used_size\u0027]))"},{"line_number":301,"context_line":"            pool[\u0027allocated_capacity_gb\u0027] \u003d (float(fs_info[\u0027total_size\u0027]))"},{"line_number":302,"context_line":"            pool[\u0027QoS_support\u0027] \u003d \u0027False\u0027"},{"line_number":303,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":304,"context_line":"            pool[\u0027max_over_subscription_ratio\u0027] \u003d self.max_osr"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_554767bb","line":301,"updated":"2016-08-29 19:51:18.000000000","message":"See above.  This line should be removed.","commit_id":"17275e29d8824301f731d787e07fe0538e4bc05f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e72e379327a06caaa2926ef26275b377ce44e1e","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            pool[\u0027total_capacity_gb\u0027] \u003d (float(fs_info[\u0027total_size\u0027]))"},{"line_number":299,"context_line":"            pool[\u0027free_capacity_gb\u0027] \u003d ("},{"line_number":300,"context_line":"                float(fs_info[\u0027total_size\u0027]) - float(fs_info[\u0027used_size\u0027]))"},{"line_number":301,"context_line":"            pool[\u0027allocated_capacity_gb\u0027] \u003d (float(fs_info[\u0027total_size\u0027]))"},{"line_number":302,"context_line":"            pool[\u0027QoS_support\u0027] \u003d \u0027False\u0027"},{"line_number":303,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":304,"context_line":"            pool[\u0027max_over_subscription_ratio\u0027] \u003d self.max_osr"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_8edfea38","line":301,"in_reply_to":"fa7ab95a_554767bb","updated":"2016-08-30 13:55:13.000000000","message":"Done","commit_id":"17275e29d8824301f731d787e07fe0538e4bc05f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"460aca7b13b6f80b184e17dbc8eb18318ec46b3d","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            pool[\u0027QoS_support\u0027] \u003d \u0027False\u0027"},{"line_number":303,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":304,"context_line":"            pool[\u0027max_over_subscription_ratio\u0027] \u003d self.max_osr"},{"line_number":305,"context_line":"            pool[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        hnas_stat[\u0027pools\u0027] \u003d self.pools"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_b566f34e","line":305,"updated":"2016-08-29 19:51:18.000000000","message":"Question: Does your driver only support thin provisioning, but not thick provisioning?","commit_id":"17275e29d8824301f731d787e07fe0538e4bc05f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e72e379327a06caaa2926ef26275b377ce44e1e","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            pool[\u0027QoS_support\u0027] \u003d \u0027False\u0027"},{"line_number":303,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":304,"context_line":"            pool[\u0027max_over_subscription_ratio\u0027] \u003d self.max_osr"},{"line_number":305,"context_line":"            pool[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        hnas_stat[\u0027pools\u0027] \u003d self.pools"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_135065d3","line":305,"in_reply_to":"fa7ab95a_b566f34e","updated":"2016-08-30 13:55:13.000000000","message":"Yes, it only support thin.","commit_id":"17275e29d8824301f731d787e07fe0538e4bc05f"}],"cinder/volume/drivers/hitachi/hnas_nfs.py":[{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"449d3b65199ea04a9fcd5e18113b025b15911abd","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            pool[\u0027QoS_support\u0027] \u003d \u0027False\u0027"},{"line_number":274,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":275,"context_line":"            pool[\u0027max_over_subscription_ratio\u0027] \u003d max_osr"},{"line_number":276,"context_line":"            pool[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":277,"context_line":"            pool[\u0027thick_provisioning_support\u0027] \u003d False"},{"line_number":278,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_5a9861c0","line":276,"range":{"start_line":276,"start_character":12,"end_line":276,"end_character":52},"updated":"2016-07-30 20:26:14.000000000","message":"Is thin_provision always supported (True) or is it configurable or requires some query to array to check if it is supported or not?","commit_id":"12fca91aa26e82e37d38c91691d4123cc9f31015"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"f52dbfef4214888ea506c4db0140196878b28772","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":275,"context_line":"            pool[\u0027max_over_subscription_ratio\u0027] \u003d max_osr"},{"line_number":276,"context_line":"            pool[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":277,"context_line":"            pool[\u0027thick_provisioning_support\u0027] \u003d False"},{"line_number":278,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        _stats[\u0027pools\u0027] \u003d self.pools"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_b3158d9c","line":277,"updated":"2016-07-29 01:13:09.000000000","message":"Should we must report \u0027thick_provisioning_support\u0027?","commit_id":"12fca91aa26e82e37d38c91691d4123cc9f31015"},{"author":{"_account_id":19144,"name":"José Mello","email":"jose.eduardo.jr@gmail.com","username":"jose-eduardo-jr"},"change_message_id":"082c24895e0f55b3b643a104b9e8ad2baacf6421","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        return {\u0027provider_location\u0027: share}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"},{"line_number":249,"context_line":"        \"\"\"Get volume stats."},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        :param refresh: if it is True, update the stats first."},{"line_number":252,"context_line":"        :returns: dictionary with the stats from HNAS"},{"line_number":253,"context_line":"        _stats[\u0027pools\u0027]\u003d{"},{"line_number":254,"context_line":"            \u0027total_capacity_gb\u0027: total size of the pool,"},{"line_number":255,"context_line":"            \u0027free_capacity_gb\u0027: the available size,"},{"line_number":256,"context_line":"            \u0027allocated_capacity_gb\u0027: current allocated size,"},{"line_number":257,"context_line":"            \u0027QoS_support\u0027: bool to indicate if QoS is supported,"},{"line_number":258,"context_line":"            \u0027reserved_percentage\u0027: percentage of size reserved"},{"line_number":259,"context_line":"            }"},{"line_number":260,"context_line":"        \"\"\""},{"line_number":261,"context_line":"        _stats \u003d super(HNASNFSDriver, self).get_volume_stats(refresh)"},{"line_number":262,"context_line":"        _stats[\"vendor_name\"] \u003d \u0027Hitachi\u0027"},{"line_number":263,"context_line":"        _stats[\"driver_version\"] \u003d HNAS_NFS_VERSION"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_cb2169a1","line":260,"range":{"start_line":249,"start_character":0,"end_line":260,"end_character":11},"updated":"2016-08-09 18:33:35.000000000","message":"Please update the method documentation to include the new status","commit_id":"eab177c9e818b9a79ae53a55d09731ec21d9ef47"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"5a9e0fbdc68fc42405000fc208e52119d52fcca0","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":278,"context_line":"            pool[\u0027max_over_subscription_ratio\u0027] \u003d max_osr"},{"line_number":279,"context_line":"            pool[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":280,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        _stats[\u0027pools\u0027] \u003d self.pools"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9ad45d7e_dfbdf1d8","line":280,"range":{"start_line":280,"start_character":12,"end_line":280,"end_character":66},"updated":"2016-08-12 17:18:49.000000000","message":"You\u0027re setting the \"reserved_percentage\" twice.","commit_id":"b7e69d1862830b9af5e0f41e0df197a78dde5faf"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"5fb5a088755781daf4520d71dc4ce104957958f3","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":278,"context_line":"            pool[\u0027max_over_subscription_ratio\u0027] \u003d max_osr"},{"line_number":279,"context_line":"            pool[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":280,"context_line":"            pool[\u0027reserved_percentage\u0027] \u003d self.reserved_percentage"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        _stats[\u0027pools\u0027] \u003d self.pools"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3ac371cc_61193f22","line":280,"range":{"start_line":280,"start_character":12,"end_line":280,"end_character":66},"in_reply_to":"9ad45d7e_dfbdf1d8","updated":"2016-08-17 11:54:47.000000000","message":"To make sure is really reserved :). Good catch.","commit_id":"b7e69d1862830b9af5e0f41e0df197a78dde5faf"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"460aca7b13b6f80b184e17dbc8eb18318ec46b3d","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        _stats[\u0027pools\u0027] \u003d {"},{"line_number":272,"context_line":"            \u0027total_capacity_gb\u0027: total size of the pool,"},{"line_number":273,"context_line":"            \u0027free_capacity_gb\u0027: the available size,"},{"line_number":274,"context_line":"            \u0027allocated_capacity_gb\u0027: current allocated size,"},{"line_number":275,"context_line":"            \u0027QoS_support\u0027: bool to indicate if QoS is supported,"},{"line_number":276,"context_line":"            \u0027reserved_percentage\u0027: percentage of size reserved,"},{"line_number":277,"context_line":"            \u0027max_over_subscription_ratio\u0027: oversubscription rate,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_b5f4335b","line":274,"updated":"2016-08-29 19:51:18.000000000","message":"See previous comment.  This should not be in the driver.","commit_id":"17275e29d8824301f731d787e07fe0538e4bc05f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e72e379327a06caaa2926ef26275b377ce44e1e","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        _stats[\u0027pools\u0027] \u003d {"},{"line_number":272,"context_line":"            \u0027total_capacity_gb\u0027: total size of the pool,"},{"line_number":273,"context_line":"            \u0027free_capacity_gb\u0027: the available size,"},{"line_number":274,"context_line":"            \u0027allocated_capacity_gb\u0027: current allocated size,"},{"line_number":275,"context_line":"            \u0027QoS_support\u0027: bool to indicate if QoS is supported,"},{"line_number":276,"context_line":"            \u0027reserved_percentage\u0027: percentage of size reserved,"},{"line_number":277,"context_line":"            \u0027max_over_subscription_ratio\u0027: oversubscription rate,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_0eecbaf1","line":274,"in_reply_to":"fa7ab95a_b5f4335b","updated":"2016-08-30 13:55:13.000000000","message":"Done","commit_id":"17275e29d8824301f731d787e07fe0538e4bc05f"}]}