)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"a51515fae67a6a9a6af9a24d635f7c186ec0620c","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(jdg): lvcreate will round up extents"},{"line_number":314,"context_line":"        # to avoid issues, let\u0027s chop the size off to an int"},{"line_number":315,"context_line":"        size_str \u003d re.sub(r\u0027.\\d\\d\u0027, \u0027\u0027, size_str)"},{"line_number":316,"context_line":"        pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, name)"},{"line_number":317,"context_line":"        cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-L\u0027, size_str, pool_path]"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FplQ%3D","line":315,"updated":"2013-06-25 23:05:13.000000000","message":"The RE is confusing to me. sorry.\nCould you provide example inputs and outputs,\npreferably as a test?","commit_id":"6bb997c6c3bb9ec156c7f535b5c6a0605724103b"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"15f97fb3a1ff8245a09d29ff27cd0c466237548a","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(jdg): lvcreate will round up extents"},{"line_number":314,"context_line":"        # to avoid issues, let\u0027s chop the size off to an int"},{"line_number":315,"context_line":"        size_str \u003d re.sub(r\u0027.\\d\\d\u0027, \u0027\u0027, size_str)"},{"line_number":316,"context_line":"        pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, name)"},{"line_number":317,"context_line":"        cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-L\u0027, size_str, pool_path]"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FpV8%3D","line":315,"in_reply_to":"AAAAPn%2F%2Fpc8%3D","updated":"2013-06-26 01:39:53.000000000","message":"Indeed!  Nice catch to both of you...  I\u0027ve omitted the delimiter for the \u0027.\u0027.\n\nI\u0027ll need to refresh myself on re.sub to understand why that worked with up to two leading digits but not after 3.\n\nanyway... I\u0027ll adjust this when I fix the tests that I broke :)","commit_id":"6bb997c6c3bb9ec156c7f535b5c6a0605724103b"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"6878c912571a60c0e735638dd23043ddf8af19c3","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(jdg): lvcreate will round up extents"},{"line_number":314,"context_line":"        # to avoid issues, let\u0027s chop the size off to an int"},{"line_number":315,"context_line":"        size_str \u003d re.sub(r\u0027.\\d\\d\u0027, \u0027\u0027, size_str)"},{"line_number":316,"context_line":"        pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, name)"},{"line_number":317,"context_line":"        cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-L\u0027, size_str, pool_path]"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fpc8%3D","line":315,"in_reply_to":"AAAAPn%2F%2FphA%3D","updated":"2013-06-26 01:04:42.000000000","message":"i don\u0027t know much about RE but I tried 115.11g and ...","commit_id":"6bb997c6c3bb9ec156c7f535b5c6a0605724103b"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c51ed79c4674735f22c8c99df15648015dd00a4f","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(jdg): lvcreate will round up extents"},{"line_number":314,"context_line":"        # to avoid issues, let\u0027s chop the size off to an int"},{"line_number":315,"context_line":"        size_str \u003d re.sub(r\u0027.\\d\\d\u0027, \u0027\u0027, size_str)"},{"line_number":316,"context_line":"        pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, name)"},{"line_number":317,"context_line":"        cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-L\u0027, size_str, pool_path]"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FphA%3D","line":315,"in_reply_to":"AAAAPn%2F%2FplQ%3D","updated":"2013-06-25 23:57:01.000000000","message":"\u003e\u003e\u003e import re\n\n\u003e\u003e\u003e var \u003d \u00275.11g\u0027\n\n\u003e\u003e\u003e re.sub(r\u0027.\\d\\d\u0027, \u0027\u0027, var)\n\n\u00275g\u0027\n\u003e\u003e\u003e","commit_id":"6bb997c6c3bb9ec156c7f535b5c6a0605724103b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f1c2c486c1989df63b10fd150856360b79b4088f","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, self.vg_thin_pool)"},{"line_number":336,"context_line":"            cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-V\u0027, size_str, \u0027-n\u0027, name, pool_path]"},{"line_number":337,"context_line":"        else:"},{"line_number":338,"context_line":"            cmd +\u003d [\u0027lvcreate\u0027, \u0027-n\u0027, name, self.vg_name, \u0027-L\u0027, size_str]"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        if mirror_count \u003e 0:"},{"line_number":341,"context_line":"            cmd +\u003d [\u0027-m\u0027, mirror_count, \u0027--nosync\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FpL4%3D","line":338,"updated":"2013-06-26 03:14:43.000000000","message":"Should be \u003d instead of +\u003d ?","commit_id":"0fba74dc3a845235879bc0651689ac400a2e249f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"f2d4dc040b38f27d1d7b9cd34c28586c62bdf081","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, self.vg_thin_pool)"},{"line_number":336,"context_line":"            cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-V\u0027, size_str, \u0027-n\u0027, name, pool_path]"},{"line_number":337,"context_line":"        else:"},{"line_number":338,"context_line":"            cmd +\u003d [\u0027lvcreate\u0027, \u0027-n\u0027, name, self.vg_name, \u0027-L\u0027, size_str]"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        if mirror_count \u003e 0:"},{"line_number":341,"context_line":"            cmd +\u003d [\u0027-m\u0027, mirror_count, \u0027--nosync\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FpLo%3D","line":338,"in_reply_to":"AAAAPn%2F%2FpL4%3D","updated":"2013-06-26 03:21:30.000000000","message":"Done","commit_id":"0fba74dc3a845235879bc0651689ac400a2e249f"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"ad50fc899102e6c9f9fb53b948eecf3ea63ec093","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(jdg): lvcreate will round up extents"},{"line_number":314,"context_line":"        # to avoid issues, let\u0027s chop the size off to an int"},{"line_number":315,"context_line":"        size_str \u003d re.sub(r\u0027\\.\\d\\d\u0027, \u0027\u0027, size_str)"},{"line_number":316,"context_line":"        pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, name)"},{"line_number":317,"context_line":"        cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-L\u0027, size_str, pool_path]"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FP74%3D","line":315,"updated":"2013-07-06 10:28:38.000000000","message":"The RE seems uneccessarily coupled to the size_str format.\nI.E. It doesn\u0027t handle 5.1 or 5.119, with the latter being particularly problematic. So as others reading the code in future don\u0027t have to worry about that issue, or if you did want to support more general float formats, then I\u0027d suggest:\n\n  size_str \u003d re.sub(r\u0027\\.\\d*\u0027, \u0027\u0027, size_str)","commit_id":"11c14c12388d64472b7372904c33cb6d246a0c2f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"722483e0840dc298a44f4664d48b9083e882d7eb","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # NOTE(jdg): lvcreate will round up extents"},{"line_number":314,"context_line":"        # to avoid issues, let\u0027s chop the size off to an int"},{"line_number":315,"context_line":"        size_str \u003d re.sub(r\u0027\\.\\d\\d\u0027, \u0027\u0027, size_str)"},{"line_number":316,"context_line":"        pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, name)"},{"line_number":317,"context_line":"        cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-L\u0027, size_str, pool_path]"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FPx4%3D","line":315,"in_reply_to":"AAAAPn%2F%2FP74%3D","updated":"2013-07-06 15:38:37.000000000","message":"Done","commit_id":"11c14c12388d64472b7372904c33cb6d246a0c2f"}]}