)]}'
{"cinder/backup/drivers/ceph.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2752f47d42fd407c995c0a118d6d4ca3be4b22ef","unresolved":false,"context_lines":[{"line_number":850,"context_line":"        volume \u003d self.db.volume_get(self.context, backup[\u0027volume_id\u0027])"},{"line_number":851,"context_line":"        volume_id \u003d volume[\u0027id\u0027]"},{"line_number":852,"context_line":"        volume_name \u003d volume[\u0027name\u0027]"},{"line_number":853,"context_line":"        if backup.container:"},{"line_number":854,"context_line":"            self._ceph_backup_pool \u003d backup.container"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"        LOG.debug(\"Starting backup of volume\u003d\u0027%s\u0027.\", volume_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_db0a6025","line":853,"updated":"2016-07-21 13:55:16.000000000","message":"Please, don\u0027t override self._ceph_backup_pool. You should re-use \u0027container\u0027 field from backup object if any","commit_id":"a1d8e9c462e8f463b59385fd9127df759bb3a956"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"222e7fdd1fc109fb222f3820da853502f22306df","unresolved":false,"context_lines":[{"line_number":878,"context_line":"                self._full_backup(backup_id, volume_id, volume_file,"},{"line_number":879,"context_line":"                                  volume_name, length)"},{"line_number":880,"context_line":"            except exception.BackupOperationError:"},{"line_number":881,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":882,"context_line":"                    self.delete(backup)"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"        backup.container \u003d self._ceph_backup_pool"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_0e46744e","line":881,"updated":"2016-07-21 13:56:06.000000000","message":"Please, add comment here why try-expect block is needed","commit_id":"a1d8e9c462e8f463b59385fd9127df759bb3a956"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"4ab529c73fc86dc4a81acd03d7f6a57b7036991d","unresolved":false,"context_lines":[{"line_number":693,"context_line":"        image."},{"line_number":694,"context_line":"        \"\"\""},{"line_number":695,"context_line":"        volume_id \u003d backup.volume_id"},{"line_number":696,"context_line":"        backup_name \u003d self._get_backup_base_name(volume_id, backup.id)"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        with rbd_driver.RADOSClient(self, backup.container) as client:"},{"line_number":699,"context_line":"            # First create base backup image"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_184d7a99","line":696,"updated":"2016-07-26 00:00:11.000000000","message":"is backup_name same as backup.name?  I guess not.","commit_id":"05d099be37c9c8c5451b0128dac70051bf9baccb"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"6241fed42f48cfd794d6b2509f8442b59431919e","unresolved":false,"context_lines":[{"line_number":693,"context_line":"        image."},{"line_number":694,"context_line":"        \"\"\""},{"line_number":695,"context_line":"        volume_id \u003d backup.volume_id"},{"line_number":696,"context_line":"        backup_name \u003d self._get_backup_base_name(volume_id, backup.id)"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        with rbd_driver.RADOSClient(self, backup.container) as client:"},{"line_number":699,"context_line":"            # First create base backup image"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_ff0047ad","line":696,"updated":"2016-07-26 03:07:03.000000000","message":"is backup_name same as backup.name?  I guess not.","commit_id":"05d099be37c9c8c5451b0128dac70051bf9baccb"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"4ab529c73fc86dc4a81acd03d7f6a57b7036991d","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                                                       self._ceph_backup_user,"},{"line_number":718,"context_line":"                                                       self._ceph_backup_conf)"},{"line_number":719,"context_line":"                rbd_fd \u003d rbd_driver.RBDImageIOWrapper(rbd_meta)"},{"line_number":720,"context_line":"                self._transfer_data(src_volume, src_name, rbd_fd, backup.name,"},{"line_number":721,"context_line":"                                    length)"},{"line_number":722,"context_line":"            finally:"},{"line_number":723,"context_line":"                dest_rbd.close()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_78447673","line":720,"updated":"2016-07-26 00:00:11.000000000","message":"backup.name should be backup_name?","commit_id":"05d099be37c9c8c5451b0128dac70051bf9baccb"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"6241fed42f48cfd794d6b2509f8442b59431919e","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                                                       self._ceph_backup_user,"},{"line_number":718,"context_line":"                                                       self._ceph_backup_conf)"},{"line_number":719,"context_line":"                rbd_fd \u003d rbd_driver.RBDImageIOWrapper(rbd_meta)"},{"line_number":720,"context_line":"                self._transfer_data(src_volume, src_name, rbd_fd, backup.name,"},{"line_number":721,"context_line":"                                    length)"},{"line_number":722,"context_line":"            finally:"},{"line_number":723,"context_line":"                dest_rbd.close()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_dffd83b2","line":720,"updated":"2016-07-26 03:07:03.000000000","message":"backup.name should be backup_name?","commit_id":"05d099be37c9c8c5451b0128dac70051bf9baccb"}]}