)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"1d31a5afee429074367f79297fcaceef2fef14e4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a retype fails because it requires a migration and we haven\u0027t"},{"line_number":10,"context_line":"changed the migration policy -so it has default \"never\" value- we no"},{"line_number":11,"context_line":"longer get a specific log message, like we used to, instead we get a"},{"line_number":12,"context_line":"generic error as the scheduler manager is hiding the error details."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes this by logging the real exception raised by"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_305537c6","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":53},"updated":"2016-07-23 16:10:00.000000000","message":"Very minor change but ending the sentence after \"message.\" and starting the next sentence with \"Instead\" will break up this long sentence. Thanks","commit_id":"a10a47492ed4f259e8ec59f15f0fb8ff9e9339eb"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e68e4d644f34f97df1b18d07142444c37e318ea5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a retype fails because it requires a migration and we haven\u0027t"},{"line_number":10,"context_line":"changed the migration policy -so it has default \"never\" value- we no"},{"line_number":11,"context_line":"longer get a specific log message, like we used to, instead we get a"},{"line_number":12,"context_line":"generic error as the scheduler manager is hiding the error details."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes this by logging the real exception raised by"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_3330649e","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":53},"in_reply_to":"dada55a8_305537c6","updated":"2016-07-29 12:51:41.000000000","message":"Good idea, I didn\u0027t realize the sentence became almost unreadable.","commit_id":"a10a47492ed4f259e8ec59f15f0fb8ff9e9339eb"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"e7cbc537d4a4b4899d50d6ce02e256b577a77b87","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix Scheduler manager masking retype fail details"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a retype fails because it requires a migration and we haven\u0027t"},{"line_number":10,"context_line":"changed the migration policy -defaulting to \"never\"- we no longer get a"},{"line_number":11,"context_line":"specific log message, like we used to.  Now we get a generic error as"},{"line_number":12,"context_line":"the scheduler manager is hiding the error details."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_aec75562","line":10,"updated":"2016-08-02 06:49:26.000000000","message":"The code you are modifying has been change much since its initial implementation from Avishay, I guess you mean Pham\u0027 commit 8ae1483370d110fc0daf90da85d06103a15d00f4 has changed it\u0027s behavior?","commit_id":"04febf255f9b1eab22f33efc1799dbfc147bce00"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e41f0ee1740c809ff998cbeae9ba6f0644f19b6b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix Scheduler manager masking retype fail details"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a retype fails because it requires a migration and we haven\u0027t"},{"line_number":10,"context_line":"changed the migration policy -defaulting to \"never\"- we no longer get a"},{"line_number":11,"context_line":"specific log message, like we used to.  Now we get a generic error as"},{"line_number":12,"context_line":"the scheduler manager is hiding the error details."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_c3ec052c","line":10,"in_reply_to":"bacf61ea_aec75562","updated":"2016-08-02 14:53:05.000000000","message":"No, I believe this regression was introduced by another patch, the one that added the error messages, but I don\u0027t think assigning blame is really that important.  ;-)","commit_id":"04febf255f9b1eab22f33efc1799dbfc147bce00"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"415631db835db74ad88438797a4cc8359340fd2b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the scheduler manager is hiding the error details."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes this by logging the real exception raised by"},{"line_number":15,"context_line":"fid_retype_host."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic086bdcc65780c5b76b671a161fa10a86dfa60c1"},{"line_number":18,"context_line":"Closes-Bug: #1605673"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_feea7eab","line":15,"updated":"2016-08-02 15:11:35.000000000","message":"s/fid/find/","commit_id":"04febf255f9b1eab22f33efc1799dbfc147bce00"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f36995da15a63ec1cd5be592487993f1c2883ce3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the scheduler manager is hiding the error details."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes this by logging the real exception raised by"},{"line_number":15,"context_line":"fid_retype_host."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic086bdcc65780c5b76b671a161fa10a86dfa60c1"},{"line_number":18,"context_line":"Closes-Bug: #1605673"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_748ced7f","line":15,"in_reply_to":"bacf61ea_feea7eab","updated":"2016-08-02 15:30:38.000000000","message":"Will fix it when I have to update another patch.","commit_id":"04febf255f9b1eab22f33efc1799dbfc147bce00"}],"cinder/scheduler/manager.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"e7cbc537d4a4b4899d50d6ce02e256b577a77b87","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        except Exception as ex:"},{"line_number":246,"context_line":"            # Not having a valid host is an expected exception, so we don\u0027t"},{"line_number":247,"context_line":"            # reraise on it."},{"line_number":248,"context_line":"            reraise \u003d not isinstance(ex, exception.NoValidHost)"},{"line_number":249,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dreraise):"},{"line_number":250,"context_line":"                _retype_volume_set_error(self, context, ex, request_spec,"},{"line_number":251,"context_line":"                                         volume, None, reservations)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8ec25151","line":248,"updated":"2016-08-02 06:49:26.000000000","message":"This isn\u0027t correct.  https://github.com/openstack/cinder/blob/master/cinder/scheduler/filter_scheduler.py#L133-L136 This NoValidHost is not an expected expcetion.  In order to fix this, looks like we\u0027d better raise a different kind of exception when migration policy is \u0027never\u0027.","commit_id":"04febf255f9b1eab22f33efc1799dbfc147bce00"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"32c0d6bf0bf7cca7cfe1e2871dcf9d02d1602667","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        except Exception as ex:"},{"line_number":246,"context_line":"            # Not having a valid host is an expected exception, so we don\u0027t"},{"line_number":247,"context_line":"            # reraise on it."},{"line_number":248,"context_line":"            reraise \u003d not isinstance(ex, exception.NoValidHost)"},{"line_number":249,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dreraise):"},{"line_number":250,"context_line":"                _retype_volume_set_error(self, context, ex, request_spec,"},{"line_number":251,"context_line":"                                         volume, None, reservations)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e92483b3","line":248,"updated":"2016-08-02 17:00:10.000000000","message":"You are right, there\u0027s no need to raise exception for both cases, your change looks fine. But since the log message has been like this since initial implementation (in other words, we never get this right), so you care to change your commit message?","commit_id":"04febf255f9b1eab22f33efc1799dbfc147bce00"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"415631db835db74ad88438797a4cc8359340fd2b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        except Exception as ex:"},{"line_number":246,"context_line":"            # Not having a valid host is an expected exception, so we don\u0027t"},{"line_number":247,"context_line":"            # reraise on it."},{"line_number":248,"context_line":"            reraise \u003d not isinstance(ex, exception.NoValidHost)"},{"line_number":249,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dreraise):"},{"line_number":250,"context_line":"                _retype_volume_set_error(self, context, ex, request_spec,"},{"line_number":251,"context_line":"                                         volume, None, reservations)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5ed0eaf7","line":248,"updated":"2016-08-02 15:11:35.000000000","message":"find_retype_host() would raise NoValidHost in two cases: 1) \u0027migration_policy\u0027 is not \u0027never\u0027 and scheduler failed to find suitable host; 2) \u0027migration_policy\u0027 is \u0027never\u0027 and current_host is not suitable for the request.  My understanding is we don\u0027t reraise the 2nd NoValidHost but we do want to raise 1st one, don\u0027t we?","commit_id":"04febf255f9b1eab22f33efc1799dbfc147bce00"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f36995da15a63ec1cd5be592487993f1c2883ce3","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        except Exception as ex:"},{"line_number":246,"context_line":"            # Not having a valid host is an expected exception, so we don\u0027t"},{"line_number":247,"context_line":"            # reraise on it."},{"line_number":248,"context_line":"            reraise \u003d not isinstance(ex, exception.NoValidHost)"},{"line_number":249,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dreraise):"},{"line_number":250,"context_line":"                _retype_volume_set_error(self, context, ex, request_spec,"},{"line_number":251,"context_line":"                                         volume, None, reservations)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d49959d2","line":248,"in_reply_to":"bacf61ea_5ed0eaf7","updated":"2016-08-02 15:30:38.000000000","message":"That is correct, we have those 2 different cases, but we don\u0027t want to raise an exception in any of those cases.\n\nRetype is an async call, so only unexpected exceptions should be reraised, with expected exceptions we want to update the volume status and just log the error.","commit_id":"04febf255f9b1eab22f33efc1799dbfc147bce00"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e41f0ee1740c809ff998cbeae9ba6f0644f19b6b","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        except Exception as ex:"},{"line_number":246,"context_line":"            # Not having a valid host is an expected exception, so we don\u0027t"},{"line_number":247,"context_line":"            # reraise on it."},{"line_number":248,"context_line":"            reraise \u003d not isinstance(ex, exception.NoValidHost)"},{"line_number":249,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dreraise):"},{"line_number":250,"context_line":"                _retype_volume_set_error(self, context, ex, request_spec,"},{"line_number":251,"context_line":"                                         volume, None, reservations)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e8476875","line":248,"in_reply_to":"bacf61ea_8ec25151","updated":"2016-08-02 14:53:05.000000000","message":"That\u0027s precisely why we are *not* raising it.  reraise variable is False if exception is NoValidHost, so save_and_reraise_exception will not reraise it, just as it was before.","commit_id":"04febf255f9b1eab22f33efc1799dbfc147bce00"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e8a48b2ab27e58ed4ba5ef694643f739827cee66","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        except Exception as ex:"},{"line_number":246,"context_line":"            # Not having a valid host is an expected exception, so we don\u0027t"},{"line_number":247,"context_line":"            # reraise on it."},{"line_number":248,"context_line":"            reraise \u003d not isinstance(ex, exception.NoValidHost)"},{"line_number":249,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dreraise):"},{"line_number":250,"context_line":"                _retype_volume_set_error(self, context, ex, request_spec,"},{"line_number":251,"context_line":"                                         volume, None, reservations)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8fe34733","line":248,"in_reply_to":"bacf61ea_e92483b3","updated":"2016-08-02 17:42:42.000000000","message":"Sure","commit_id":"04febf255f9b1eab22f33efc1799dbfc147bce00"}]}