)]}'
{"cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_base.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"7635c93423666be52748e4041b14b36a64d4fa5b","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def test_create_volume_from_snapshot(self):"},{"line_number":252,"context_line":"        volume \u003d fake.VOLUME"},{"line_number":253,"context_line":"        self.mock_object(self.driver, \u0027_clone_source_to_destination_volume\u0027,"},{"line_number":254,"context_line":"                         mock.Mock(return_value\u003d\u0027fake\u0027))"},{"line_number":255,"context_line":"        expected_source \u003d {"},{"line_number":256,"context_line":"            \u0027name\u0027: fake.SNAPSHOT_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_150fe039","line":253,"range":{"start_line":253,"start_character":13,"end_line":253,"end_character":24},"updated":"2016-07-26 14:10:45.000000000","message":"If this line change to: mock_clone \u003d self.mock_object(...) then the lines 264-263 will look like:\nmock_clone.assert_called_once_with(...) and the backslash will not be needed.","commit_id":"5dcbe2d12f315b3c2269e0e2ca2986807d535ee9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6b47393d28eca1d1a2ee96db0821793141908b3d","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def test_create_volume_from_snapshot(self):"},{"line_number":252,"context_line":"        volume \u003d fake.VOLUME"},{"line_number":253,"context_line":"        self.mock_object(self.driver, \u0027_clone_source_to_destination_volume\u0027,"},{"line_number":254,"context_line":"                         mock.Mock(return_value\u003d\u0027fake\u0027))"},{"line_number":255,"context_line":"        expected_source \u003d {"},{"line_number":256,"context_line":"            \u0027name\u0027: fake.SNAPSHOT_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_d8bc5d6e","line":253,"range":{"start_line":253,"start_character":13,"end_line":253,"end_character":24},"in_reply_to":"dada55a8_150fe039","updated":"2016-07-26 14:18:27.000000000","message":"you\u0027re right, will update this","commit_id":"5dcbe2d12f315b3c2269e0e2ca2986807d535ee9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1cb458db072afc08b526b407acaaee7c673bb5cb","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def test_create_volume_from_snapshot(self):"},{"line_number":252,"context_line":"        volume \u003d fake.VOLUME"},{"line_number":253,"context_line":"        self.mock_object(self.driver, \u0027_clone_source_to_destination_volume\u0027,"},{"line_number":254,"context_line":"                         mock.Mock(return_value\u003d\u0027fake\u0027))"},{"line_number":255,"context_line":"        expected_source \u003d {"},{"line_number":256,"context_line":"            \u0027name\u0027: fake.SNAPSHOT_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_83bb890e","line":253,"range":{"start_line":253,"start_character":13,"end_line":253,"end_character":24},"in_reply_to":"dada55a8_d8bc5d6e","updated":"2016-07-26 18:13:41.000000000","message":"Done","commit_id":"5dcbe2d12f315b3c2269e0e2ca2986807d535ee9"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"7635c93423666be52748e4041b14b36a64d4fa5b","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            fake.IMAGE_FILE_ID)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        self.assertIsNone(retval)"},{"line_number":414,"context_line":"        self.assertEqual(exc is not None, mock_log.warning.called)"},{"line_number":415,"context_line":"        self.assertEqual(2, mock_log.info.call_count)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_35494432","line":414,"range":{"start_line":414,"start_character":24,"end_line":414,"end_character":25},"updated":"2016-07-26 14:10:45.000000000","message":"What about self.assertIsNotNone(exc)?","commit_id":"5dcbe2d12f315b3c2269e0e2ca2986807d535ee9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6b47393d28eca1d1a2ee96db0821793141908b3d","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            fake.IMAGE_FILE_ID)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        self.assertIsNone(retval)"},{"line_number":414,"context_line":"        self.assertEqual(exc is not None, mock_log.warning.called)"},{"line_number":415,"context_line":"        self.assertEqual(2, mock_log.info.call_count)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    @ddt.data(True, False)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_388779b6","line":414,"range":{"start_line":414,"start_character":24,"end_line":414,"end_character":25},"in_reply_to":"dada55a8_35494432","updated":"2016-07-26 14:18:27.000000000","message":"exc is an argument to this test..","commit_id":"5dcbe2d12f315b3c2269e0e2ca2986807d535ee9"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_cmode.py":[{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"82950de8756c15366ee8c8e622dcec3df0018533","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"        self.assertIsNone(retval)"},{"line_number":1127,"context_line":"        drv._copy_from_img_service.assert_called_once_with("},{"line_number":1128,"context_line":"            context, volume, image_service, image_id)"},{"line_number":1129,"context_line":"        nfs_base.NetAppNfsDriver.copy_image_to_volume. \\"},{"line_number":1130,"context_line":"            assert_called_once_with(context, volume, image_service, image_id)"},{"line_number":1131,"context_line":"        mock_log.info.assert_not_called()"},{"line_number":1132,"context_line":"        self.assertEqual(1, mock_log.exception.call_count)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_f8b2cf47","line":1129,"updated":"2016-07-27 11:48:42.000000000","message":"Avoid using \u0027\\\u0027","commit_id":"b5a75b0d922607d871b5753281371e176df40b1c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91b57d0eba9efb6f721e1f5fd089e8d68295571f","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"        self.assertIsNone(retval)"},{"line_number":1127,"context_line":"        drv._copy_from_img_service.assert_called_once_with("},{"line_number":1128,"context_line":"            context, volume, image_service, image_id)"},{"line_number":1129,"context_line":"        nfs_base.NetAppNfsDriver.copy_image_to_volume. \\"},{"line_number":1130,"context_line":"            assert_called_once_with(context, volume, image_service, image_id)"},{"line_number":1131,"context_line":"        mock_log.info.assert_not_called()"},{"line_number":1132,"context_line":"        self.assertEqual(1, mock_log.exception.call_count)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_189243f6","line":1129,"in_reply_to":"dada55a8_f8b2cf47","updated":"2016-07-27 11:59:17.000000000","message":"thanks, it\u0027s a pep8 preference, not a hacking rule. I will update it if i need to make another patch. I think long zuul queues are not worth challenging with this change.","commit_id":"b5a75b0d922607d871b5753281371e176df40b1c"}]}