)]}'
{"cinder/volume/drivers/coho.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c2425bf12ac293345e558b5f7f4c40627ccae376","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    # We are more permissive."},{"line_number":324,"context_line":"    SHARE_FORMAT_REGEX \u003d r\u0027.+:/.*\u0027"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    coho_qos_keys \u003d [\u0027maxIOPS\u0027, \u0027maxMBS\u0027]"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":329,"context_line":"        super(CohoDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_5f14ec9e","line":326,"updated":"2016-07-29 18:14:52.000000000","message":"Should it be COHO_QOS_KEYS?","commit_id":"31c42d8b549c09ec8e8a28785f8d048660d4e306"},{"author":{"_account_id":18448,"name":"Bardia Keyoumarsi","email":"bardia.keyoumarsi@cohodata.com","username":"bkeyoumarsi"},"change_message_id":"aa70a683b81434c7195d354d06fa81d974221e73","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    # We are more permissive."},{"line_number":324,"context_line":"    SHARE_FORMAT_REGEX \u003d r\u0027.+:/.*\u0027"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    coho_qos_keys \u003d [\u0027maxIOPS\u0027, \u0027maxMBS\u0027]"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":329,"context_line":"        super(CohoDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_4a80a58b","line":326,"in_reply_to":"bacf61ea_5f14ec9e","updated":"2016-07-29 22:00:15.000000000","message":"Done","commit_id":"31c42d8b549c09ec8e8a28785f8d048660d4e306"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c2425bf12ac293345e558b5f7f4c40627ccae376","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            else:"},{"line_number":407,"context_line":"                kvs \u003d {}"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"            for key, value in kvs.items():"},{"line_number":410,"context_line":"                if key in self.coho_qos_keys:"},{"line_number":411,"context_line":"                    qos[key] \u003d int(value)"},{"line_number":412,"context_line":"        return qos"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_df6f3c29","line":409,"updated":"2016-07-29 18:14:52.000000000","message":"nit: we can iterate throw self.coho_qos_keys to make it a bit faster","commit_id":"31c42d8b549c09ec8e8a28785f8d048660d4e306"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c2425bf12ac293345e558b5f7f4c40627ccae376","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        client \u003d self._get_rpcclient(addr, self.configuration.coho_rpc_port)"},{"line_number":451,"context_line":"        client.create_volume_from_snapshot(snapshot_name, volume_path)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        qos \u003d self._retrieve_qos_setting(volume)"},{"line_number":454,"context_line":"        if qos:"},{"line_number":455,"context_line":"            self._do_set_qos_policy(volume, qos)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        return {\u0027provider_location\u0027: volume[\u0027provider_location\u0027]}"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_1f4d54c4","line":455,"range":{"start_line":453,"start_character":16,"end_line":455,"end_character":18},"updated":"2016-07-29 18:14:52.000000000","message":"These line are copy-paster 3 times. Could we move\n qos \u003d self._retrieve_qos_setting(volume)\n        if qos:\n\nlines into the \u0027_do_set_qos_policy\u0027 method?","commit_id":"31c42d8b549c09ec8e8a28785f8d048660d4e306"},{"author":{"_account_id":18448,"name":"Bardia Keyoumarsi","email":"bardia.keyoumarsi@cohodata.com","username":"bkeyoumarsi"},"change_message_id":"aa70a683b81434c7195d354d06fa81d974221e73","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        client \u003d self._get_rpcclient(addr, self.configuration.coho_rpc_port)"},{"line_number":451,"context_line":"        client.create_volume_from_snapshot(snapshot_name, volume_path)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        qos \u003d self._retrieve_qos_setting(volume)"},{"line_number":454,"context_line":"        if qos:"},{"line_number":455,"context_line":"            self._do_set_qos_policy(volume, qos)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        return {\u0027provider_location\u0027: volume[\u0027provider_location\u0027]}"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_0a7a2dbd","line":455,"range":{"start_line":453,"start_character":16,"end_line":455,"end_character":18},"in_reply_to":"bacf61ea_1f4d54c4","updated":"2016-07-29 22:00:15.000000000","message":"Done","commit_id":"31c42d8b549c09ec8e8a28785f8d048660d4e306"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c2425bf12ac293345e558b5f7f4c40627ccae376","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        Changes the volume\u0027s QoS policy if needed."},{"line_number":479,"context_line":"        \"\"\""},{"line_number":480,"context_line":"        qos \u003d {}"},{"line_number":481,"context_line":"        qos \u003d self._get_qos_by_volume_type(ctxt, new_type[\u0027id\u0027])"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        if qos:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_3f0bf88f","line":480,"updated":"2016-07-29 18:14:52.000000000","message":"We don\u0027t need this line. _get_qos_by_volume_type will return empty dict by default","commit_id":"31c42d8b549c09ec8e8a28785f8d048660d4e306"},{"author":{"_account_id":18448,"name":"Bardia Keyoumarsi","email":"bardia.keyoumarsi@cohodata.com","username":"bkeyoumarsi"},"change_message_id":"aa70a683b81434c7195d354d06fa81d974221e73","unresolved":false,"context_lines":[{"line_number":477,"context_line":""},{"line_number":478,"context_line":"        Changes the volume\u0027s QoS policy if needed."},{"line_number":479,"context_line":"        \"\"\""},{"line_number":480,"context_line":"        qos \u003d {}"},{"line_number":481,"context_line":"        qos \u003d self._get_qos_by_volume_type(ctxt, new_type[\u0027id\u0027])"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        if qos:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_aa7041dd","line":480,"in_reply_to":"bacf61ea_3f0bf88f","updated":"2016-07-29 22:00:15.000000000","message":"Done","commit_id":"31c42d8b549c09ec8e8a28785f8d048660d4e306"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"983aaa5ffdfe6c556c714f239f75d023e98da279","unresolved":false,"context_lines":[{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":440,"context_line":"        \"\"\"Delete a volume snapshot.\"\"\""},{"line_number":441,"context_line":"        addr, _ \u003d self._get_volume_location(snapshot[\u0027volume_id\u0027])"},{"line_number":442,"context_line":"        snapshot_name \u003d snapshot[\u0027name\u0027]"},{"line_number":443,"context_line":"        client \u003d self._get_rpcclient(addr, self.configuration.coho_rpc_port)"},{"line_number":444,"context_line":"        client.delete_snapshot(snapshot_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_5ca16493","line":441,"range":{"start_line":441,"start_character":14,"end_line":441,"end_character":15},"updated":"2016-08-05 13:01:09.000000000","message":"This is normally good practice for unused variables, but since we have the _() translation marker, this could cause a problem with hiding that method name. Can you change this to something else denoting its unused status?","commit_id":"d52015849aed8b45877ce1a0375344162f28e2d9"},{"author":{"_account_id":18448,"name":"Bardia Keyoumarsi","email":"bardia.keyoumarsi@cohodata.com","username":"bkeyoumarsi"},"change_message_id":"304dc9ffad83f2d8ad18db427f1aba41d81db0b0","unresolved":false,"context_lines":[{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":440,"context_line":"        \"\"\"Delete a volume snapshot.\"\"\""},{"line_number":441,"context_line":"        addr, _ \u003d self._get_volume_location(snapshot[\u0027volume_id\u0027])"},{"line_number":442,"context_line":"        snapshot_name \u003d snapshot[\u0027name\u0027]"},{"line_number":443,"context_line":"        client \u003d self._get_rpcclient(addr, self.configuration.coho_rpc_port)"},{"line_number":444,"context_line":"        client.delete_snapshot(snapshot_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_86fc1473","line":441,"range":{"start_line":441,"start_character":14,"end_line":441,"end_character":15},"in_reply_to":"bacf61ea_5ca16493","updated":"2016-08-05 20:39:48.000000000","message":"Done","commit_id":"d52015849aed8b45877ce1a0375344162f28e2d9"}]}