)]}'
{"cinder/volume/drivers/sheepdog.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"fed134bd4e68e27a5dcabf6fe949b58048c8c127","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self._try_execute(\u0027collie\u0027, \u0027vdi\u0027, \u0027resize\u0027,"},{"line_number":91,"context_line":"                          volume[\u0027name\u0027], size)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _delete(self, volume):"},{"line_number":94,"context_line":"        self._try_execute(\u0027collie\u0027, \u0027vdi\u0027, \u0027delete\u0027,"},{"line_number":95,"context_line":"                          volume[\u0027name\u0027])"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FmHw%3D","line":93,"updated":"2013-06-27 03:26:52.000000000","message":"This function has the same content as the function \"delete_volume\".","commit_id":"7501e9af39d17f4621d4d15b3b1094512da02875"},{"author":{"_account_id":6997,"name":"Wenhao Xu","email":"wenhao@zelin.io","username":"wenhao-x"},"change_message_id":"5232bf062a5a471ca3a33baeaa13f6fe42fa713b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self._try_execute(\u0027collie\u0027, \u0027vdi\u0027, \u0027resize\u0027,"},{"line_number":91,"context_line":"                          volume[\u0027name\u0027], size)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _delete(self, volume):"},{"line_number":94,"context_line":"        self._try_execute(\u0027collie\u0027, \u0027vdi\u0027, \u0027delete\u0027,"},{"line_number":95,"context_line":"                          volume[\u0027name\u0027])"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FlZ4%3D","line":93,"in_reply_to":"AAAAPn%2F%2FmHw%3D","updated":"2013-06-27 09:54:50.000000000","message":"oops, I need to clean this one.","commit_id":"7501e9af39d17f4621d4d15b3b1094512da02875"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"fed134bd4e68e27a5dcabf6fe949b58048c8c127","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                                           image_id, tmp.name)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"            # remove the image created by import."},{"line_number":107,"context_line":"            self._delete(volume)"},{"line_number":108,"context_line":"            # convert and store into sheepdog"},{"line_number":109,"context_line":"            image_utils.convert_image(tmp, \u0027sheepdog:%s\u0027 % volume[\u0027name\u0027],"},{"line_number":110,"context_line":"                                      \u0027raw\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FmHQ%3D","line":107,"updated":"2013-06-27 03:26:52.000000000","message":"The comment says \"remove the image\", but in fact, self._delete(volume) is going to delete the volume. I think even if the image is going to delete, it should be after the image conversion.\r\n\r\nIn Line 111, is the volume going to resize after the its deletion?","commit_id":"7501e9af39d17f4621d4d15b3b1094512da02875"},{"author":{"_account_id":6997,"name":"Wenhao Xu","email":"wenhao@zelin.io","username":"wenhao-x"},"change_message_id":"5232bf062a5a471ca3a33baeaa13f6fe42fa713b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                                           image_id, tmp.name)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"            # remove the image created by import."},{"line_number":107,"context_line":"            self._delete(volume)"},{"line_number":108,"context_line":"            # convert and store into sheepdog"},{"line_number":109,"context_line":"            image_utils.convert_image(tmp, \u0027sheepdog:%s\u0027 % volume[\u0027name\u0027],"},{"line_number":110,"context_line":"                                      \u0027raw\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FlZ8%3D","line":107,"in_reply_to":"AAAAPn%2F%2FmHQ%3D","updated":"2013-06-27 09:54:50.000000000","message":"This is trying to remove the vdi created by import.\n\nThe import works in this way:\n1. create a volume from a cinder image ref. This will create an empty vdi in sheepdog. (See volume/drivers/manager.py: _create_volume)\n2.  in the driver, delete the empty vdi and import the real image.\n\nUsers could specify the size of the volume when creating volume from an image. So resize is necessary.","commit_id":"7501e9af39d17f4621d4d15b3b1094512da02875"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"1d84f62d26ff7184165ae6a280dc2feed0d9d6c8","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import os"},{"line_number":24,"context_line":"import tempfile"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo.config import cfg"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fz48%3D","line":25,"updated":"2013-07-11 03:35:03.000000000","message":"stdlib modules should be grouped together: https://github.com/openstack/cinder/blob/master/HACKING.rst#imports","commit_id":"0919a952a1520527d9a0cc1e3716b72b54afb8a0"}]}