)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"80d986b91838fe9726ca68a62ec9c09526fafbd1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix the returned value of CG actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- create_consistencygroup_from_src"},{"line_number":10,"context_line":"- create_cgsnapshot"},{"line_number":11,"context_line":"- delete_cgsnapshot"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_50870ed7","line":9,"updated":"2016-08-31 07:56:23.000000000","message":"nit: This one has not been changed","commit_id":"cb94db1933d4808d8b3dd2aa97deba3cbfec02b2"}],"cinder/tests/unit/volume/drivers/emc/test_emc_xtremio.py":[{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1cb2638c3cead825d0e4da55921e9e39310b7119","unresolved":false,"context_lines":[{"line_number":779,"context_line":"         volume_get_all_by_group.return_value) \u003d [mock.MagicMock()]"},{"line_number":780,"context_line":"        ret \u003d self.driver.create_cgsnapshot(d.context, d.cgsnapshot,"},{"line_number":781,"context_line":"                                            [snapshot_obj])"},{"line_number":782,"context_line":"        self.assertEqual(ret[1][0][\u0027id\u0027], snapshot_obj[\u0027id\u0027])"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":785,"context_line":"    def test_cg_delete(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_a0066783","line":782,"updated":"2016-07-27 08:48:04.000000000","message":"If snapshot_obj[\u0027id\u0027] is the expected value, we should make it the first parameter:\nself.assertEqual(snapshot_obj[\u0027id\u0027], ret[1][0][\u0027id\u0027])","commit_id":"492fd69835f28aa3eebe4416627dc31d98a9df0e"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"958bda4976d1439a2ef575337163a63295c7aa60","unresolved":false,"context_lines":[{"line_number":779,"context_line":"         volume_get_all_by_group.return_value) \u003d [mock.MagicMock()]"},{"line_number":780,"context_line":"        ret \u003d self.driver.create_cgsnapshot(d.context, d.cgsnapshot,"},{"line_number":781,"context_line":"                                            [snapshot_obj])"},{"line_number":782,"context_line":"        self.assertEqual(ret[1][0][\u0027id\u0027], snapshot_obj[\u0027id\u0027])"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":785,"context_line":"    def test_cg_delete(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_7b49e45f","line":782,"in_reply_to":"dada55a8_a0066783","updated":"2016-07-31 11:31:45.000000000","message":"Done","commit_id":"492fd69835f28aa3eebe4416627dc31d98a9df0e"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1cb2638c3cead825d0e4da55921e9e39310b7119","unresolved":false,"context_lines":[{"line_number":820,"context_line":"        xms_data[\u0027snapshot-sets\u0027] \u003d {snapset_name: snapset1, 1: snapset1}"},{"line_number":821,"context_line":"        ret \u003d self.driver.delete_cgsnapshot(d.context, d.cgsnapshot,"},{"line_number":822,"context_line":"                                            [snapshot_obj])"},{"line_number":823,"context_line":"        self.assertEqual(ret[1][0][\u0027id\u0027], snapshot_obj[\u0027id\u0027])"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":826,"context_line":"    def test_cg_from_src_snapshot(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_e0fcdf73","line":823,"updated":"2016-07-27 08:48:04.000000000","message":"same","commit_id":"492fd69835f28aa3eebe4416627dc31d98a9df0e"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"958bda4976d1439a2ef575337163a63295c7aa60","unresolved":false,"context_lines":[{"line_number":820,"context_line":"        xms_data[\u0027snapshot-sets\u0027] \u003d {snapset_name: snapset1, 1: snapset1}"},{"line_number":821,"context_line":"        ret \u003d self.driver.delete_cgsnapshot(d.context, d.cgsnapshot,"},{"line_number":822,"context_line":"                                            [snapshot_obj])"},{"line_number":823,"context_line":"        self.assertEqual(ret[1][0][\u0027id\u0027], snapshot_obj[\u0027id\u0027])"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":826,"context_line":"    def test_cg_from_src_snapshot(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5b46a04f","line":823,"in_reply_to":"dada55a8_e0fcdf73","updated":"2016-07-31 11:31:45.000000000","message":"Done","commit_id":"492fd69835f28aa3eebe4416627dc31d98a9df0e"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"1cb2638c3cead825d0e4da55921e9e39310b7119","unresolved":false,"context_lines":[{"line_number":852,"context_line":"                                                           [new_vol1],"},{"line_number":853,"context_line":"                                                           d.cgsnapshot,"},{"line_number":854,"context_line":"                                                           [snapshot1])"},{"line_number":855,"context_line":"        self.assertEqual(res[1][0][\u0027id\u0027], new_vol1[\u0027id\u0027])"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":858,"context_line":"    def test_cg_from_src_cg(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c0ff1b64","line":855,"updated":"2016-07-27 08:48:04.000000000","message":"same","commit_id":"492fd69835f28aa3eebe4416627dc31d98a9df0e"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"958bda4976d1439a2ef575337163a63295c7aa60","unresolved":false,"context_lines":[{"line_number":852,"context_line":"                                                           [new_vol1],"},{"line_number":853,"context_line":"                                                           d.cgsnapshot,"},{"line_number":854,"context_line":"                                                           [snapshot1])"},{"line_number":855,"context_line":"        self.assertEqual(res[1][0][\u0027id\u0027], new_vol1[\u0027id\u0027])"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":858,"context_line":"    def test_cg_from_src_cg(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_bb751c99","line":855,"in_reply_to":"dada55a8_c0ff1b64","updated":"2016-07-31 11:31:45.000000000","message":"Done","commit_id":"492fd69835f28aa3eebe4416627dc31d98a9df0e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"519bcf579748a3a323099bf6165eed21f06bb185","unresolved":false,"context_lines":[{"line_number":806,"context_line":"         volume_get_all_by_group.return_value) \u003d [mock.MagicMock()]"},{"line_number":807,"context_line":"        res \u003d self.driver.create_cgsnapshot(d.context, d.cgsnapshot,"},{"line_number":808,"context_line":"                                            [snapshot_obj])"},{"line_number":809,"context_line":"        self.assertEqual(res, (None, None))"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":812,"context_line":"    def test_cg_delete(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_44f79a58","line":809,"updated":"2016-08-30 08:47:21.000000000","message":"-1: Parameter order in asserts must be first expected, then actual result and here it\u0027s the other way around.  This should be:\n\n self.assertEqual((None, None), res)","commit_id":"562ce3790607a5084ce007ed15fa7ed51263e99c"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"b841f6a04cd8cdb23716bacab5be7c7b148c502e","unresolved":false,"context_lines":[{"line_number":806,"context_line":"         volume_get_all_by_group.return_value) \u003d [mock.MagicMock()]"},{"line_number":807,"context_line":"        res \u003d self.driver.create_cgsnapshot(d.context, d.cgsnapshot,"},{"line_number":808,"context_line":"                                            [snapshot_obj])"},{"line_number":809,"context_line":"        self.assertEqual(res, (None, None))"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":812,"context_line":"    def test_cg_delete(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_b111875f","line":809,"in_reply_to":"fa7ab95a_44f79a58","updated":"2016-08-30 09:14:26.000000000","message":"Done","commit_id":"562ce3790607a5084ce007ed15fa7ed51263e99c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"519bcf579748a3a323099bf6165eed21f06bb185","unresolved":false,"context_lines":[{"line_number":847,"context_line":"        xms_data[\u0027snapshot-sets\u0027] \u003d {snapset_name: snapset1, 1: snapset1}"},{"line_number":848,"context_line":"        res \u003d self.driver.delete_cgsnapshot(d.context, d.cgsnapshot,"},{"line_number":849,"context_line":"                                            [snapshot_obj])"},{"line_number":850,"context_line":"        self.assertEqual(res, (None, None))"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":853,"context_line":"    def test_cg_from_src_snapshot(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_048832c4","line":850,"updated":"2016-08-30 08:47:21.000000000","message":"ditto","commit_id":"562ce3790607a5084ce007ed15fa7ed51263e99c"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"b841f6a04cd8cdb23716bacab5be7c7b148c502e","unresolved":false,"context_lines":[{"line_number":847,"context_line":"        xms_data[\u0027snapshot-sets\u0027] \u003d {snapset_name: snapset1, 1: snapset1}"},{"line_number":848,"context_line":"        res \u003d self.driver.delete_cgsnapshot(d.context, d.cgsnapshot,"},{"line_number":849,"context_line":"                                            [snapshot_obj])"},{"line_number":850,"context_line":"        self.assertEqual(res, (None, None))"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":853,"context_line":"    def test_cg_from_src_snapshot(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_d1144b4e","line":850,"in_reply_to":"fa7ab95a_048832c4","updated":"2016-08-30 09:14:26.000000000","message":"Done","commit_id":"562ce3790607a5084ce007ed15fa7ed51263e99c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"519bcf579748a3a323099bf6165eed21f06bb185","unresolved":false,"context_lines":[{"line_number":879,"context_line":"                                                           [new_vol1],"},{"line_number":880,"context_line":"                                                           d.cgsnapshot,"},{"line_number":881,"context_line":"                                                           [snapshot1])"},{"line_number":882,"context_line":"        self.assertEqual(res, (None, None))"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":885,"context_line":"    def test_cg_from_src_cg(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_448ebad0","line":882,"updated":"2016-08-30 08:47:21.000000000","message":"ditto","commit_id":"562ce3790607a5084ce007ed15fa7ed51263e99c"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"b841f6a04cd8cdb23716bacab5be7c7b148c502e","unresolved":false,"context_lines":[{"line_number":879,"context_line":"                                                           [new_vol1],"},{"line_number":880,"context_line":"                                                           d.cgsnapshot,"},{"line_number":881,"context_line":"                                                           [snapshot1])"},{"line_number":882,"context_line":"        self.assertEqual(res, (None, None))"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.SnapshotList.get_all_for_cgsnapshot\u0027)"},{"line_number":885,"context_line":"    def test_cg_from_src_cg(self, get_all_for_cgsnapshot, req):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_110b132b","line":882,"in_reply_to":"fa7ab95a_448ebad0","updated":"2016-08-30 09:14:26.000000000","message":"Done","commit_id":"562ce3790607a5084ce007ed15fa7ed51263e99c"}],"cinder/volume/drivers/emc/xtremio.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"68ce6a5498baaceb66a7e09720641240f824c96d","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                        ver\u003d\u0027v2\u0027)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        ret_vols \u003d [{\u0027id\u0027: vol.id, \u0027status\u0027: \u0027available\u0027} for vol in volumes]"},{"line_number":722,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        return model_update, ret_vols"},{"line_number":725,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_60b8ef2a","line":722,"updated":"2016-08-05 16:49:20.000000000","message":"Please use ConsistencyGroupStatus.AVAILABLE for CG status.  You can leave the volume status alone as that is not defined in fields.py yet.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/objects/fields.py#L48","commit_id":"2d598446cc7ed0fbd5705945064e2413192acc93"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"2b04a61d32732863a9670f21fc36ce44f7811830","unresolved":false,"context_lines":[{"line_number":719,"context_line":"                        ver\u003d\u0027v2\u0027)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        ret_vols \u003d [{\u0027id\u0027: vol.id, \u0027status\u0027: \u0027available\u0027} for vol in volumes]"},{"line_number":722,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"        return model_update, ret_vols"},{"line_number":725,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_57562fce","line":722,"in_reply_to":"bacf61ea_60b8ef2a","updated":"2016-08-07 14:05:22.000000000","message":"Done","commit_id":"2d598446cc7ed0fbd5705945064e2413192acc93"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"68ce6a5498baaceb66a7e09720641240f824c96d","unresolved":false,"context_lines":[{"line_number":756,"context_line":"                \u0027snapshot-set-name\u0027: self._get_cgsnap_name(cgsnapshot)}"},{"line_number":757,"context_line":"        self.client.req(\u0027snapshots\u0027, \u0027POST\u0027, data, ver\u003d\u0027v2\u0027)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: \u0027available\u0027} for snap in snapshots]"},{"line_number":760,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        return model_update, snaps"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_604aaf56","line":759,"updated":"2016-08-05 16:49:20.000000000","message":"Please use fields.SnapshotStatus.AVAILABLE for snapshot status.","commit_id":"2d598446cc7ed0fbd5705945064e2413192acc93"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"2b04a61d32732863a9670f21fc36ce44f7811830","unresolved":false,"context_lines":[{"line_number":756,"context_line":"                \u0027snapshot-set-name\u0027: self._get_cgsnap_name(cgsnapshot)}"},{"line_number":757,"context_line":"        self.client.req(\u0027snapshots\u0027, \u0027POST\u0027, data, ver\u003d\u0027v2\u0027)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: \u0027available\u0027} for snap in snapshots]"},{"line_number":760,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        return model_update, snaps"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_b765ebaf","line":759,"in_reply_to":"bacf61ea_604aaf56","updated":"2016-08-07 14:05:22.000000000","message":"Done","commit_id":"2d598446cc7ed0fbd5705945064e2413192acc93"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"68ce6a5498baaceb66a7e09720641240f824c96d","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        self.client.req(\u0027snapshot-sets\u0027, \u0027DELETE\u0027,"},{"line_number":767,"context_line":"                        name\u003dself._get_cgsnap_name(cgsnapshot), ver\u003d\u0027v2\u0027)"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: \u0027deleted\u0027} for snap in snapshots]"},{"line_number":770,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        return model_update, snaps"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_402e8b8c","line":769,"updated":"2016-08-05 16:49:20.000000000","message":"Please use fields.SnapshotStatus.DELETED for snapshot status.","commit_id":"2d598446cc7ed0fbd5705945064e2413192acc93"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"2b04a61d32732863a9670f21fc36ce44f7811830","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        self.client.req(\u0027snapshot-sets\u0027, \u0027DELETE\u0027,"},{"line_number":767,"context_line":"                        name\u003dself._get_cgsnap_name(cgsnapshot), ver\u003d\u0027v2\u0027)"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: \u0027deleted\u0027} for snap in snapshots]"},{"line_number":770,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        return model_update, snaps"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_97fb87c0","line":769,"in_reply_to":"bacf61ea_402e8b8c","updated":"2016-08-07 14:05:22.000000000","message":"Done","commit_id":"2d598446cc7ed0fbd5705945064e2413192acc93"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"12d0ce82c28dba40c50414e10070daa5df34e5ee","unresolved":false,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: fields.SnapshotStatus.AVAILABLE}"},{"line_number":760,"context_line":"                 for snap in snapshots]"},{"line_number":761,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        return model_update, snaps"},{"line_number":764,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_94f53e52","line":761,"updated":"2016-08-08 00:27:52.000000000","message":"Use fields.ConsistencyGroupStatus.AVAILABLE","commit_id":"271364a76d435696a9a73566d14173fb60b87362"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"0f1f37dc9f3ba0f254b0acf383f6a88c0afe504f","unresolved":false,"context_lines":[{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: fields.SnapshotStatus.AVAILABLE}"},{"line_number":760,"context_line":"                 for snap in snapshots]"},{"line_number":761,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        return model_update, snaps"},{"line_number":764,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_8a4d4b9c","line":761,"in_reply_to":"bacf61ea_94f53e52","updated":"2016-08-23 15:53:48.000000000","message":"Done","commit_id":"271364a76d435696a9a73566d14173fb60b87362"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"12d0ce82c28dba40c50414e10070daa5df34e5ee","unresolved":false,"context_lines":[{"line_number":767,"context_line":"        self.client.req(\u0027snapshot-sets\u0027, fields.SnapshotStatus.DELETED,"},{"line_number":768,"context_line":"                        name\u003dself._get_cgsnap_name(cgsnapshot), ver\u003d\u0027v2\u0027)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: \u0027deleted\u0027} for snap in snapshots]"},{"line_number":771,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        return model_update, snaps"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_f4ef5a84","line":770,"updated":"2016-08-08 00:27:52.000000000","message":"fields.SnapshotStatus.DELETED","commit_id":"271364a76d435696a9a73566d14173fb60b87362"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"0f1f37dc9f3ba0f254b0acf383f6a88c0afe504f","unresolved":false,"context_lines":[{"line_number":767,"context_line":"        self.client.req(\u0027snapshot-sets\u0027, fields.SnapshotStatus.DELETED,"},{"line_number":768,"context_line":"                        name\u003dself._get_cgsnap_name(cgsnapshot), ver\u003d\u0027v2\u0027)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: \u0027deleted\u0027} for snap in snapshots]"},{"line_number":771,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        return model_update, snaps"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_352f5889","line":770,"in_reply_to":"bacf61ea_f4ef5a84","updated":"2016-08-23 15:53:48.000000000","message":"Done","commit_id":"271364a76d435696a9a73566d14173fb60b87362"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"12d0ce82c28dba40c50414e10070daa5df34e5ee","unresolved":false,"context_lines":[{"line_number":768,"context_line":"                        name\u003dself._get_cgsnap_name(cgsnapshot), ver\u003d\u0027v2\u0027)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: \u0027deleted\u0027} for snap in snapshots]"},{"line_number":771,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        return model_update, snaps"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_f4963aee","line":771,"updated":"2016-08-08 00:27:52.000000000","message":"fields.ConsistencyGroupStatus.DELETED","commit_id":"271364a76d435696a9a73566d14173fb60b87362"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"0f1f37dc9f3ba0f254b0acf383f6a88c0afe504f","unresolved":false,"context_lines":[{"line_number":768,"context_line":"                        name\u003dself._get_cgsnap_name(cgsnapshot), ver\u003d\u0027v2\u0027)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: \u0027deleted\u0027} for snap in snapshots]"},{"line_number":771,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"        return model_update, snaps"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_15e17c2d","line":771,"in_reply_to":"bacf61ea_f4963aee","updated":"2016-08-23 15:53:48.000000000","message":"Done","commit_id":"271364a76d435696a9a73566d14173fb60b87362"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bedc44be6b153098ae72fb764011888e47a9fbd6","unresolved":false,"context_lines":[{"line_number":743,"context_line":"        self.client.req(\u0027consistency-groups\u0027, \u0027POST\u0027, data\u003dcreate_data,"},{"line_number":744,"context_line":"                        ver\u003d\u0027v2\u0027)"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"        ret_vols \u003d [{\u0027id\u0027: vol.id, \u0027status\u0027: \u0027available\u0027} for vol in volumes]"},{"line_number":747,"context_line":"        model_update \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.AVAILABLE}"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        return model_update, ret_vols"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def update_consistencygroup(self, context, group,"},{"line_number":752,"context_line":"                                add_volumes\u003dNone, remove_volumes\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_45b586cb","line":749,"range":{"start_line":746,"start_character":0,"end_line":749,"end_character":37},"updated":"2016-08-26 07:54:41.000000000","message":"-1: This was correct, it should return None, None","commit_id":"169caec7c4b8679dfa92d9e13e9dca6ceb406f88"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"92c98d9da774844eb38253a3a13df41d99831ec8","unresolved":false,"context_lines":[{"line_number":743,"context_line":"        self.client.req(\u0027consistency-groups\u0027, \u0027POST\u0027, data\u003dcreate_data,"},{"line_number":744,"context_line":"                        ver\u003d\u0027v2\u0027)"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"        ret_vols \u003d [{\u0027id\u0027: vol.id, \u0027status\u0027: \u0027available\u0027} for vol in volumes]"},{"line_number":747,"context_line":"        model_update \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.AVAILABLE}"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        return model_update, ret_vols"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    def update_consistencygroup(self, context, group,"},{"line_number":752,"context_line":"                                add_volumes\u003dNone, remove_volumes\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_23572227","line":749,"range":{"start_line":746,"start_character":0,"end_line":749,"end_character":37},"in_reply_to":"fa7ab95a_45b586cb","updated":"2016-08-30 05:36:09.000000000","message":"Done","commit_id":"169caec7c4b8679dfa92d9e13e9dca6ceb406f88"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bedc44be6b153098ae72fb764011888e47a9fbd6","unresolved":false,"context_lines":[{"line_number":781,"context_line":"                \u0027snapshot-set-name\u0027: self._get_cgsnap_name(cgsnapshot)}"},{"line_number":782,"context_line":"        self.client.req(\u0027snapshots\u0027, \u0027POST\u0027, data, ver\u003d\u0027v2\u0027)"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: fields.SnapshotStatus.AVAILABLE}"},{"line_number":785,"context_line":"                 for snap in snapshots]"},{"line_number":786,"context_line":"        model_update \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.AVAILABLE}"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        return model_update, snaps"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    def delete_cgsnapshot(self, context, cgsnapshot, snapshots):"},{"line_number":791,"context_line":"        \"\"\"Deletes a cgsnapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_65d1aafb","line":788,"range":{"start_line":784,"start_character":1,"end_line":788,"end_character":34},"updated":"2016-08-26 07:54:41.000000000","message":"-1: replace all this with\n\n return None, None","commit_id":"169caec7c4b8679dfa92d9e13e9dca6ceb406f88"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"92c98d9da774844eb38253a3a13df41d99831ec8","unresolved":false,"context_lines":[{"line_number":781,"context_line":"                \u0027snapshot-set-name\u0027: self._get_cgsnap_name(cgsnapshot)}"},{"line_number":782,"context_line":"        self.client.req(\u0027snapshots\u0027, \u0027POST\u0027, data, ver\u003d\u0027v2\u0027)"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: fields.SnapshotStatus.AVAILABLE}"},{"line_number":785,"context_line":"                 for snap in snapshots]"},{"line_number":786,"context_line":"        model_update \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.AVAILABLE}"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        return model_update, snaps"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    def delete_cgsnapshot(self, context, cgsnapshot, snapshots):"},{"line_number":791,"context_line":"        \"\"\"Deletes a cgsnapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_43542620","line":788,"range":{"start_line":784,"start_character":1,"end_line":788,"end_character":34},"in_reply_to":"fa7ab95a_65d1aafb","updated":"2016-08-30 05:36:09.000000000","message":"Done","commit_id":"169caec7c4b8679dfa92d9e13e9dca6ceb406f88"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bedc44be6b153098ae72fb764011888e47a9fbd6","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        self.client.req(\u0027snapshot-sets\u0027, fields.SnapshotStatus.DELETED,"},{"line_number":793,"context_line":"                        name\u003dself._get_cgsnap_name(cgsnapshot), ver\u003d\u0027v2\u0027)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: fields.SnapshotStatus.DELETED}"},{"line_number":796,"context_line":"                 for snap in snapshots]"},{"line_number":797,"context_line":"        model_update \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        return model_update, snaps"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def _get_ig(self, name):"},{"line_number":802,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_4503c673","line":799,"range":{"start_line":795,"start_character":0,"end_line":799,"end_character":34},"updated":"2016-08-26 07:54:41.000000000","message":"-1: Replace all this with\n\n return None, None","commit_id":"169caec7c4b8679dfa92d9e13e9dca6ceb406f88"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"92c98d9da774844eb38253a3a13df41d99831ec8","unresolved":false,"context_lines":[{"line_number":792,"context_line":"        self.client.req(\u0027snapshot-sets\u0027, fields.SnapshotStatus.DELETED,"},{"line_number":793,"context_line":"                        name\u003dself._get_cgsnap_name(cgsnapshot), ver\u003d\u0027v2\u0027)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"        snaps \u003d [{\u0027id\u0027: snap.id, \u0027status\u0027: fields.SnapshotStatus.DELETED}"},{"line_number":796,"context_line":"                 for snap in snapshots]"},{"line_number":797,"context_line":"        model_update \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        return model_update, snaps"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def _get_ig(self, name):"},{"line_number":802,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_c33e76d9","line":799,"range":{"start_line":795,"start_character":0,"end_line":799,"end_character":34},"in_reply_to":"fa7ab95a_4503c673","updated":"2016-08-30 05:36:09.000000000","message":"Done","commit_id":"169caec7c4b8679dfa92d9e13e9dca6ceb406f88"}]}