)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"20ca979da4ef1e2293c41dda77ff5d99e6f528bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Resolve unittest hang issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes suspect decorator patch_no_sleep, and"},{"line_number":10,"context_line":"set the timeout \u003d 0.05 when running tests to avoid potential"},{"line_number":11,"context_line":"long running."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unittest now never hangs after rounds of running."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_508b2f68","line":10,"updated":"2016-07-26 11:58:46.000000000","message":"Set default timeout \u003d 0 in tests.","commit_id":"dd5cefc73a6c3ba4631ae2ebb6d4f6b3dc1e75f6"}],"cinder/tests/unit/volume/drivers/emc/vnx/test_client.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"20ca979da4ef1e2293c41dda77ff5d99e6f528bf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def setUp(self):"},{"line_number":49,"context_line":"        super(TestClient, self).setUp()"},{"line_number":50,"context_line":"        self.origin_timeout \u003d vnx_common.DEFAULT_TIMEOUT"},{"line_number":51,"context_line":"        vnx_common.DEFAULT_TIMEOUT \u003d 0.05"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def tearDown(self):"},{"line_number":54,"context_line":"        super(TestClient, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_30431b44","line":51,"updated":"2016-07-26 11:58:46.000000000","message":"This should just be 0.  There\u0027s no need to wait in tests at all.","commit_id":"dd5cefc73a6c3ba4631ae2ebb6d4f6b3dc1e75f6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"29f600ec763c700a7f47fa77b049d162d7ae9ff8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"class TestClient(test.TestCase):"},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TestClient, self).setUp()"},{"line_number":48,"context_line":"        self.origin_timeout \u003d vnx_common.DEFAULT_TIMEOUT"},{"line_number":49,"context_line":"        vnx_common.DEFAULT_TIMEOUT \u003d 0"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_97dc62e5","line":48,"updated":"2016-07-26 20:21:43.000000000","message":"Please, use mock.patch here","commit_id":"3ed1f06f2bc4dd6fbf8e66f372a8f8105d144608"}],"cinder/tests/unit/volume/drivers/emc/vnx/utils.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"73e817b92813edc92a92dbd2bb6537a85c5bf1bd","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"patch_looping_call \u003d mock.patch("},{"line_number":29,"context_line":"    \u0027oslo_service.loopingcall.FixedIntervalLoopingCall\u0027,"},{"line_number":30,"context_line":"    new\u003dutils.ZeroIntervalLoopingCall)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"patch_sleep \u003d mock.patch(\u0027time.sleep\u0027)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_7173b180","line":30,"updated":"2016-07-27 01:59:15.000000000","message":"I have seen other driver unit tests using ZeroIntervalLoopingCall hang with this patch.  For example, test_replication_driver_enable_success in test_huawei_drivers.py.\n\ncinder.tests.unit.volume.drivers.huawei.test_huawei_drivers.HuaweiISCSIDriverTestCase.test_replication_driver_enable_success [] ... inprogress\n\nCan you try mock this out without using ZeroIntervalLoopingCall?\n\npatch_looping_call \u003d mock.patch(\n    \u0027oslo_service.loopingcall.FixedIntervalLoopingCall\u0027)\n\nHere is how I repro the hang on my setup and I can repro easily:\n\n./run_tests.sh --concurrency 4","commit_id":"3ed1f06f2bc4dd6fbf8e66f372a8f8105d144608"}]}