)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"83d26e38053e2c30de794a021c84c3b0f2216417","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Furthermore, in case the same operation broke (eg. because of an DBus"},{"line_number":10,"context_line":"timeout) during an earlier Cinder run, ignore the EEXIST error for the"},{"line_number":11,"context_line":"already restored snapshot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia952812e5a69d343ee7871a379a517ea35bf2a2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ac06dbe_83a8b521","line":11,"updated":"2016-08-23 10:34:00.000000000","message":"-1: Only 1 fix in each patch.","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"6de4d0219722d27f152f632ba53dcae54de57efa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Furthermore, in case the same operation broke (eg. because of an DBus"},{"line_number":10,"context_line":"timeout) during an earlier Cinder run, ignore the EEXIST error for the"},{"line_number":11,"context_line":"already restored snapshot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia952812e5a69d343ee7871a379a517ea35bf2a2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ac06dbe_9932e2a5","line":11,"in_reply_to":"1ac06dbe_83a8b521","updated":"2016-08-23 10:53:17.000000000","message":"I\u0027m sorry ... but are you seriously proposing that for the\ntext \", dm_exc.DM_EEXIST\" a launchpad bug, another cinder patch, more reviewer time etc. is necessary?\n\nWouldn\u0027t that time better be spent on fixing other bugs in the code?","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b52b3356c0e51f1f1487d4dcdba110fa55b5ece7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Furthermore, in case the same operation broke (eg. because of an DBus"},{"line_number":10,"context_line":"timeout) during an earlier Cinder run, ignore the EEXIST error for the"},{"line_number":11,"context_line":"already restored snapshot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia952812e5a69d343ee7871a379a517ea35bf2a2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ac06dbe_ef0b4822","line":11,"in_reply_to":"1ac06dbe_9932e2a5","updated":"2016-08-23 11:31:20.000000000","message":"Well, one of the reasons why I\u0027m asking to split it, is because I\u0027m suggesting an alternative fix for the \"snapshot has vanished\" issue.\n\nAnd you make it look like I\u0027m asking you to run a marathon. Splitting this patch and creating 2 dependent patches instead is what?  30 seconds?","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"83d26e38053e2c30de794a021c84c3b0f2216417","unresolved":false,"context_lines":[{"line_number":10,"context_line":"timeout) during an earlier Cinder run, ignore the EEXIST error for the"},{"line_number":11,"context_line":"already restored snapshot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia952812e5a69d343ee7871a379a517ea35bf2a2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ac06dbe_a337b1fd","line":13,"updated":"2016-08-23 10:34:00.000000000","message":"-1: Missing bug","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b52b3356c0e51f1f1487d4dcdba110fa55b5ece7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"timeout) during an earlier Cinder run, ignore the EEXIST error for the"},{"line_number":11,"context_line":"already restored snapshot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia952812e5a69d343ee7871a379a517ea35bf2a2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ac06dbe_d419c189","line":13,"in_reply_to":"1ac06dbe_19e6f214","updated":"2016-08-23 11:31:20.000000000","message":"Well, as far as I can see that\u0027s not what would happen with current code -as you suggest in the commit summary line-, no error message would be raised because dm_exc.DM_ENOENT is being ignored.\n\nYou call it bureaucracy, I call it procedure, and there are reasons to track bugs, but I\u0027m not getting into a discussion of why they are important.  I give my review, you don\u0027t like it, you can reply that you disagree and you are free to ignore me.  As you can see, you had at least other two cores that were OK with your patch.","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"6de4d0219722d27f152f632ba53dcae54de57efa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"timeout) during an earlier Cinder run, ignore the EEXIST error for the"},{"line_number":11,"context_line":"already restored snapshot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia952812e5a69d343ee7871a379a517ea35bf2a2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1ac06dbe_19e6f214","line":13,"in_reply_to":"1ac06dbe_a337b1fd","updated":"2016-08-23 10:53:17.000000000","message":"And some more bureaucracy...\nThat\u0027s just giving a meaningful error message in case something else broke already.\n\nThat won\u0027t happen in normal circumstances, only if eg. the admin manually messes around.","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"},{"author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"change_message_id":"a173e6d1afe0c70de0be9095c55750fbaa05df9b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DRBD: Report an error if a snapshot has vanished"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Furthermore, in case the same operation broke (eg. because of an DBus"},{"line_number":10,"context_line":"timeout) during an earlier Cinder run, ignore the EEXIST error for the"},{"line_number":11,"context_line":"already restored snapshot."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7a8ec9b2_066202d8","line":9,"range":{"start_line":9,"start_character":62,"end_line":9,"end_character":64},"updated":"2016-09-16 16:44:26.000000000","message":"a","commit_id":"e0fa0b4261d7879558207666f6b90225634b4386"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"88ab5da0e32144754b333ae9e24fb3af6130a5b8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"timeout) during an earlier Cinder run, ignore the EEXIST error for the"},{"line_number":11,"context_line":"already restored snapshot."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia952812e5a69d343ee7871a379a517ea35bf2a2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7a8ec9b2_d8d067cc","line":13,"updated":"2016-09-20 16:01:13.000000000","message":"-1: I still believe this requires a LP bug","commit_id":"4a55dc946130f6ae57e2370b18442726ac8723ec"}],"cinder/volume/drivers/drbdmanagedrv.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"83d26e38053e2c30de794a021c84c3b0f2216417","unresolved":false,"context_lines":[{"line_number":603,"context_line":"                                     sname,"},{"line_number":604,"context_line":"                                     r_props,"},{"line_number":605,"context_line":"                                     v_props)"},{"line_number":606,"context_line":"        res2 \u003d self._check_result(res, ignore\u003d[dm_exc.DM_ENOENT,"},{"line_number":607,"context_line":"                                               dm_exc.DM_EEXIST])"},{"line_number":608,"context_line":"        if res2 \u003d\u003d dm_exc.DM_ENOENT:"},{"line_number":609,"context_line":"            message \u003d (_(\u0027DRBDmanage snapshot %(sn) in %(res) not found\u0027) %"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_56183975","line":606,"updated":"2016-08-23 10:34:00.000000000","message":"?: Wouldn\u0027t this issue be fixed just removing the dm_exc.DM_ENOENT from the ignore list?  Because then the _check_result would raise the exception.","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b52b3356c0e51f1f1487d4dcdba110fa55b5ece7","unresolved":false,"context_lines":[{"line_number":603,"context_line":"                                     sname,"},{"line_number":604,"context_line":"                                     r_props,"},{"line_number":605,"context_line":"                                     v_props)"},{"line_number":606,"context_line":"        res2 \u003d self._check_result(res, ignore\u003d[dm_exc.DM_ENOENT,"},{"line_number":607,"context_line":"                                               dm_exc.DM_EEXIST])"},{"line_number":608,"context_line":"        if res2 \u003d\u003d dm_exc.DM_ENOENT:"},{"line_number":609,"context_line":"            message \u003d (_(\u0027DRBDmanage snapshot %(sn) in %(res) not found\u0027) %"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_8a3282f0","line":606,"in_reply_to":"1ac06dbe_56015905","updated":"2016-08-23 11:31:20.000000000","message":"OK, I see that the message would be \"Object not found\", which is not bad, but certainly not as good as your message.","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"6de4d0219722d27f152f632ba53dcae54de57efa","unresolved":false,"context_lines":[{"line_number":603,"context_line":"                                     sname,"},{"line_number":604,"context_line":"                                     r_props,"},{"line_number":605,"context_line":"                                     v_props)"},{"line_number":606,"context_line":"        res2 \u003d self._check_result(res, ignore\u003d[dm_exc.DM_ENOENT,"},{"line_number":607,"context_line":"                                               dm_exc.DM_EEXIST])"},{"line_number":608,"context_line":"        if res2 \u003d\u003d dm_exc.DM_ENOENT:"},{"line_number":609,"context_line":"            message \u003d (_(\u0027DRBDmanage snapshot %(sn) in %(res) not found\u0027) %"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_56015905","line":606,"in_reply_to":"1ac06dbe_56183975","updated":"2016-08-23 10:53:17.000000000","message":"Yeah, but then the error wouldn\u0027t be that readable any more.","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"83d26e38053e2c30de794a021c84c3b0f2216417","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                                               dm_exc.DM_EEXIST])"},{"line_number":608,"context_line":"        if res2 \u003d\u003d dm_exc.DM_ENOENT:"},{"line_number":609,"context_line":"            message \u003d (_(\u0027DRBDmanage snapshot %(sn) in %(res) not found\u0027) %"},{"line_number":610,"context_line":"                       {\u0027res\u0027: new_res, \u0027sn\u0027: sname})"},{"line_number":611,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmessage)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        self._push_drbd_options(new_res)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_030a0579","line":610,"range":{"start_line":610,"start_character":31,"end_line":610,"end_character":38},"updated":"2016-08-23 10:34:00.000000000","message":"-1: The snapshot is not in new_res, it\u0027s in d_res_name.","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"6de4d0219722d27f152f632ba53dcae54de57efa","unresolved":false,"context_lines":[{"line_number":607,"context_line":"                                               dm_exc.DM_EEXIST])"},{"line_number":608,"context_line":"        if res2 \u003d\u003d dm_exc.DM_ENOENT:"},{"line_number":609,"context_line":"            message \u003d (_(\u0027DRBDmanage snapshot %(sn) in %(res) not found\u0027) %"},{"line_number":610,"context_line":"                       {\u0027res\u0027: new_res, \u0027sn\u0027: sname})"},{"line_number":611,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmessage)"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        self._push_drbd_options(new_res)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_7656152b","line":610,"range":{"start_line":610,"start_character":31,"end_line":610,"end_character":38},"in_reply_to":"1ac06dbe_030a0579","updated":"2016-08-23 10:53:17.000000000","message":"Yeah, thanks. Good catch!","commit_id":"edd319fd6558c36f0d10e707b0ed9fc3f6ddff63"}]}