)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"78107aa269566c5898eba54de3636eb65ac22a15","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use object instead of string when reset backup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now in reset backup status api, the \"backup service\" is a string,"},{"line_number":10,"context_line":"it should be an object."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id86260fffed488ee316f83c179cd948378cfbb73"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_91d7fe22","line":10,"updated":"2016-07-27 14:43:43.000000000","message":"We need a bug report for this patch.","commit_id":"a239af87d88a5c584b9b369800bea799480d0628"}],"cinder/backup/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b96a7f532c56c2b8acb3eb59bf60e0500ea807c6","unresolved":false,"context_lines":[{"line_number":833,"context_line":"                if (status \u003d\u003d fields.BackupStatus.AVAILABLE"},{"line_number":834,"context_line":"                        and backup[\u0027status\u0027] !\u003d fields.BackupStatus.RESTORING):"},{"line_number":835,"context_line":"                    # check whether we could verify the backup is ok or not"},{"line_number":836,"context_line":"                    backup_service \u003d self.service.get_backup_driver(context)"},{"line_number":837,"context_line":"                    if isinstance(backup_service,"},{"line_number":838,"context_line":"                                  driver.BackupDriverWithVerify):"},{"line_number":839,"context_line":"                        backup_service.verify(backup.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_d048528a","line":836,"updated":"2016-08-08 09:53:53.000000000","message":"-1: The solution will work, but I think the backup_service name is creating confusion, and it doesn\u0027t help that we change its value here.  It should be renamed to \"backup_service_name\" or \"service_name\" when it\u0027s a string to differentiate between the actual driver and its name.","commit_id":"3dc9dfcfa0d797af2951a1fd64c7e7bd652028bf"}],"cinder/tests/unit/backup/test_backup.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b96a7f532c56c2b8acb3eb59bf60e0500ea807c6","unresolved":false,"context_lines":[{"line_number":1292,"context_line":"            self.backup_mgr.reset_status(self.ctxt,"},{"line_number":1293,"context_line":"                                         backup,"},{"line_number":1294,"context_line":"                                         fields.BackupStatus.AVAILABLE)"},{"line_number":1295,"context_line":"            self.assertEqual(2, mock_clean_temp.call_count)"},{"line_number":1296,"context_line":"        backup \u003d db.backup_get(self.ctxt, backup.id)"},{"line_number":1297,"context_line":"        self.assertEqual(fields.BackupStatus.AVAILABLE, backup[\u0027status\u0027])"},{"line_number":1298,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_10c78a46","line":1295,"updated":"2016-08-08 09:53:53.000000000","message":"nit: It\u0027s always better to reset the mock between tests and then do the check with assert_called_once_with.","commit_id":"3dc9dfcfa0d797af2951a1fd64c7e7bd652028bf"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"39bc8f89dcb1b7279abc70a7386f2d03e24dff9d","unresolved":false,"context_lines":[{"line_number":1282,"context_line":"            self.backup_mgr.reset_status(self.ctxt,"},{"line_number":1283,"context_line":"                                         backup,"},{"line_number":1284,"context_line":"                                         fields.BackupStatus.AVAILABLE)"},{"line_number":1285,"context_line":"            mock_clean_temp.assert_called_once_with(self.ctxt, backup)"},{"line_number":1286,"context_line":"            mock_clean_temp.reset_mock()"},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"            mock_map_service_to_driver.return_value \u003d \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_9d218650","line":1285,"updated":"2016-08-09 14:06:34.000000000","message":"nit: We need to assert that the new status is available.","commit_id":"baf527c0f29dc550006bc3b71905ce64baaa6b8d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"39bc8f89dcb1b7279abc70a7386f2d03e24dff9d","unresolved":false,"context_lines":[{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"            mock_map_service_to_driver.return_value \u003d \\"},{"line_number":1289,"context_line":"                fake_service.get_backup_driver(self.ctxt)"},{"line_number":1290,"context_line":"            self.backup_mgr.reset_status(self.ctxt,"},{"line_number":1291,"context_line":"                                         backup,"},{"line_number":1292,"context_line":"                                         fields.BackupStatus.AVAILABLE)"},{"line_number":1293,"context_line":"            mock_clean_temp.assert_called_once_with(self.ctxt, backup)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_fdbd22d8","line":1290,"updated":"2016-08-09 14:06:34.000000000","message":"We should set the backup status to ERROR before calling reset_status.","commit_id":"baf527c0f29dc550006bc3b71905ce64baaa6b8d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"af8d40a2fd16ea9777ae80976e6d31dfc43935d7","unresolved":false,"context_lines":[{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"            mock_map_service_to_driver.return_value \u003d \\"},{"line_number":1291,"context_line":"                fake_service.get_backup_driver(self.ctxt)"},{"line_number":1292,"context_line":"            self.backup_mgr.reset_status(self.ctxt,"},{"line_number":1293,"context_line":"                                         backup,"},{"line_number":1294,"context_line":"                                         fields.BackupStatus.ERROR)"},{"line_number":1295,"context_line":"            mock_clean_temp.reset_mock()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_776be0f1","line":1292,"updated":"2016-08-10 09:51:01.000000000","message":"nit: I think we should create a new backup with status\u003derror instead of using reset_status to \"error\" because this test is for verifying reset_status to \"available\".","commit_id":"855a0c334c845e53d7d54a0042baabcd1fc95143"}]}