)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"abc434977b988010cf142df75ede266091429a08","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# vdi, vmdk and vhd disk-formats but glance doesn\u0027t support qed"},{"line_number":60,"context_line":"# disk-format."},{"line_number":61,"context_line":"# Ref: http://docs.openstack.org/image-guide/convert-images.html"},{"line_number":62,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027, \u0027vhd\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def validate_disk_format(disk_format):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_4ed9dc56","line":62,"updated":"2016-08-04 16:13:20.000000000","message":"I was not aware of this list of \u0027valid_disk_formats\u0027, which was recently introduced. Could you please add the \u0027vhdx\u0027 format, while at it?\n\nNote that the list of supported formats from glance is configurable.","commit_id":"973e11eb77c4f50c02a784ffce1d0041240e2179"},{"author":{"_account_id":22025,"name":"James Conroy","email":"jayryanconroy@gmail.com","username":"jayconroy"},"change_message_id":"d6653d25db1bdc49e8518f20f285fbb611813a77","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# vdi, vmdk and vhd disk-formats but glance doesn\u0027t support qed"},{"line_number":60,"context_line":"# disk-format."},{"line_number":61,"context_line":"# Ref: http://docs.openstack.org/image-guide/convert-images.html"},{"line_number":62,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027, \u0027vhd\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def validate_disk_format(disk_format):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_45cfd97e","line":62,"in_reply_to":"bacf61ea_4ed9dc56","updated":"2016-08-05 08:31:12.000000000","message":"Done","commit_id":"973e11eb77c4f50c02a784ffce1d0041240e2179"},{"author":{"_account_id":22025,"name":"James Conroy","email":"jayryanconroy@gmail.com","username":"jayconroy"},"change_message_id":"b66f5e5038b4b29fd1f0147abaeb32713d5e2873","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# vdi, vmdk and vhd disk-formats but glance doesn\u0027t support qed"},{"line_number":60,"context_line":"# disk-format."},{"line_number":61,"context_line":"# Ref: http://docs.openstack.org/image-guide/convert-images.html"},{"line_number":62,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027, \u0027vhd\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def validate_disk_format(disk_format):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_e421cf4e","line":62,"in_reply_to":"bacf61ea_4ed9dc56","updated":"2016-08-04 16:48:47.000000000","message":"Hi Lucian, vhdx is not supported by qemu-img which is why I have not added it here. http://docs.openstack.org/image-guide/convert-images.html#qemu-img-convert-raw-qcow2-qed-vdi-vmdk-vhd","commit_id":"973e11eb77c4f50c02a784ffce1d0041240e2179"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"ce080900b280a729da64edd327b166749e55dc5f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# vdi, vmdk and vhd disk-formats but glance doesn\u0027t support qed"},{"line_number":60,"context_line":"# disk-format."},{"line_number":61,"context_line":"# Ref: http://docs.openstack.org/image-guide/convert-images.html"},{"line_number":62,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027, \u0027vhd\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def validate_disk_format(disk_format):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_ea119953","line":62,"in_reply_to":"bacf61ea_e421cf4e","updated":"2016-08-04 17:00:43.000000000","message":"Sure it is. That page seems a bit outdated. qemu-img supports vhdx images since quite a while (even before 1.7).\n\nAs of 2.2.1, this is the list of supported formats:\nvvfat vhdx vdi vmdk host_cdrom sheepdog blkdebug host_floppy host_device file blkverify null-aio null-co qcow raw vpc qcow2 qed bochs cloop parallels dmg nbd","commit_id":"973e11eb77c4f50c02a784ffce1d0041240e2179"},{"author":{"_account_id":22025,"name":"James Conroy","email":"jayryanconroy@gmail.com","username":"jayconroy"},"change_message_id":"d6653d25db1bdc49e8518f20f285fbb611813a77","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# vdi, vmdk and vhd disk-formats but glance doesn\u0027t support qed"},{"line_number":60,"context_line":"# disk-format."},{"line_number":61,"context_line":"# Ref: http://docs.openstack.org/image-guide/convert-images.html"},{"line_number":62,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027, \u0027vhd\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def validate_disk_format(disk_format):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_ea369c4f","line":62,"in_reply_to":"bacf61ea_ea119953","updated":"2016-08-05 08:31:12.000000000","message":"My apologies, I\u0027m mistaken. Added vhdx to valid disk formats.","commit_id":"973e11eb77c4f50c02a784ffce1d0041240e2179"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"8f290d9e596944481dc165d000ec812701b6ebc6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"# vdi, vmdk and vhd disk-formats but glance doesn\u0027t support qed"},{"line_number":60,"context_line":"# disk-format."},{"line_number":61,"context_line":"# Ref: http://docs.openstack.org/image-guide/convert-images.html"},{"line_number":62,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027, \u0027vhd\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def validate_disk_format(disk_format):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_1a96d7ef","line":62,"in_reply_to":"bacf61ea_ea369c4f","updated":"2016-08-05 10:29:40.000000000","message":"No worries, thank you for updating this change!","commit_id":"973e11eb77c4f50c02a784ffce1d0041240e2179"}],"cinder/tests/unit/api/contrib/test_volume_actions.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c3987dee30b0eaea6f96e6226354caaf9195803a","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        self.assertDictMatch(expected, res_dict)"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    def test_copy_volume_to_image_vhd(self):"},{"line_number":883,"context_line":"        self.stubs.Set(volume_api.API,"},{"line_number":884,"context_line":"                       \"copy_volume_to_image\","},{"line_number":885,"context_line":"                       stub_upload_volume_to_image_service_vhd)"},{"line_number":886,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b1cac99f","line":883,"updated":"2016-07-28 13:24:10.000000000","message":"We shouldn\u0027t use mox for new tests, use self.mock_object instead.","commit_id":"58c3d01acb8cc96bb692de7d6080282f2d600d6e"},{"author":{"_account_id":22025,"name":"James Conroy","email":"jayryanconroy@gmail.com","username":"jayconroy"},"change_message_id":"82a997f4ed7353c534c863dcadbd6fce4979709e","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        self.assertDictMatch(expected, res_dict)"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    def test_copy_volume_to_image_vhd(self):"},{"line_number":883,"context_line":"        self.stubs.Set(volume_api.API,"},{"line_number":884,"context_line":"                       \"copy_volume_to_image\","},{"line_number":885,"context_line":"                       stub_upload_volume_to_image_service_vhd)"},{"line_number":886,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3eb788d9","line":883,"in_reply_to":"bacf61ea_b1cac99f","updated":"2016-07-29 13:56:39.000000000","message":"Done","commit_id":"58c3d01acb8cc96bb692de7d6080282f2d600d6e"}]}