)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7f4ee084fdc734a456b4986ad3ac7dbed287e665","unresolved":false,"context_lines":[{"line_number":13,"context_line":"stores all drivers actions in a list."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Now, we can add real logging to FakeLoggingVolumeDriver and use it both"},{"line_number":16,"context_line":"for unit and funcitonal tests."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"It\u0027s a first patch in a series for unit tests refactoring. More manager"},{"line_number":19,"context_line":"and LVM driver tests will be proposed in a following patches."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3ac371cc_18c0557c","line":16,"updated":"2016-08-18 18:06:34.000000000","message":"nit: s/funcitonal/functional","commit_id":"037e7b3465309d6c7956c857177a83b856da4241"}],"cinder/tests/fake_driver.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"ae95ea101390bbbb75a1bed9d98380d9927ea701","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        pass"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def _update_volume_stats(self):"},{"line_number":106,"context_line":"        data \u003d {}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        data[\"volume_backend_name\"] \u003d self.backend_name"},{"line_number":109,"context_line":"        data[\"vendor_name\"] \u003d \u0027Open Source\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_04edb9b6","line":106,"range":{"start_line":106,"start_character":15,"end_line":106,"end_character":17},"updated":"2016-08-18 09:45:58.000000000","message":"Why not just:\ndata \u003d {\n\"volume_backend_name\": self.backend_name,\n\"vendor_name\": \"Open Source\",\n.......,\n\"pools\": []\n}","commit_id":"a3c2eccfea3a29168509f7d6741a7552f926e04f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7f4ee084fdc734a456b4986ad3ac7dbed287e665","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                     \u0027filter_function\u0027: self.get_filter_function(),"},{"line_number":119,"context_line":"                     \u0027goodness_function\u0027: self.get_goodness_function(),"},{"line_number":120,"context_line":"                     \u0027consistencygroup_support\u0027: True,"},{"line_number":121,"context_line":"                     \u0027replication_enabled\u0027: True}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        data[\u0027pools\u0027].append(fake_pool)"},{"line_number":124,"context_line":"        self._stats \u003d data"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_d8b7ddf3","line":121,"updated":"2016-08-18 18:06:34.000000000","message":"You set consistencygroup_support and replication_enabled to True, but this driver didn\u0027t implement any of them.","commit_id":"037e7b3465309d6c7956c857177a83b856da4241"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"6e1befb96edc1d67fb0b19d30ed863c36277e549","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                     \u0027filter_function\u0027: self.get_filter_function(),"},{"line_number":119,"context_line":"                     \u0027goodness_function\u0027: self.get_goodness_function(),"},{"line_number":120,"context_line":"                     \u0027consistencygroup_support\u0027: True,"},{"line_number":121,"context_line":"                     \u0027replication_enabled\u0027: True}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        data[\u0027pools\u0027].append(fake_pool)"},{"line_number":124,"context_line":"        self._stats \u003d data"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_61b55130","line":121,"in_reply_to":"3ac371cc_d8b7ddf3","updated":"2016-08-18 19:48:25.000000000","message":"Thanks, I\u0027ll fix it","commit_id":"037e7b3465309d6c7956c857177a83b856da4241"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7f4ee084fdc734a456b4986ad3ac7dbed287e665","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            }}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class FakeGateDriver(lvm.LVMVolumeDriver):"},{"line_number":181,"context_line":"    \"\"\"Class designation for FakeGateDriver."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    FakeGateDriver is for TESTING ONLY. There are a few"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_f880d9f9","line":180,"updated":"2016-08-18 18:06:34.000000000","message":"Are you planning to change this one as well?  Now both inherit from lvm.LVMVolumeDriver, it is not clear to me what will be differences between them.","commit_id":"037e7b3465309d6c7956c857177a83b856da4241"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"6e1befb96edc1d67fb0b19d30ed863c36277e549","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            }}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"class FakeGateDriver(lvm.LVMVolumeDriver):"},{"line_number":181,"context_line":"    \"\"\"Class designation for FakeGateDriver."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    FakeGateDriver is for TESTING ONLY. There are a few"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_e1f661f8","line":180,"in_reply_to":"3ac371cc_f880d9f9","updated":"2016-08-18 19:48:25.000000000","message":"Good point. I need to add one more TODO to inherit from driver.VolumeDriver","commit_id":"037e7b3465309d6c7956c857177a83b856da4241"}]}