)]}'
{"cinder/api/contrib/qos_specs_manage.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"72653b531070781921eeb4ceb4dac547c5d1163b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assert_valid_body(body, \u0027qos_specs\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        specs \u003d body[\u0027qos_specs\u0027]"},{"line_number":83,"context_line":"        name \u003d specs.get(\u0027name\u0027, None)"},{"line_number":84,"context_line":"        if name is None:"},{"line_number":85,"context_line":"            msg \u003d _(\"Please specify a name for QoS specs.\")"},{"line_number":86,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4ecdee64","line":83,"range":{"start_line":83,"start_character":33,"end_line":83,"end_character":37},"updated":"2016-08-02 10:42:55.000000000","message":"Why not just put name \u003d specs.pop(\u0027name\u0027) and then line 92 is rebundant?","commit_id":"4c8e8af3ab7f4b0946779ab4d1d8b1a3ae59edc9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"425c23ed27cb6213b8158182ecbf0208064d6900","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assert_valid_body(body, \u0027qos_specs\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        specs \u003d body[\u0027qos_specs\u0027]"},{"line_number":83,"context_line":"        name \u003d specs.get(\u0027name\u0027, None)"},{"line_number":84,"context_line":"        if name is None:"},{"line_number":85,"context_line":"            msg \u003d _(\"Please specify a name for QoS specs.\")"},{"line_number":86,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_8f64a122","line":83,"range":{"start_line":83,"start_character":33,"end_line":83,"end_character":37},"in_reply_to":"bacf61ea_4ecdee64","updated":"2016-08-22 10:26:51.000000000","message":"It would have to be specs.pop(\u0027name\u0027, None), otherwise it woul raise KeyError when \u0027name\u0027 is not present.  But I agree it would look better.","commit_id":"4c8e8af3ab7f4b0946779ab4d1d8b1a3ae59edc9"}]}