)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"3538666a798cc8d185b3e543c369d2b60ae50e11","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                header[\u0027Authorization\u0027] \u003d \u0027Basic %s\u0027 % auth_key"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            LOG.debug(_(\"Payload for SolidFire API call: %s\"), payload)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            connection \u003d httplib.HTTPSConnection(host, port)"},{"line_number":141,"context_line":"            connection.request(\u0027POST\u0027, \u0027/json-rpc/1.0\u0027, payload, header)"},{"line_number":142,"context_line":"            response \u003d connection.getresponse()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fb04%3D","line":139,"updated":"2013-07-02 00:31:38.000000000","message":"Should this error be handled around here to avoid code change in multiple places?","commit_id":"d596bfe6562307343858f419062756640000b0c8"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"402c6535c84871a51e34b7dae23a9f21cc851e11","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                header[\u0027Authorization\u0027] \u003d \u0027Basic %s\u0027 % auth_key"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            LOG.debug(_(\"Payload for SolidFire API call: %s\"), payload)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            connection \u003d httplib.HTTPSConnection(host, port)"},{"line_number":141,"context_line":"            connection.request(\u0027POST\u0027, \u0027/json-rpc/1.0\u0027, payload, header)"},{"line_number":142,"context_line":"            response \u003d connection.getresponse()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fbqk%3D","line":139,"in_reply_to":"AAAAPn%2F%2Fb04%3D","updated":"2013-07-02 03:24:37.000000000","message":"Suppose that\u0027s not a bad idea, except I\u0027d still need to add an except/catch in the callers and return, unless there\u0027s a better way that I\u0027m missing here?  The trick is to bale out of the call that fails in the appropriate place without killing the volume-service/having an unhandled exception.","commit_id":"d596bfe6562307343858f419062756640000b0c8"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"1c8d496ff19358f53acab0940e5f6867bda09ab9","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                header[\u0027Authorization\u0027] \u003d \u0027Basic %s\u0027 % auth_key"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            LOG.debug(_(\"Payload for SolidFire API call: %s\"), payload)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"            connection \u003d httplib.HTTPSConnection(host, port)"},{"line_number":141,"context_line":"            connection.request(\u0027POST\u0027, \u0027/json-rpc/1.0\u0027, payload, header)"},{"line_number":142,"context_line":"            response \u003d connection.getresponse()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FbhU%3D","line":139,"in_reply_to":"AAAAPn%2F%2Fbqk%3D","updated":"2013-07-02 05:51:09.000000000","message":"OK. I was wrong about catching exception inside _issue_api_request() since I thought that was the source of all kinds of exceptions.  It turned out only the callers of_update_cluster_status() don\u0027t actually catch exception anywhere.  Others are all taken care of in volume manager.  I agree don\u0027t touch issue_api_request().","commit_id":"d596bfe6562307343858f419062756640000b0c8"}]}