)]}'
{"cinder/tests/test_brick_initiator.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4ccd37aad568b1c1d4124fdad4103f27b44eadbd","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            }"},{"line_number":249,"context_line":"        }"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @test.testtools.skipUnless(os.path.exists(\u0027/dev/disk/by-path\u0027),"},{"line_number":252,"context_line":"                               \u0027Test requires /dev/disk/by-path\u0027)"},{"line_number":253,"context_line":"    def test_connect_volume(self):"},{"line_number":254,"context_line":"        self.stubs.Set(os.path, \u0027exists\u0027, lambda x: True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FdR4%3D","line":251,"updated":"2013-07-01 15:24:38.000000000","message":"Are there other reasons this path might not exist yet?  (i.e. nothing is using it?)\n\nWondering if this should be checked inside the test to make sure we don\u0027t skip it too often.","commit_id":"dec8fb779253b62bd86b1d198ee89b22f19ab3e1"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"fb8781de2723b34f5b5f99906e913fc11e07f6da","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            }"},{"line_number":249,"context_line":"        }"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @test.testtools.skipUnless(os.path.exists(\u0027/dev/disk/by-path\u0027),"},{"line_number":252,"context_line":"                               \u0027Test requires /dev/disk/by-path\u0027)"},{"line_number":253,"context_line":"    def test_connect_volume(self):"},{"line_number":254,"context_line":"        self.stubs.Set(os.path, \u0027exists\u0027, lambda x: True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FbAs%3D","line":251,"in_reply_to":"AAAAPn%2F%2FbDc%3D","updated":"2013-07-02 10:21:36.000000000","message":"Can we test for the condition of virtio devices as well?  Basically, now we know that this code (and I guess the Nova code too) doesn\u0027t work in virtio environments.  This should be documented.  Maybe there are other environments where it won\u0027t work?  If the unit test skips all cases where the path doesn\u0027t exist, we might wait until deployment time rather than unit test time to find out about the issue.","commit_id":"dec8fb779253b62bd86b1d198ee89b22f19ab3e1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bba2185228af7f7d6d69cb6912c7557e09bfc04c","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            }"},{"line_number":249,"context_line":"        }"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @test.testtools.skipUnless(os.path.exists(\u0027/dev/disk/by-path\u0027),"},{"line_number":252,"context_line":"                               \u0027Test requires /dev/disk/by-path\u0027)"},{"line_number":253,"context_line":"    def test_connect_volume(self):"},{"line_number":254,"context_line":"        self.stubs.Set(os.path, \u0027exists\u0027, lambda x: True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FbDc%3D","line":251,"in_reply_to":"AAAAPn%2F%2FbVU%3D","updated":"2013-07-02 10:01:12.000000000","message":"Makes sense, I was just missing some of the detail there.","commit_id":"dec8fb779253b62bd86b1d198ee89b22f19ab3e1"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"7fd3ec07bf9fc68ab573d97953e27d1f8076eb6d","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            }"},{"line_number":249,"context_line":"        }"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    @test.testtools.skipUnless(os.path.exists(\u0027/dev/disk/by-path\u0027),"},{"line_number":252,"context_line":"                               \u0027Test requires /dev/disk/by-path\u0027)"},{"line_number":253,"context_line":"    def test_connect_volume(self):"},{"line_number":254,"context_line":"        self.stubs.Set(os.path, \u0027exists\u0027, lambda x: True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FbVU%3D","line":251,"in_reply_to":"AAAAPn%2F%2FdR4%3D","updated":"2013-07-02 07:17:56.000000000","message":"its not about \"yet\", it will never exist at any point in time if there are only virtio devices. I do not see anything in this test that I can execute if by-path does not exist. which test do you want to run nevertheless?","commit_id":"dec8fb779253b62bd86b1d198ee89b22f19ab3e1"}]}