)]}'
{"cinder/backup/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9719bffa5bb89682f1336c36bfca6f6f9b4e76a5","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    def _get_available_backup_service_host(self, host, az, volume_host\u003dNone):"},{"line_number":177,"context_line":"        \"\"\"Return an appropriate backup service host.\"\"\""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # FIXME(dulek): We need to keep compatibility with Liberty, where c-bak"},{"line_number":180,"context_line":"        # were coupled with c-vol. If we\u0027re running in mixed Liberty-Mitaka"},{"line_number":181,"context_line":"        # environment we will be scheduling backup jobs the old way."},{"line_number":182,"context_line":"        #"},{"line_number":183,"context_line":"        # This snippet should go away in Newton. Note that volume_host"},{"line_number":184,"context_line":"        # parameter will also be unnecessary then."},{"line_number":185,"context_line":"        backup_host \u003d None"},{"line_number":186,"context_line":"        if (not host or not CONF.backup_use_same_host):"},{"line_number":187,"context_line":"            backup_host \u003d self._get_any_available_backup_service(az)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e1f9dec9","line":184,"range":{"start_line":179,"start_character":1,"end_line":184,"end_character":50},"updated":"2016-08-04 08:18:41.000000000","message":"-1: If it\u0027s already fixed we should remove FIXME comment.","commit_id":"a8e8b0bf4bab8160b1c324bb180909964f1bf344"}],"cinder/objects/service.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9719bffa5bb89682f1336c36bfca6f6f9b4e76a5","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                # NOTE(dulek) None in *_current_version means that this"},{"line_number":168,"context_line":"                # service is in Liberty version, which we now don\u0027t provide"},{"line_number":169,"context_line":"                # backward compatibility to."},{"line_number":170,"context_line":"                msg \u003d _(\u0027One of the services is in Liberty version. We do not \u0027"},{"line_number":171,"context_line":"                        \u0027provide backward compatibility with Liberty now, you \u0027"},{"line_number":172,"context_line":"                        \u0027need to upgrade to Mitaka first.\u0027)"},{"line_number":173,"context_line":"                raise exception.ServiceTooOld(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_01f87248","line":170,"updated":"2016-08-04 08:18:41.000000000","message":"?: Are we going to have to update this on every release to prevent running against N-2 or older?","commit_id":"a8e8b0bf4bab8160b1c324bb180909964f1bf344"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8dbd90a8002e570cd6f45012402b1fb6a031ff8b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                # NOTE(dulek) None in *_current_version means that this"},{"line_number":168,"context_line":"                # service is in Liberty version, which we now don\u0027t provide"},{"line_number":169,"context_line":"                # backward compatibility to."},{"line_number":170,"context_line":"                msg \u003d _(\u0027One of the services is in Liberty version. We do not \u0027"},{"line_number":171,"context_line":"                        \u0027provide backward compatibility with Liberty now, you \u0027"},{"line_number":172,"context_line":"                        \u0027need to upgrade to Mitaka first.\u0027)"},{"line_number":173,"context_line":"                raise exception.ServiceTooOld(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_868e08ce","line":170,"in_reply_to":"1ac06dbe_4c1f4a5f","updated":"2016-08-23 09:26:32.000000000","message":"I think we can solve this with a mapping of release names to versions (objects and RPC) and a method that tells you how many releases have passed from a given version until current version.\n\nIt shouldn\u0027t be too hard, and although we would need to add an entry on every release it would be useful to know which version was the last on each release.","commit_id":"a8e8b0bf4bab8160b1c324bb180909964f1bf344"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"dedb636e98dcd1820032de0ca5e32e388635110d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                # NOTE(dulek) None in *_current_version means that this"},{"line_number":168,"context_line":"                # service is in Liberty version, which we now don\u0027t provide"},{"line_number":169,"context_line":"                # backward compatibility to."},{"line_number":170,"context_line":"                msg \u003d _(\u0027One of the services is in Liberty version. We do not \u0027"},{"line_number":171,"context_line":"                        \u0027provide backward compatibility with Liberty now, you \u0027"},{"line_number":172,"context_line":"                        \u0027need to upgrade to Mitaka first.\u0027)"},{"line_number":173,"context_line":"                raise exception.ServiceTooOld(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_8a53a2e1","line":170,"in_reply_to":"1ac06dbe_868e08ce","updated":"2016-08-23 11:33:10.000000000","message":"Good point, but this can be material for another commit.","commit_id":"a8e8b0bf4bab8160b1c324bb180909964f1bf344"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"de38f043909c46c2a27c5d284bd817c58847fde5","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                # NOTE(dulek) None in *_current_version means that this"},{"line_number":168,"context_line":"                # service is in Liberty version, which we now don\u0027t provide"},{"line_number":169,"context_line":"                # backward compatibility to."},{"line_number":170,"context_line":"                msg \u003d _(\u0027One of the services is in Liberty version. We do not \u0027"},{"line_number":171,"context_line":"                        \u0027provide backward compatibility with Liberty now, you \u0027"},{"line_number":172,"context_line":"                        \u0027need to upgrade to Mitaka first.\u0027)"},{"line_number":173,"context_line":"                raise exception.ServiceTooOld(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_e9d98323","line":170,"in_reply_to":"1ac06dbe_8a53a2e1","updated":"2016-08-23 12:04:39.000000000","message":"Absolutely!!  This patch already LGTM.","commit_id":"a8e8b0bf4bab8160b1c324bb180909964f1bf344"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ca3aa385a36d9ae1bf9ca8a2cd0e2db34890de04","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                # NOTE(dulek) None in *_current_version means that this"},{"line_number":168,"context_line":"                # service is in Liberty version, which we now don\u0027t provide"},{"line_number":169,"context_line":"                # backward compatibility to."},{"line_number":170,"context_line":"                msg \u003d _(\u0027One of the services is in Liberty version. We do not \u0027"},{"line_number":171,"context_line":"                        \u0027provide backward compatibility with Liberty now, you \u0027"},{"line_number":172,"context_line":"                        \u0027need to upgrade to Mitaka first.\u0027)"},{"line_number":173,"context_line":"                raise exception.ServiceTooOld(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_4c1f4a5f","line":170,"in_reply_to":"bacf61ea_01f87248","updated":"2016-08-22 13:16:58.000000000","message":"Good point! Liberty and it\u0027s \"None\" is a special case. In other cases when we have version numbers here - we may decide not to bump major RPC version for a release in the future (for example if nothing changed in the RPC API), so I don\u0027t see a clear way to automate such check. I see these lines only as a safety check.","commit_id":"a8e8b0bf4bab8160b1c324bb180909964f1bf344"}]}