)]}'
{"cinder/objects/service.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cbb9013b74850c3b140692c11523832cc863a9a9","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            # NOTE(dulek): When returning an object from an RPC call we will"},{"line_number":192,"context_line":"            # need to consider all the services as we don\u0027t really know who"},{"line_number":193,"context_line":"            # called us."},{"line_number":194,"context_line":"            services \u003d ServiceList.get_all(context)"},{"line_number":195,"context_line":"        return cls._get_minimum_version(\u0027object_current_version\u0027, context,"},{"line_number":196,"context_line":"                                        services)"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4129ca88","line":194,"updated":"2016-08-04 08:06:35.000000000","message":"-1: We don\u0027t need to do this, if you leave everything as it was and only change L187 to accept binary as optional defaulting to None it will work as we want getting all services when get_minimum_obj_version is called without the binary parameter.","commit_id":"ce3be1eaacc9f70dea06d0692aabb5e4656b31f9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cba8e1307462d670a29ac516db985a9765ef6cab","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @classmethod"},{"line_number":187,"context_line":"    def get_minimum_obj_version(cls, context, binary\u003dNone):"},{"line_number":188,"context_line":"        services \u003d ServiceList.get_all_by_binary(context, binary)"},{"line_number":189,"context_line":"        return cls._get_minimum_version(\u0027object_current_version\u0027, context,"},{"line_number":190,"context_line":"                                        services)"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_80ddac72","line":188,"updated":"2016-08-25 09:17:01.000000000","message":"-1: We don\u0027t need to move this out of _get_minimum_version, since we are making binary default to None, it will just work.  All the change that is really needed in this file is the one done in get_minimum_obj_version\u0027s binary argument:\n\n def get_minimum_obj_version(cls, context, binary\u003dNone):","commit_id":"31c1d4a6dc296d94e82f87b926a4807e1bf0a8fb"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ebb9256bdb2fdd6f93778ef7f71c4bf955d877a2","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @classmethod"},{"line_number":187,"context_line":"    def get_minimum_obj_version(cls, context, binary\u003dNone):"},{"line_number":188,"context_line":"        services \u003d ServiceList.get_all_by_binary(context, binary)"},{"line_number":189,"context_line":"        return cls._get_minimum_version(\u0027object_current_version\u0027, context,"},{"line_number":190,"context_line":"                                        services)"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_205dd879","line":188,"in_reply_to":"1ac06dbe_80ddac72","updated":"2016-08-25 09:42:23.000000000","message":"Oh, you\u0027re right.","commit_id":"31c1d4a6dc296d94e82f87b926a4807e1bf0a8fb"}],"cinder/service.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cbb9013b74850c3b140692c11523832cc863a9a9","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def reset(self):"},{"line_number":484,"context_line":"        self.manager.reset()"},{"line_number":485,"context_line":"        self.obj_version_cap \u003d self._get_obj_version_cap()"},{"line_number":486,"context_line":"        super(Service, self).reset()"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e14b9e29","line":485,"updated":"2016-08-04 08:06:35.000000000","message":"-1: If we do it this way our serializer (L247 \u0026 L258) will not be updated and will keep using the old cap.","commit_id":"ce3be1eaacc9f70dea06d0692aabb5e4656b31f9"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"caea60d6c0217983a7953b7a7724e0a2e41f193f","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def reset(self):"},{"line_number":484,"context_line":"        self.manager.reset()"},{"line_number":485,"context_line":"        self.obj_version_cap \u003d self._get_obj_version_cap()"},{"line_number":486,"context_line":"        super(Service, self).reset()"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_15041316","line":485,"in_reply_to":"bacf61ea_e14b9e29","updated":"2016-08-04 15:42:21.000000000","message":"I\u0027ve tested that and it is updated. On SIGHUP every RPC server is killed and new threads are started. Am I wrong here? I\u0027ll add a comment to clarify that.","commit_id":"ce3be1eaacc9f70dea06d0692aabb5e4656b31f9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cba8e1307462d670a29ac516db985a9765ef6cab","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        self.manager.reset()"},{"line_number":487,"context_line":"        # NOTE(dulek): We just need to update that, as whole service will be"},{"line_number":488,"context_line":"        # restarted and start() will be called again with new serializer being"},{"line_number":489,"context_line":"        # created."},{"line_number":490,"context_line":"        self.obj_version_cap \u003d self._get_obj_version_cap()"},{"line_number":491,"context_line":"        super(Service, self).reset()"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_05954ee3","line":489,"updated":"2016-08-25 09:17:01.000000000","message":"-1: Then why don\u0027t we just assign obj_vesion_cap in the start method and then we don\u0027t need to do it in __init__ and reset?","commit_id":"31c1d4a6dc296d94e82f87b926a4807e1bf0a8fb"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ebb9256bdb2fdd6f93778ef7f71c4bf955d877a2","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        self.manager.reset()"},{"line_number":487,"context_line":"        # NOTE(dulek): We just need to update that, as whole service will be"},{"line_number":488,"context_line":"        # restarted and start() will be called again with new serializer being"},{"line_number":489,"context_line":"        # created."},{"line_number":490,"context_line":"        self.obj_version_cap \u003d self._get_obj_version_cap()"},{"line_number":491,"context_line":"        super(Service, self).reset()"},{"line_number":492,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_406d7403","line":489,"in_reply_to":"1ac06dbe_05954ee3","updated":"2016-08-25 09:42:23.000000000","message":"Good point.","commit_id":"31c1d4a6dc296d94e82f87b926a4807e1bf0a8fb"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1ee01a9047d6d50e4390c8248caee493ed54fc53","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        setup_profiler(binary, host)"},{"line_number":207,"context_line":"        self.rpcserver \u003d None"},{"line_number":208,"context_line":"        self.cluster_rpcserver \u003d None"},{"line_number":209,"context_line":"        self.obj_version_cap \u003d None"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    # TODO(geguileo): Remove method in O since it will no longer be used."},{"line_number":212,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_9e7ce421","line":209,"updated":"2016-08-25 11:04:16.000000000","message":"?: We don\u0027t really need this, and since I\u0027m sure you know it, I\u0027m assuming you are doing it so it\u0027s easier to see that \"somewhere\" in the class we are giving this attribute the value.  Seems like a good idea.  :-)","commit_id":"61532ce2cb6feff624098b58e102de376dd0f990"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d536958426432ec0e925f86e19ac4b88a4898a3b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        setup_profiler(binary, host)"},{"line_number":207,"context_line":"        self.rpcserver \u003d None"},{"line_number":208,"context_line":"        self.cluster_rpcserver \u003d None"},{"line_number":209,"context_line":"        self.obj_version_cap \u003d None"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    # TODO(geguileo): Remove method in O since it will no longer be used."},{"line_number":212,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_59356644","line":209,"in_reply_to":"1ac06dbe_9e7ce421","updated":"2016-08-25 11:25:17.000000000","message":"I think there\u0027s a convention that class properties should be defined in __init__. But we don\u0027t really need that as Service property, so nevermind, next patch on the way.","commit_id":"61532ce2cb6feff624098b58e102de376dd0f990"}]}