)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"28221513a646004d74a3e07cb9f49a61c8f1c99e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Naga Venkata \u003cnaga.b@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-04 13:00:53 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for cinder backup with customized ceph cluster name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current RBD driver assumes ceph cluster name to be \u0027ceph\u0027, for"},{"line_number":10,"context_line":"cluster has a different name, the backup manager won\u0027t be able"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_47071a81","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":64},"updated":"2016-08-04 08:52:56.000000000","message":"The above line should be \u003c\u003d50 char.","commit_id":"8a40fc3e10e62ce40d4bbbb4cf1421d61e8a9048"},{"author":{"_account_id":20585,"name":"Naga Venkata","email":"naga.b@hpe.com","username":"naga"},"change_message_id":"d48214234ad0809d161c7e88e8ca3ab5c0dd108c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Naga Venkata \u003cnaga.b@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-04 13:00:53 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for cinder backup with customized ceph cluster name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current RBD driver assumes ceph cluster name to be \u0027ceph\u0027, for"},{"line_number":10,"context_line":"cluster has a different name, the backup manager won\u0027t be able"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_67633e1b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":64},"in_reply_to":"bacf61ea_47071a81","updated":"2016-08-04 10:41:38.000000000","message":"i will update, thanks","commit_id":"8a40fc3e10e62ce40d4bbbb4cf1421d61e8a9048"},{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"28221513a646004d74a3e07cb9f49a61c8f1c99e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for cinder backup with customized ceph cluster name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current RBD driver assumes ceph cluster name to be \u0027ceph\u0027, for"},{"line_number":10,"context_line":"cluster has a different name, the backup manager won\u0027t be able"},{"line_number":11,"context_line":"to connect to the ceph cluster.  This change adds new entry"},{"line_number":12,"context_line":"\u0027conffile\u0027 to data dictionary  in initialize_connection method"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_c73aea33","line":9,"range":{"start_line":9,"start_character":59,"end_line":9,"end_character":62},"updated":"2016-08-04 08:52:56.000000000","message":"is it cinder\u0027s rbd driver or cinder\u0027s backup RBD driver?","commit_id":"8a40fc3e10e62ce40d4bbbb4cf1421d61e8a9048"},{"author":{"_account_id":20585,"name":"Naga Venkata","email":"naga.b@hpe.com","username":"naga"},"change_message_id":"d48214234ad0809d161c7e88e8ca3ab5c0dd108c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for cinder backup with customized ceph cluster name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current RBD driver assumes ceph cluster name to be \u0027ceph\u0027, for"},{"line_number":10,"context_line":"cluster has a different name, the backup manager won\u0027t be able"},{"line_number":11,"context_line":"to connect to the ceph cluster.  This change adds new entry"},{"line_number":12,"context_line":"\u0027conffile\u0027 to data dictionary  in initialize_connection method"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_87475276","line":9,"range":{"start_line":9,"start_character":59,"end_line":9,"end_character":62},"in_reply_to":"bacf61ea_c73aea33","updated":"2016-08-04 10:41:38.000000000","message":"it is for cinder backup RBD driver.","commit_id":"8a40fc3e10e62ce40d4bbbb4cf1421d61e8a9048"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"8341e10a99ff13c3dc06ed10269a7f4bf11d0bc7","unresolved":false,"context_lines":[{"line_number":880,"context_line":"                    \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":881,"context_line":"                    \u0027secret_uuid\u0027: None,"},{"line_number":882,"context_line":"                    \u0027volume_id\u0027: self.volume_a.id,"},{"line_number":883,"context_line":"                    \u0027conffile\u0027: self.cfg.rbd_ceph_conf"},{"line_number":884,"context_line":"                }"},{"line_number":885,"context_line":"            }"},{"line_number":886,"context_line":"            actual \u003d self.driver.initialize_connection(self.volume_a, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_b29356a2","line":883,"range":{"start_line":883,"start_character":41,"end_line":883,"end_character":54},"updated":"2016-08-05 18:45:44.000000000","message":"conffile is not used in the further testing...How did the testing the conffile?","commit_id":"de5bff8ca863eb9d15e5ed96dbd2e7269961ad2a"},{"author":{"_account_id":20585,"name":"Naga Venkata","email":"naga.b@hpe.com","username":"naga"},"change_message_id":"ff2e60462abcd91f795f0c4ba77c754b6028147f","unresolved":false,"context_lines":[{"line_number":880,"context_line":"                    \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":881,"context_line":"                    \u0027secret_uuid\u0027: None,"},{"line_number":882,"context_line":"                    \u0027volume_id\u0027: self.volume_a.id,"},{"line_number":883,"context_line":"                    \u0027conffile\u0027: self.cfg.rbd_ceph_conf"},{"line_number":884,"context_line":"                }"},{"line_number":885,"context_line":"            }"},{"line_number":886,"context_line":"            actual \u003d self.driver.initialize_connection(self.volume_a, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_72839e03","line":883,"range":{"start_line":883,"start_character":41,"end_line":883,"end_character":54},"in_reply_to":"bacf61ea_b29356a2","updated":"2016-08-05 18:52:45.000000000","message":"actually \"self.driver.initialize_connection\" will return dict with \"confile\" same as above expected dict.","commit_id":"de5bff8ca863eb9d15e5ed96dbd2e7269961ad2a"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"fee45d90c68790cdc03c75c04bfbefb1d51c23ed","unresolved":false,"context_lines":[{"line_number":828,"context_line":"                \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":829,"context_line":"                \u0027secret_uuid\u0027: self.configuration.rbd_secret_uuid,"},{"line_number":830,"context_line":"                \u0027volume_id\u0027: volume.id,"},{"line_number":831,"context_line":"                \u0027conffile\u0027: self.configuration.rbd_ceph_conf,"},{"line_number":832,"context_line":"            }"},{"line_number":833,"context_line":"        }"},{"line_number":834,"context_line":"        LOG.debug(\u0027connection data: %s\u0027, data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_23a2a8fc","line":831,"range":{"start_line":831,"start_character":16,"end_line":831,"end_character":61},"updated":"2016-08-05 03:11:55.000000000","message":"rbd_ceph_conf is supposed to be consumed by cinder volume service (which runs on the same physical server where rbd_ceph_conf resides), but passing this file location to a remote consumer, e.g. backup service, and expecting it to work implies backup service has same config file at same location, which is deployment dependent, can easily fail.","commit_id":"0fae2b77c0d3f01e4491acf6de40ca0cd49dc68c"},{"author":{"_account_id":20585,"name":"Naga Venkata","email":"naga.b@hpe.com","username":"naga"},"change_message_id":"936f62cae0895be5c119f1729c38d45749c2de34","unresolved":false,"context_lines":[{"line_number":828,"context_line":"                \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":829,"context_line":"                \u0027secret_uuid\u0027: self.configuration.rbd_secret_uuid,"},{"line_number":830,"context_line":"                \u0027volume_id\u0027: volume.id,"},{"line_number":831,"context_line":"                \u0027conffile\u0027: self.configuration.rbd_ceph_conf,"},{"line_number":832,"context_line":"            }"},{"line_number":833,"context_line":"        }"},{"line_number":834,"context_line":"        LOG.debug(\u0027connection data: %s\u0027, data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_09ea2574","line":831,"range":{"start_line":831,"start_character":16,"end_line":831,"end_character":61},"in_reply_to":"bacf61ea_23a2a8fc","updated":"2016-08-05 04:58:04.000000000","message":"yes, I agree it is deployment dependency to have same conf file on node where backup service is running. but even if we have same conf file on backup node, code in os-brick is always passing default conf(/etc/ceph/ceph.conf) to Rados.\nSo this fix will solve that problem i think.","commit_id":"0fae2b77c0d3f01e4491acf6de40ca0cd49dc68c"}]}