)]}'
{"cinder/quota.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fdce336d5b0de164b9ee9683971bdcd03063799a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    cfg.StrOpt(\u0027quota_driver\u0027,"},{"line_number":70,"context_line":"               default\u003d\"cinder.quota.DbQuotaDriver\","},{"line_number":71,"context_line":"               help\u003d\u0027Default driver to use for quota checks\u0027),"},{"line_number":72,"context_line":"    cfg.BoolOpt(\u0027use_default_quota_class\u0027,"},{"line_number":73,"context_line":"                default\u003dTrue,"},{"line_number":74,"context_line":"                help\u003d\u0027Enables or disables use of default quota class \u0027"},{"line_number":75,"context_line":"                     \u0027with default quota.\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_8b3980a6","line":72,"updated":"2016-10-04 10:47:01.000000000","message":"-1: You are not actually removing the option, just removing the logic and the warning...  Shouldn\u0027t we remove this?","commit_id":"9d9d7402d0dc294f98dede730cd2190eb83cbae5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6baad91581f142d2b57db45e0c6b65a542ccb277","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    cfg.StrOpt(\u0027quota_driver\u0027,"},{"line_number":70,"context_line":"               default\u003d\"cinder.quota.DbQuotaDriver\","},{"line_number":71,"context_line":"               help\u003d\u0027Default driver to use for quota checks\u0027),"},{"line_number":72,"context_line":"    cfg.BoolOpt(\u0027use_default_quota_class\u0027,"},{"line_number":73,"context_line":"                default\u003dTrue,"},{"line_number":74,"context_line":"                help\u003d\u0027Enables or disables use of default quota class \u0027"},{"line_number":75,"context_line":"                     \u0027with default quota.\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_997c4f74","line":72,"in_reply_to":"1a95cdbc_ddcb3e1d","updated":"2016-10-05 08:27:14.000000000","message":"If the reason to keep the config option is to follow the \"official\" way, then you can\u0027t remove the logic at the same time.  The requirements for \"follows-standard-deprecation\" says: \"Appropriate warnings will be sent to the end user, operator or library user. Code will be frozen and only receive minimal maintenance (just so that it continues to work as-is).\".\n\nMy take is that we either accept the warning we were displaying before as fulfilling this criteria and therefore we can remove the option with its logic, or if it doesn\u0027t meet it, we have to keep the functionality \"as-is\" while the configuration option exists and is displaying the deprecation warning.","commit_id":"9d9d7402d0dc294f98dede730cd2190eb83cbae5"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"2b9705a5525739dc2a2e20c265ce60a024934545","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    cfg.StrOpt(\u0027quota_driver\u0027,"},{"line_number":70,"context_line":"               default\u003d\"cinder.quota.DbQuotaDriver\","},{"line_number":71,"context_line":"               help\u003d\u0027Default driver to use for quota checks\u0027),"},{"line_number":72,"context_line":"    cfg.BoolOpt(\u0027use_default_quota_class\u0027,"},{"line_number":73,"context_line":"                default\u003dTrue,"},{"line_number":74,"context_line":"                help\u003d\u0027Enables or disables use of default quota class \u0027"},{"line_number":75,"context_line":"                     \u0027with default quota.\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_ddcb3e1d","line":72,"in_reply_to":"3a98d1f4_8b3980a6","updated":"2016-10-04 16:47:00.000000000","message":"We discussed it and decided that it was a violation of removal rules to get rid of it without a period of deprecation.\nIt was mentioned that the warning could serve as the deprecation, but that is not the \"official\" way. So for the sake of being proper, it is deprecated here and now, and can be removed next release.","commit_id":"9d9d7402d0dc294f98dede730cd2190eb83cbae5"}]}