)]}'
{"cinder/tests/unit/volume/drivers/test_zfssa.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"285c719f28889b7a840c43d837cb735c70a80c01","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            with mock.patch.object(lcfg, \u0027zfssa_initiator_group\u0027, \u0027\u0027):"},{"line_number":204,"context_line":"                self.assertRaises(exception.InvalidConfigurationValue,"},{"line_number":205,"context_line":"                                  self.drv.do_setup, {})"},{"line_number":206,"context_line":"                elog.assert_called_with(\u0027zfssa_initiator_group cannot be \u0027"},{"line_number":207,"context_line":"                                        \u0027empty. Explicitly set the value \u0027"},{"line_number":208,"context_line":"                                        \u0027\"default\" to use the default \u0027"},{"line_number":209,"context_line":"                                        \u0027initiator group.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a461143_0d48a6cb","line":206,"updated":"2017-01-28 20:54:08.000000000","message":"Please do not assert on log text in unit tests. They should just be validating functionality, not messaging.","commit_id":"f7e79f28ced3afdd6a7202cb1616c973ab1af3d0"}],"cinder/volume/drivers/zfssa/zfssaiscsi.py":[{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b957288c62fc87d33802cb8b25a9bec3d7d3b514","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                zfssa_initiator_group \u003d initiator_group"},{"line_number":181,"context_line":"                for zfssa_initiator in initiator_config[zfssa_initiator_group]:"},{"line_number":182,"context_line":"                    self.zfssa.create_initiator("},{"line_number":183,"context_line":"                        zfssa_initiator[\u0027iqn\u0027],"},{"line_number":184,"context_line":"                        zfssa_initiator_group + \u0027-\u0027 +"},{"line_number":185,"context_line":"                        zfssa_initiator[\u0027iqn\u0027],"},{"line_number":186,"context_line":"                        chapuser\u003dzfssa_initiator[\u0027user\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_d782f0ff","line":183,"range":{"start_line":183,"start_character":0,"end_line":183,"end_character":24},"updated":"2016-08-27 02:42:19.000000000","message":"There are multiple changes unrelated with the bug fix. Not sure why those changes are made.","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"74d0e2860750b8a0471457acc80c3e7bf2627d56","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                zfssa_initiator_group \u003d initiator_group"},{"line_number":181,"context_line":"                for zfssa_initiator in initiator_config[zfssa_initiator_group]:"},{"line_number":182,"context_line":"                    self.zfssa.create_initiator("},{"line_number":183,"context_line":"                        zfssa_initiator[\u0027iqn\u0027],"},{"line_number":184,"context_line":"                        zfssa_initiator_group + \u0027-\u0027 +"},{"line_number":185,"context_line":"                        zfssa_initiator[\u0027iqn\u0027],"},{"line_number":186,"context_line":"                        chapuser\u003dzfssa_initiator[\u0027user\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_ffcfbf7c","line":183,"range":{"start_line":183,"start_character":0,"end_line":183,"end_character":24},"in_reply_to":"fa7ab95a_426e1c97","updated":"2016-08-28 01:22:12.000000000","message":"I have seen similar cases like this, and from Openstack guidelines, it is recommended to fix what is filed as a bug. That is why I mentioned here. Formatting log messages are unrelated to the bug fix.","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":23047,"name":"Drew Balfour","email":"andrew.balfour@oracle.com","username":"abalfour"},"change_message_id":"0ed6116297037343c902c4f923e7cb35afad72bd","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                zfssa_initiator_group \u003d initiator_group"},{"line_number":181,"context_line":"                for zfssa_initiator in initiator_config[zfssa_initiator_group]:"},{"line_number":182,"context_line":"                    self.zfssa.create_initiator("},{"line_number":183,"context_line":"                        zfssa_initiator[\u0027iqn\u0027],"},{"line_number":184,"context_line":"                        zfssa_initiator_group + \u0027-\u0027 +"},{"line_number":185,"context_line":"                        zfssa_initiator[\u0027iqn\u0027],"},{"line_number":186,"context_line":"                        chapuser\u003dzfssa_initiator[\u0027user\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_426e1c97","line":183,"range":{"start_line":183,"start_character":0,"end_line":183,"end_character":24},"in_reply_to":"fa7ab95a_d782f0ff","updated":"2016-08-27 03:47:38.000000000","message":"Because they\u0027re formatting and whitespace fixes to make the file more readable. I suppose I could separate bugs for them, but since they\u0027re not code changes why?","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b957288c62fc87d33802cb8b25a9bec3d7d3b514","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                    value\u003d\u0027\u0027, option\u003d\u0027zfssa_initiator\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            if lcfg.zfssa_initiator !\u003d \u0027\u0027:"},{"line_number":212,"context_line":"                if lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027:"},{"line_number":213,"context_line":"                    LOG.warning(_LW(\u0027zfssa_initiator: %(ini)s wont be used \u0027"},{"line_number":214,"context_line":"                                    \u0027on the default initiator group.\u0027),"},{"line_number":215,"context_line":"                                {\u0027ini\u0027: lcfg.zfssa_initiator})"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_5777c039","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":16},"updated":"2016-08-27 02:42:19.000000000","message":"These changes make the logic more easier to follow.","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b957288c62fc87d33802cb8b25a9bec3d7d3b514","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        if not self._verify_clone_size(snapshot, volume[\u0027size\u0027] * units.Gi):"},{"line_number":406,"context_line":"            exception_msg \u003d (_(\u0027Error verifying clone size on \u0027"},{"line_number":407,"context_line":"                               \u0027Volume clone: %(clone)s \u0027"},{"line_number":408,"context_line":"                               \u0027Size: %(size)d on \u0027"},{"line_number":409,"context_line":"                               \u0027Snapshot: %(snapshot)s\u0027)"},{"line_number":410,"context_line":"                             % {\u0027clone\u0027: volume[\u0027name\u0027],"},{"line_number":411,"context_line":"                                \u0027size\u0027: volume[\u0027size\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_d7991070","line":408,"range":{"start_line":408,"start_character":0,"end_line":408,"end_character":31},"updated":"2016-08-27 02:42:19.000000000","message":"Same comments as the 1st one","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":23047,"name":"Drew Balfour","email":"andrew.balfour@oracle.com","username":"abalfour"},"change_message_id":"0ed6116297037343c902c4f923e7cb35afad72bd","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        if not self._verify_clone_size(snapshot, volume[\u0027size\u0027] * units.Gi):"},{"line_number":406,"context_line":"            exception_msg \u003d (_(\u0027Error verifying clone size on \u0027"},{"line_number":407,"context_line":"                               \u0027Volume clone: %(clone)s \u0027"},{"line_number":408,"context_line":"                               \u0027Size: %(size)d on \u0027"},{"line_number":409,"context_line":"                               \u0027Snapshot: %(snapshot)s\u0027)"},{"line_number":410,"context_line":"                             % {\u0027clone\u0027: volume[\u0027name\u0027],"},{"line_number":411,"context_line":"                                \u0027size\u0027: volume[\u0027size\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_e20f30df","line":408,"range":{"start_line":408,"start_character":0,"end_line":408,"end_character":31},"in_reply_to":"fa7ab95a_d7991070","updated":"2016-08-27 03:47:38.000000000","message":"The error message is missing a space. If you want a separate bug for a missing space, that\u0027s fine.","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b957288c62fc87d33802cb8b25a9bec3d7d3b514","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        try:"},{"line_number":501,"context_line":"            self.create_volume_from_snapshot(volume, zfssa_snapshot)"},{"line_number":502,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":503,"context_line":"            LOG.error(_LE(\u0027Clone Volume: \u0027"},{"line_number":504,"context_line":"                          \u0027%(volume)s failed from source volume: \u0027"},{"line_number":505,"context_line":"                          \u0027%(src_vref)s\u0027),"},{"line_number":506,"context_line":"                      {\u0027volume\u0027: volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_17a458a4","line":503,"range":{"start_line":503,"start_character":0,"end_line":503,"end_character":12},"updated":"2016-08-27 02:42:19.000000000","message":"Same as 1st comment","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":23047,"name":"Drew Balfour","email":"andrew.balfour@oracle.com","username":"abalfour"},"change_message_id":"0ed6116297037343c902c4f923e7cb35afad72bd","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        try:"},{"line_number":501,"context_line":"            self.create_volume_from_snapshot(volume, zfssa_snapshot)"},{"line_number":502,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":503,"context_line":"            LOG.error(_LE(\u0027Clone Volume: \u0027"},{"line_number":504,"context_line":"                          \u0027%(volume)s failed from source volume: \u0027"},{"line_number":505,"context_line":"                          \u0027%(src_vref)s\u0027),"},{"line_number":506,"context_line":"                      {\u0027volume\u0027: volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_0213340e","line":503,"range":{"start_line":503,"start_character":0,"end_line":503,"end_character":12},"in_reply_to":"fa7ab95a_17a458a4","updated":"2016-08-27 03:47:38.000000000","message":"Same as previous comment; missing space in error message.","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b957288c62fc87d33802cb8b25a9bec3d7d3b514","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        cachevol_props.update(cachevol_meta)"},{"line_number":608,"context_line":"        cache_vol, cache_snap \u003d None, None"},{"line_number":609,"context_line":"        updated_at \u003d six.text_type(img_meta[\u0027updated_at\u0027].isoformat())"},{"line_number":610,"context_line":"        LOG.debug(\u0027Verifying cache volume: %s\u0027, cachevol_name)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        try:"},{"line_number":613,"context_line":"            cache_vol \u003d self.zfssa.get_lun(lcfg.zfssa_pool,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_379f9c51","line":610,"range":{"start_line":610,"start_character":0,"end_line":610,"end_character":8},"updated":"2016-08-27 02:42:19.000000000","message":"Same as 1st comment","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":23047,"name":"Drew Balfour","email":"andrew.balfour@oracle.com","username":"abalfour"},"change_message_id":"0ed6116297037343c902c4f923e7cb35afad72bd","unresolved":false,"context_lines":[{"line_number":607,"context_line":"        cachevol_props.update(cachevol_meta)"},{"line_number":608,"context_line":"        cache_vol, cache_snap \u003d None, None"},{"line_number":609,"context_line":"        updated_at \u003d six.text_type(img_meta[\u0027updated_at\u0027].isoformat())"},{"line_number":610,"context_line":"        LOG.debug(\u0027Verifying cache volume: %s\u0027, cachevol_name)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        try:"},{"line_number":613,"context_line":"            cache_vol \u003d self.zfssa.get_lun(lcfg.zfssa_pool,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_022a542c","line":610,"range":{"start_line":610,"start_character":0,"end_line":610,"end_character":8},"in_reply_to":"fa7ab95a_379f9c51","updated":"2016-08-27 03:47:38.000000000","message":"Same response for all following comments; it cleans up the code and has no functional impact.","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b957288c62fc87d33802cb8b25a9bec3d7d3b514","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                                             specs,"},{"line_number":633,"context_line":"                                             cachevol_props)"},{"line_number":634,"context_line":"        except exception.SnapshotNotFound:"},{"line_number":635,"context_line":"            exception_msg \u003d (_(\u0027Cache volume %(cache_vol)s \u0027"},{"line_number":636,"context_line":"                               \u0027does not have snapshot %(cache_snap)s.\u0027),"},{"line_number":637,"context_line":"                             {\u0027cache_vol\u0027: cachevol_name,"},{"line_number":638,"context_line":"                              \u0027cache_snap\u0027: cachesnap_name})"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_b7b9eccd","line":635,"range":{"start_line":635,"start_character":0,"end_line":635,"end_character":12},"updated":"2016-08-27 02:42:19.000000000","message":"Same as 1st comment","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b957288c62fc87d33802cb8b25a9bec3d7d3b514","unresolved":false,"context_lines":[{"line_number":933,"context_line":"                                        \u0027tgt_pool\u0027: tgt_pool,"},{"line_number":934,"context_line":"                                        \u0027tgt_project\u0027: tgt_project,"},{"line_number":935,"context_line":"                                        \u0027volume\u0027: volume,"},{"line_number":936,"context_line":"                                        \u0027tgt_asn\u0027: tgt_asn,"},{"line_number":937,"context_line":"                                        \u0027src_zfssa\u0027: self.zfssa,"},{"line_number":938,"context_line":"                                        \u0027src_asn\u0027: src_asn,"},{"line_number":939,"context_line":"                                        \u0027src_pool\u0027: src_pool,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_17cb7854","line":936,"range":{"start_line":936,"start_character":0,"end_line":936,"end_character":40},"updated":"2016-08-27 02:42:19.000000000","message":"Same as 1st comment","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b957288c62fc87d33802cb8b25a9bec3d7d3b514","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"                                     schema\u003d{\"custom:cinder_managed\": False})"},{"line_number":1068,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":1069,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1070,"context_line":"                LOG.error(_LE(\"Failed to rename volume %(existing)s to \""},{"line_number":1071,"context_line":"                              \"%(new)s. Volume unmanage failed.\"),"},{"line_number":1072,"context_line":"                          {\u0027existing\u0027: volume[\u0027name\u0027],"},{"line_number":1073,"context_line":"                           \u0027new\u0027: new_name})"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_37c6bc49","line":1070,"range":{"start_line":1070,"start_character":0,"end_line":1070,"end_character":16},"updated":"2016-08-27 02:42:19.000000000","message":"Same as 1st comment","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b957288c62fc87d33802cb8b25a9bec3d7d3b514","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"            err_msg \u003d (_(\"Unknown if the volume: %s to be managed is \""},{"line_number":1085,"context_line":"                         \"already being managed by Cinder. Aborting manage \""},{"line_number":1086,"context_line":"                         \"volume. Please add \u0027cinder_managed\u0027 custom schema \""},{"line_number":1087,"context_line":"                         \"property to the volume and set its value to False. \""},{"line_number":1088,"context_line":"                         \"Alternatively, set the value of cinder config \""},{"line_number":1089,"context_line":"                         \"policy \u0027zfssa_manage_policy\u0027 to \u0027loose\u0027 to \""},{"line_number":1090,"context_line":"                         \"remove this restriction.\") % vol_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_57c5003a","line":1087,"range":{"start_line":1087,"start_character":0,"end_line":1087,"end_character":25},"updated":"2016-08-27 02:42:19.000000000","message":"Same as 1st comment","commit_id":"09ea07b5e473513b71df32cdfe98adcd5aad4d5f"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"432d59194e838052051fa94738f04d9640c81d2f","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            if not lcfg.zfssa_initiator_group:"},{"line_number":200,"context_line":"                LOG.error(_LE(\u0027zfssa_initiator_group cannot be empty. \u0027"},{"line_number":201,"context_line":"                              \u0027Explicitly set the value \"default\" to use \u0027"},{"line_number":202,"context_line":"                              \u0027the the default initiator group.\u0027))"},{"line_number":203,"context_line":"                raise exception.InvalidConfigurationValue("},{"line_number":204,"context_line":"                    value\u003d\u0027\u0027, option\u003d\u0027zfssa_initiator_group\u0027)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_e54b005e","line":202,"range":{"start_line":202,"start_character":31,"end_line":202,"end_character":34},"updated":"2016-09-09 06:52:03.000000000","message":"redundant \u0027the\u0027","commit_id":"3e7d25c5bd6435fbae523065f6f84dd91e2cb48a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"432d59194e838052051fa94738f04d9640c81d2f","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            if lcfg.zfssa_initiator !\u003d \u0027\u0027:"},{"line_number":214,"context_line":"                if lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027:"},{"line_number":215,"context_line":"                    LOG.warning(_LW(\u0027zfssa_initiator: %(ini)s wont be used \u0027"},{"line_number":216,"context_line":"                                    \u0027on the default initiator group.\u0027),"},{"line_number":217,"context_line":"                                {\u0027ini\u0027: lcfg.zfssa_initiator})"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"                # Setup initiator and initiator group"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_65953087","line":216,"updated":"2016-09-09 06:52:03.000000000","message":"We are past soft string freeze.\n\nhttps://releases.openstack.org/newton/schedule.html#n-cinder-ff","commit_id":"3e7d25c5bd6435fbae523065f6f84dd91e2cb48a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fc8053dced1259359ca7eed593801215cc048c58","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            if lcfg.zfssa_initiator !\u003d \u0027\u0027:"},{"line_number":214,"context_line":"                if lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027:"},{"line_number":215,"context_line":"                    LOG.warning(_LW(\u0027zfssa_initiator: %(ini)s wont be used \u0027"},{"line_number":216,"context_line":"                                    \u0027on the default initiator group.\u0027),"},{"line_number":217,"context_line":"                                {\u0027ini\u0027: lcfg.zfssa_initiator})"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"                # Setup initiator and initiator group"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_24007caa","line":216,"in_reply_to":"9a89bdaa_214b0eb2","updated":"2016-09-09 11:17:53.000000000","message":"It doesn\u0027t matter. At this point, changes to existing translatable strings are not allowd.\n\nSee the last Cinder meeting minutes for details.","commit_id":"3e7d25c5bd6435fbae523065f6f84dd91e2cb48a"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b2fe8c1db00c680a878085122cdb474deffd1b9d","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            if lcfg.zfssa_initiator !\u003d \u0027\u0027:"},{"line_number":214,"context_line":"                if lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027:"},{"line_number":215,"context_line":"                    LOG.warning(_LW(\u0027zfssa_initiator: %(ini)s wont be used \u0027"},{"line_number":216,"context_line":"                                    \u0027on the default initiator group.\u0027),"},{"line_number":217,"context_line":"                                {\u0027ini\u0027: lcfg.zfssa_initiator})"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"                # Setup initiator and initiator group"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_214b0eb2","line":216,"in_reply_to":"9a89bdaa_65953087","updated":"2016-09-09 11:11:14.000000000","message":"Don\u0027t think this is a feature, it is a bug fix.","commit_id":"3e7d25c5bd6435fbae523065f6f84dd91e2cb48a"},{"author":{"_account_id":23047,"name":"Drew Balfour","email":"andrew.balfour@oracle.com","username":"abalfour"},"change_message_id":"b6763fd02307bdd43b1efeb9829c84d4d01a3926","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                    for initiator in lcfg.zfssa_initiator.split(\u0027,\u0027):"},{"line_number":222,"context_line":"                        initiator \u003d initiator.strip()"},{"line_number":223,"context_line":"                        self.zfssa.create_initiator("},{"line_number":224,"context_line":"                            initiator, lcfg.zfssa_initiator_group + \u0027-\u0027 +"},{"line_number":225,"context_line":"                            initiator, chapuser\u003dlcfg.zfssa_initiator_user,"},{"line_number":226,"context_line":"                            chapsecret\u003dlcfg.zfssa_initiator_password)"},{"line_number":227,"context_line":"                        self.zfssa.add_to_initiatorgroup("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_f37f0464","line":224,"updated":"2016-09-14 22:19:27.000000000","message":"That shouldn\u0027t be like that; the point was to keep arguments together if possible.","commit_id":"3e7d25c5bd6435fbae523065f6f84dd91e2cb48a"}]}