)]}'
{"cinder/tests/unit/volume/drivers/test_solidfire.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"497421c83f0e1c9a3f3695b8aab7f4b3a9f571ed","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        testvol \u003d {\u0027project_id\u0027: \u0027testprjid\u0027,"},{"line_number":517,"context_line":"                   \u0027name\u0027: \u0027test_volume\u0027,"},{"line_number":518,"context_line":"                   \u0027size\u0027: 1,"},{"line_number":519,"context_line":"                   \u0027id\u0027: vol_id,"},{"line_number":520,"context_line":"                   \u0027name_id\u0027: vol_id,"},{"line_number":521,"context_line":"                   \u0027created_at\u0027: timeutils.utcnow(),"},{"line_number":522,"context_line":"                   \u0027provider_id\u0027: \u00271 5 None\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e3099b96","line":519,"range":{"start_line":519,"start_character":25,"end_line":519,"end_character":31},"updated":"2016-08-05 12:12:17.000000000","message":"Please use constants from fake_constants.py","commit_id":"a8e3220bd8e03697dd7ae1f34bf4e678558a46ed"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"091ce50039bcc00f133951d06ea620b162d186d2","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        testvol \u003d {\u0027project_id\u0027: \u0027testprjid\u0027,"},{"line_number":517,"context_line":"                   \u0027name\u0027: \u0027test_volume\u0027,"},{"line_number":518,"context_line":"                   \u0027size\u0027: 1,"},{"line_number":519,"context_line":"                   \u0027id\u0027: vol_id,"},{"line_number":520,"context_line":"                   \u0027name_id\u0027: vol_id,"},{"line_number":521,"context_line":"                   \u0027created_at\u0027: timeutils.utcnow(),"},{"line_number":522,"context_line":"                   \u0027provider_id\u0027: \u00271 5 None\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e187d35e","line":519,"range":{"start_line":519,"start_character":25,"end_line":519,"end_character":31},"in_reply_to":"bacf61ea_43b3479a","updated":"2016-08-05 12:56:22.000000000","message":"I agree with Ivan.","commit_id":"a8e3220bd8e03697dd7ae1f34bf4e678558a46ed"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"29083e88c66cc94311b6333577beb8e36f5a09d2","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        testvol \u003d {\u0027project_id\u0027: \u0027testprjid\u0027,"},{"line_number":517,"context_line":"                   \u0027name\u0027: \u0027test_volume\u0027,"},{"line_number":518,"context_line":"                   \u0027size\u0027: 1,"},{"line_number":519,"context_line":"                   \u0027id\u0027: vol_id,"},{"line_number":520,"context_line":"                   \u0027name_id\u0027: vol_id,"},{"line_number":521,"context_line":"                   \u0027created_at\u0027: timeutils.utcnow(),"},{"line_number":522,"context_line":"                   \u0027provider_id\u0027: \u00271 5 None\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_43b3479a","line":519,"range":{"start_line":519,"start_character":25,"end_line":519,"end_character":31},"in_reply_to":"bacf61ea_e3099b96","updated":"2016-08-05 12:15:30.000000000","message":"It\u0027s out of scope for this fix. IMO, such refactoring should be done in a separate patch","commit_id":"a8e3220bd8e03697dd7ae1f34bf4e678558a46ed"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"091ce50039bcc00f133951d06ea620b162d186d2","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                               \u0027_get_sfaccounts_for_tenant\u0027,"},{"line_number":547,"context_line":"                               return_value\u003dfake_sfaccounts), \\"},{"line_number":548,"context_line":"            mock.patch.object(sfv,"},{"line_number":549,"context_line":"                              \u0027_get_volumes_for_account\u0027,"},{"line_number":550,"context_line":"                              return_value\u003dget_vol_result), \\"},{"line_number":551,"context_line":"            mock.patch.object(sfv,"},{"line_number":552,"context_line":"                              \u0027_issue_api_request\u0027), \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_7cdee86d","line":549,"updated":"2016-08-05 12:56:22.000000000","message":"We can also assert for the _get_volumes_for_account call. With that assertion, the test would fail without this patch.","commit_id":"a8e3220bd8e03697dd7ae1f34bf4e678558a46ed"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"497421c83f0e1c9a3f3695b8aab7f4b3a9f571ed","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        testvol \u003d {\u0027project_id\u0027: \u0027testprjid\u0027,"},{"line_number":567,"context_line":"                   \u0027name\u0027: \u0027no-name\u0027,"},{"line_number":568,"context_line":"                   \u0027size\u0027: 1,"},{"line_number":569,"context_line":"                   \u0027id\u0027: vol_id,"},{"line_number":570,"context_line":"                   \u0027name_id\u0027: vol_id,"},{"line_number":571,"context_line":"                   \u0027created_at\u0027: timeutils.utcnow()}"},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a3ecc3bb","line":569,"range":{"start_line":569,"start_character":25,"end_line":569,"end_character":31},"updated":"2016-08-05 12:12:17.000000000","message":"Ditto","commit_id":"a8e3220bd8e03697dd7ae1f34bf4e678558a46ed"}]}