)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4662a6b10c0aa3cb25fc86721d88981701b2e1a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder create without volume-type error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The cinder create command was failing if the default_volume_type"},{"line_number":10,"context_line":"is provided in cinder.conf. This happened because of a bug introduced"},{"line_number":11,"context_line":"in earlier change. This patch corrects the same"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4ac6841017c2126f20e185399e00761075d9d6ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_da7d96b2","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":27},"updated":"2016-08-10 08:45:45.000000000","message":"I guess this bug description is wrong. The actual issue reported in the related bug is that create command fails when \u0027default_volume_type\u0027 is NOT configured in cinder.conf.","commit_id":"c833bfead977889fa5e15d06cd84e4198ce5d74e"}],"cinder/scheduler/filter_scheduler.py":[{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"d400d6b19fe72dc750d29f1819a2ce9b3462f973","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        filter_properties.update({\u0027context\u0027: context,"},{"line_number":280,"context_line":"                                  \u0027request_spec\u0027: request_spec_dict,"},{"line_number":281,"context_line":"                                  \u0027config_options\u0027: config_options,"},{"line_number":282,"context_line":"                                  \u0027volume_type\u0027: volume_type,"},{"line_number":283,"context_line":"                                  \u0027resource_type\u0027: resource_type})"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        self.populate_filter_properties(request_spec,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_77ead710","line":282,"range":{"start_line":282,"start_character":34,"end_line":282,"end_character":61},"updated":"2016-08-09 22:49:17.000000000","message":"Won\u0027t changing the volume_type to volume_properties be changing the filter properties themselves? How do you know this is safe and won\u0027t change anything unexpected? From my devstack where I had a volume type configured when creating the volume you can see they contain some pretty different information, so still calling the variable \u0027volume_type\u0027 seems wrong unless I\u0027ve missed something. http://paste.openstack.org/show/552783/","commit_id":"58c0c49c7b8e79c119c8d01fd348187bc2dbbb7f"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"dfd463a4ff41a375cfd7eff378d3703e9ac85593","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        filter_properties.update({\u0027context\u0027: context,"},{"line_number":280,"context_line":"                                  \u0027request_spec\u0027: request_spec_dict,"},{"line_number":281,"context_line":"                                  \u0027config_options\u0027: config_options,"},{"line_number":282,"context_line":"                                  \u0027volume_type\u0027: volume_type,"},{"line_number":283,"context_line":"                                  \u0027resource_type\u0027: resource_type})"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        self.populate_filter_properties(request_spec,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_d78583ad","line":282,"range":{"start_line":282,"start_character":34,"end_line":282,"end_character":61},"in_reply_to":"9ad45d7e_77ead710","updated":"2016-08-09 23:10:58.000000000","message":"Maybe changing volume_type to volume_properties is the correct thing to do here, but I think the reasoning should be explained a bit more in the commit message, and maybe the volume_type variable should be renamed here to reflect what it\u0027s being changed to.","commit_id":"58c0c49c7b8e79c119c8d01fd348187bc2dbbb7f"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"1b63443a88680a46a38b12bac4337b4e6b82511f","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        if filter_properties is None or resource_type is None:"},{"line_number":269,"context_line":"            filter_properties \u003d {}"},{"line_number":270,"context_line":"            resource_type \u003d {}"},{"line_number":271,"context_line":"        self._populate_retry(filter_properties,"},{"line_number":272,"context_line":"                             request_spec[\u0027volume_properties\u0027])"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_4690b943","line":270,"range":{"start_line":270,"start_character":12,"end_line":270,"end_character":25},"updated":"2016-08-10 07:23:22.000000000","message":"Is it possible for filter_properties to be None and resource_type to have a value?  In that case would you really want to lose the resource_type value, and set it to {}\n\nOr the other way around, resource_type to be None and filter_properties to have a value.","commit_id":"c833bfead977889fa5e15d06cd84e4198ce5d74e"}]}