)]}'
{"cinder/tests/unit/test_utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7c99e21f8990bec6e40fe6497ad3b166a3daafdf","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"        self.assertEqual(2, mock_log.debug.call_count)"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"    def test_utils_trace_method_with_password_dict(self):"},{"line_number":1267,"context_line":"        mock_logging \u003d self.mock_object(utils, \u0027logging\u0027)"},{"line_number":1268,"context_line":"        mock_log \u003d mock.Mock()"},{"line_number":1269,"context_line":"        mock_log.isEnabledFor \u003d lambda x: True"},{"line_number":1270,"context_line":"        mock_logging.getLogger \u003d mock.Mock(return_value\u003dmock_log)"},{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":"        @utils.trace_method"},{"line_number":1273,"context_line":"        def _trace_test_method(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_53c31189","line":1270,"range":{"start_line":1267,"start_character":0,"end_line":1270,"end_character":65},"updated":"2016-08-11 09:57:44.000000000","message":"nit: I think this is more complicated than it needs to be:\n\n mock_log \u003d self.patch(\u0027cinder.utils.logging.getLogger\u0027)\n mock_log().isEnabledFor.return_value \u003d True","commit_id":"00cf49454ac360b09f0022c9fc11278aeb43712e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d48960c8a1bd656333b403dafedaae37079f2ff6","unresolved":false,"context_lines":[{"line_number":1264,"context_line":"        self.assertEqual(2, mock_log.debug.call_count)"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"    def test_utils_trace_method_with_password_dict(self):"},{"line_number":1267,"context_line":"        mock_logging \u003d self.mock_object(utils, \u0027logging\u0027)"},{"line_number":1268,"context_line":"        mock_log \u003d mock.Mock()"},{"line_number":1269,"context_line":"        mock_log.isEnabledFor \u003d lambda x: True"},{"line_number":1270,"context_line":"        mock_logging.getLogger \u003d mock.Mock(return_value\u003dmock_log)"},{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":"        @utils.trace_method"},{"line_number":1273,"context_line":"        def _trace_test_method(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_daf7fad0","line":1270,"range":{"start_line":1267,"start_character":0,"end_line":1270,"end_character":65},"in_reply_to":"9ad45d7e_53c31189","updated":"2016-08-11 16:17:08.000000000","message":"Done","commit_id":"00cf49454ac360b09f0022c9fc11278aeb43712e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7c99e21f8990bec6e40fe6497ad3b166a3daafdf","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"        self.assertEqual(expected_masked_dict, result)"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"    def test_utils_trace_method_with_password_str(self):"},{"line_number":1286,"context_line":"        mock_logging \u003d self.mock_object(utils, \u0027logging\u0027)"},{"line_number":1287,"context_line":"        mock_log \u003d mock.Mock()"},{"line_number":1288,"context_line":"        mock_log.isEnabledFor \u003d lambda x: True"},{"line_number":1289,"context_line":"        mock_logging.getLogger \u003d mock.Mock(return_value\u003dmock_log)"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        @utils.trace_method"},{"line_number":1292,"context_line":"        def _trace_test_method(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_f35fa5e2","line":1289,"range":{"start_line":1286,"start_character":0,"end_line":1289,"end_character":65},"updated":"2016-08-11 09:57:44.000000000","message":"ditto","commit_id":"00cf49454ac360b09f0022c9fc11278aeb43712e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d48960c8a1bd656333b403dafedaae37079f2ff6","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"        self.assertEqual(expected_masked_dict, result)"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"    def test_utils_trace_method_with_password_str(self):"},{"line_number":1286,"context_line":"        mock_logging \u003d self.mock_object(utils, \u0027logging\u0027)"},{"line_number":1287,"context_line":"        mock_log \u003d mock.Mock()"},{"line_number":1288,"context_line":"        mock_log.isEnabledFor \u003d lambda x: True"},{"line_number":1289,"context_line":"        mock_logging.getLogger \u003d mock.Mock(return_value\u003dmock_log)"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        @utils.trace_method"},{"line_number":1292,"context_line":"        def _trace_test_method(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_3a03b6b9","line":1289,"range":{"start_line":1286,"start_character":0,"end_line":1289,"end_character":65},"in_reply_to":"9ad45d7e_f35fa5e2","updated":"2016-08-11 16:17:08.000000000","message":"Done","commit_id":"00cf49454ac360b09f0022c9fc11278aeb43712e"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"5743bf47e5a5888294be3ecd81340408e5b4237a","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"        @utils.trace_method"},{"line_number":1271,"context_line":"        def _trace_test_method(*args, **kwargs):"},{"line_number":1272,"context_line":"            return {\u0027something\u0027: \u0027test\u0027,"},{"line_number":1273,"context_line":"                    \u0027password\u0027: \u0027Now you see me\u0027}"},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"        utils.setup_tracing([\u0027method\u0027])"},{"line_number":1276,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f075bf63","line":1273,"updated":"2016-08-11 16:49:49.000000000","message":"spaces are so....un-Unixy\n:)","commit_id":"54a958534f239d39c60ae773bacde2f35f5dfaac"}],"cinder/utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7c99e21f8990bec6e40fe6497ad3b166a3daafdf","unresolved":false,"context_lines":[{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        if isinstance(result, dict):"},{"line_number":859,"context_line":"            result \u003d strutils.mask_dict_password(result)"},{"line_number":860,"context_line":"        elif (isinstance(result, six.text_type) or"},{"line_number":861,"context_line":"              isinstance(result, six.string_types)):"},{"line_number":862,"context_line":"            result \u003d strutils.mask_password(result)"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        logger.debug(\u0027\u003c\u003d\u003d %(func)s: return (%(time)dms) %(result)r\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_fd75b497","line":861,"range":{"start_line":860,"start_character":1,"end_line":861,"end_character":52},"updated":"2016-08-11 09:57:44.000000000","message":"-1: Checking against text_type is unnecessary, we should just check against six.string_types.","commit_id":"00cf49454ac360b09f0022c9fc11278aeb43712e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d48960c8a1bd656333b403dafedaae37079f2ff6","unresolved":false,"context_lines":[{"line_number":857,"context_line":""},{"line_number":858,"context_line":"        if isinstance(result, dict):"},{"line_number":859,"context_line":"            result \u003d strutils.mask_dict_password(result)"},{"line_number":860,"context_line":"        elif (isinstance(result, six.text_type) or"},{"line_number":861,"context_line":"              isinstance(result, six.string_types)):"},{"line_number":862,"context_line":"            result \u003d strutils.mask_password(result)"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        logger.debug(\u0027\u003c\u003d\u003d %(func)s: return (%(time)dms) %(result)r\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_66a11e46","line":861,"range":{"start_line":860,"start_character":1,"end_line":861,"end_character":52},"in_reply_to":"9ad45d7e_fd75b497","updated":"2016-08-11 16:17:08.000000000","message":"Done","commit_id":"00cf49454ac360b09f0022c9fc11278aeb43712e"}]}