)]}'
{"cinder/tests/unit/test_cmd.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a82aac402918cb4332b438df327468f802dd940e","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                       service_name\u003d\u0027backend2\u0027, coordination\u003dTrue,"},{"line_number":382,"context_line":"                       cluster\u003dNone)"},{"line_number":383,"context_line":"        service_create.assert_has_calls([c1, c2])"},{"line_number":384,"context_line":"        self.assertEqual(len(filter(None, backends)), launcher.launch_service.call_count)"},{"line_number":385,"context_line":"        launcher.wait.assert_called_once_with()"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_05802ef4","line":384,"range":{"start_line":384,"start_character":7,"end_line":384,"end_character":89},"updated":"2016-08-11 10:52:58.000000000","message":"This line has more than 80 chars.","commit_id":"0855d276697f91946d90ee6b43514a260f3e3f53"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"f08d0409b77b132fa1d0c7a190941a27856058df","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                       service_name\u003d\u0027backend2\u0027, coordination\u003dTrue,"},{"line_number":382,"context_line":"                       cluster\u003dNone)"},{"line_number":383,"context_line":"        service_create.assert_has_calls([c1, c2])"},{"line_number":384,"context_line":"        self.assertEqual(len(filter(None, backends)), launcher.launch_service.call_count)"},{"line_number":385,"context_line":"        launcher.wait.assert_called_once_with()"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_48907b95","line":384,"range":{"start_line":384,"start_character":7,"end_line":384,"end_character":89},"in_reply_to":"9ad45d7e_05802ef4","updated":"2016-08-11 11:10:08.000000000","message":"Embarrassing :(  Fixed.","commit_id":"0855d276697f91946d90ee6b43514a260f3e3f53"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"99c3f7d91aa4db692c7591e4b49e0c810d3f82e0","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def test_main_with_backend(self, log_setup, get_logger, monkey_patch,"},{"line_number":176,"context_line":"                               process_launcher, wsgi_service, service_create,"},{"line_number":177,"context_line":"                               rpc_init):"},{"line_number":178,"context_line":"        CONF.set_override(\u0027enabled_backends\u0027, [\u0027backend1\u0027])"},{"line_number":179,"context_line":"        CONF.set_override(\u0027host\u0027, \u0027host\u0027)"},{"line_number":180,"context_line":"        launcher \u003d process_launcher.return_value"},{"line_number":181,"context_line":"        server \u003d wsgi_service.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_9f81ecfd","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":59},"updated":"2016-08-11 18:13:30.000000000","message":"You should make similar change here to test your fix in cmd.all","commit_id":"a293be733c358487ff817354832903461d6845c0"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"bd4c7ecb0a66d30bb9f1e7d0547ff95ba944ba4a","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def test_main_with_backend(self, log_setup, get_logger, monkey_patch,"},{"line_number":176,"context_line":"                               process_launcher, wsgi_service, service_create,"},{"line_number":177,"context_line":"                               rpc_init):"},{"line_number":178,"context_line":"        CONF.set_override(\u0027enabled_backends\u0027, [\u0027backend1\u0027])"},{"line_number":179,"context_line":"        CONF.set_override(\u0027host\u0027, \u0027host\u0027)"},{"line_number":180,"context_line":"        launcher \u003d process_launcher.return_value"},{"line_number":181,"context_line":"        server \u003d wsgi_service.return_value"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_e4bdfc02","line":178,"range":{"start_line":178,"start_character":8,"end_line":178,"end_character":59},"in_reply_to":"9ad45d7e_9f81ecfd","updated":"2016-08-15 17:43:54.000000000","message":"Done","commit_id":"a293be733c358487ff817354832903461d6845c0"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"99c3f7d91aa4db692c7591e4b49e0c810d3f82e0","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                       service_name\u003d\u0027backend2\u0027, coordination\u003dTrue,"},{"line_number":382,"context_line":"                       cluster\u003dNone)"},{"line_number":383,"context_line":"        service_create.assert_has_calls([c1, c2])"},{"line_number":384,"context_line":"        self.assertEqual(len(filter(None, backends)),"},{"line_number":385,"context_line":"                         launcher.launch_service.call_count)"},{"line_number":386,"context_line":"        launcher.wait.assert_called_once_with()"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_44cded2f","line":384,"range":{"start_line":384,"start_character":25,"end_line":384,"end_character":52},"updated":"2016-08-11 18:13:30.000000000","message":"filter returns iterator in Py3 and it doesn\u0027t have length, just use exact value you expect - 2","commit_id":"a293be733c358487ff817354832903461d6845c0"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"bd4c7ecb0a66d30bb9f1e7d0547ff95ba944ba4a","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                       service_name\u003d\u0027backend2\u0027, coordination\u003dTrue,"},{"line_number":382,"context_line":"                       cluster\u003dNone)"},{"line_number":383,"context_line":"        service_create.assert_has_calls([c1, c2])"},{"line_number":384,"context_line":"        self.assertEqual(len(filter(None, backends)),"},{"line_number":385,"context_line":"                         launcher.launch_service.call_count)"},{"line_number":386,"context_line":"        launcher.wait.assert_called_once_with()"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_c4b8b813","line":384,"range":{"start_line":384,"start_character":25,"end_line":384,"end_character":52},"in_reply_to":"9ad45d7e_44cded2f","updated":"2016-08-15 17:43:54.000000000","message":"Done","commit_id":"a293be733c358487ff817354832903461d6845c0"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"453ed470c6fa49fd771d1b91575db0d547119a8e","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                       service_name\u003d\u0027backend2\u0027, coordination\u003dTrue,"},{"line_number":382,"context_line":"                       cluster\u003dNone)"},{"line_number":383,"context_line":"        service_create.assert_has_calls([c1, c2])"},{"line_number":384,"context_line":"        self.assertEqual(len(list(filter(None, backends))),"},{"line_number":385,"context_line":"                         launcher.launch_service.call_count)"},{"line_number":386,"context_line":"        launcher.wait.assert_called_once_with()"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_ec63c318","line":384,"range":{"start_line":384,"start_character":25,"end_line":384,"end_character":58},"updated":"2016-08-15 22:41:13.000000000","message":"Better, but again, why don\u0027t you just use value you expect, rather than calculating it.","commit_id":"010a40117d19677b30c3e234fc003fbf2c3fafff"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"bbc639ea3451a6bd9cbcf8d73a358f99b4e41786","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                       service_name\u003d\u0027backend2\u0027, coordination\u003dTrue,"},{"line_number":382,"context_line":"                       cluster\u003dNone)"},{"line_number":383,"context_line":"        service_create.assert_has_calls([c1, c2])"},{"line_number":384,"context_line":"        self.assertEqual(len(list(filter(None, backends))),"},{"line_number":385,"context_line":"                         launcher.launch_service.call_count)"},{"line_number":386,"context_line":"        launcher.wait.assert_called_once_with()"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_b7458bb4","line":384,"range":{"start_line":384,"start_character":25,"end_line":384,"end_character":58},"in_reply_to":"3ac371cc_5a947a43","updated":"2016-08-21 15:31:35.000000000","message":"Thanks Szymon. I\u0027m convinced :)","commit_id":"010a40117d19677b30c3e234fc003fbf2c3fafff"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"87068edf3c4a62acb878e36208683f3699822fcf","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                       service_name\u003d\u0027backend2\u0027, coordination\u003dTrue,"},{"line_number":382,"context_line":"                       cluster\u003dNone)"},{"line_number":383,"context_line":"        service_create.assert_has_calls([c1, c2])"},{"line_number":384,"context_line":"        self.assertEqual(len(list(filter(None, backends))),"},{"line_number":385,"context_line":"                         launcher.launch_service.call_count)"},{"line_number":386,"context_line":"        launcher.wait.assert_called_once_with()"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_5a947a43","line":384,"range":{"start_line":384,"start_character":25,"end_line":384,"end_character":58},"in_reply_to":"3ac371cc_b70f1c2d","updated":"2016-08-19 15:42:23.000000000","message":"Agree, both ways will give you the same result, but what I\u0027m trying to explain is - you should avoid replicating logic from actual code in a test that suppose to test that logic, because if this logic contains a bug, your test will contain same bug, so test will pass because that bug is there. When using hardcoded value, you are sure that the thing you test behaves exactly like it should. And whoever change logic of backend list processing will have to update this assert too.","commit_id":"010a40117d19677b30c3e234fc003fbf2c3fafff"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"5b2b6973dd7ca7185432795c187d39c8bfd5b49d","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                       service_name\u003d\u0027backend2\u0027, coordination\u003dTrue,"},{"line_number":382,"context_line":"                       cluster\u003dNone)"},{"line_number":383,"context_line":"        service_create.assert_has_calls([c1, c2])"},{"line_number":384,"context_line":"        self.assertEqual(len(list(filter(None, backends))),"},{"line_number":385,"context_line":"                         launcher.launch_service.call_count)"},{"line_number":386,"context_line":"        launcher.wait.assert_called_once_with()"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_b70f1c2d","line":384,"range":{"start_line":384,"start_character":25,"end_line":384,"end_character":58},"in_reply_to":"3ac371cc_ec63c318","updated":"2016-08-16 19:13:53.000000000","message":"both ways are legitimate, but I prefer it this way because it will be valid even when someone changes the backends. Again, both ways are legitimate.","commit_id":"010a40117d19677b30c3e234fc003fbf2c3fafff"}]}