)]}'
{"cinder/tests/unit/volume/drivers/ibm/test_ibm_flashsystem_iscsi.py":[{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"c99b95a815d6f698c46f38161e0bd94e46ba9b04","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        existing_ref \u003d {\u0027source-name\u0027: u\u0027unmanage-vol-01\u0027}"},{"line_number":414,"context_line":"        vdisk_size \u003d self.driver.manage_existing_get_size(vol1, existing_ref)"},{"line_number":415,"context_line":"        self.assertEqual(10001, vdisk_size)"},{"line_number":416,"context_line":"        self.driver.delete_volume(vol1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_6a43936c","line":416,"range":{"start_line":416,"start_character":8,"end_line":416,"end_character":39},"updated":"2016-08-11 20:36:31.000000000","message":"Maybe I\u0027m wrong, but I think you should use \"self.sim._cmd_rmvdisk\" here since you only got the size of the volume. It\u0027s not indeed managed by Cinder.","commit_id":"e10491c90598a51880ce06d797d496f98a57fb54"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"f169154cde0b3537024a4687fb931fa21e5a2948","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        self.sim._cmd_rmvdisk(**vdisk1)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def test_flashsystem_manage_existing_get_size(self):"},{"line_number":394,"context_line":"        # case 1: bad existing_ref"},{"line_number":395,"context_line":"        vol1 \u003d self._generate_vol_info(None, None)"},{"line_number":396,"context_line":"        existing_ref \u003d {}"},{"line_number":397,"context_line":"        self.assertRaises(exception.ManageExistingInvalidReference,"},{"line_number":398,"context_line":"                          self.driver.manage_existing_get_size, vol1,"},{"line_number":399,"context_line":"                          existing_ref)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        # case 2: vdisk not exist"},{"line_number":402,"context_line":"        vol1 \u003d self._generate_vol_info(None)"},{"line_number":403,"context_line":"        existing_ref \u003d {\u0027source-name\u0027: u\u0027unmanage-vol-01\u0027}"},{"line_number":404,"context_line":"        self.assertRaises(exception.ManageExistingInvalidReference,"},{"line_number":405,"context_line":"                          self.driver.manage_existing_get_size,"},{"line_number":406,"context_line":"                          vol1,"},{"line_number":407,"context_line":"                          existing_ref)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        # case 3: good path"},{"line_number":410,"context_line":"        kwargs \u003d {\u0027name\u0027: u\u0027unmanage-vol-01\u0027, \u0027size\u0027: u\u002710001\u0027, \u0027unit\u0027: \u0027gb\u0027}"},{"line_number":411,"context_line":"        self.sim._cmd_mkvdisk(**kwargs)"},{"line_number":412,"context_line":"        vol1 \u003d self._generate_vol_info(None)"},{"line_number":413,"context_line":"        existing_ref \u003d {\u0027source-name\u0027: u\u0027unmanage-vol-01\u0027}"},{"line_number":414,"context_line":"        vdisk_size \u003d self.driver.manage_existing_get_size(vol1, existing_ref)"},{"line_number":415,"context_line":"        self.assertEqual(10001, vdisk_size)"},{"line_number":416,"context_line":"        self.driver.delete_volume(vol1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_343d948f","line":416,"range":{"start_line":394,"start_character":8,"end_line":416,"end_character":39},"updated":"2016-08-11 14:34:34.000000000","message":"why put more than one case in one testcase?","commit_id":"e10491c90598a51880ce06d797d496f98a57fb54"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"bad12b0c0503520f455884e1220bd72a1d5201db","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        self.sim._cmd_rmvdisk(**vdisk1)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def test_flashsystem_manage_existing_get_size(self):"},{"line_number":394,"context_line":"        # case 1: bad existing_ref"},{"line_number":395,"context_line":"        vol1 \u003d self._generate_vol_info(None, None)"},{"line_number":396,"context_line":"        existing_ref \u003d {}"},{"line_number":397,"context_line":"        self.assertRaises(exception.ManageExistingInvalidReference,"},{"line_number":398,"context_line":"                          self.driver.manage_existing_get_size, vol1,"},{"line_number":399,"context_line":"                          existing_ref)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        # case 2: vdisk not exist"},{"line_number":402,"context_line":"        vol1 \u003d self._generate_vol_info(None)"},{"line_number":403,"context_line":"        existing_ref \u003d {\u0027source-name\u0027: u\u0027unmanage-vol-01\u0027}"},{"line_number":404,"context_line":"        self.assertRaises(exception.ManageExistingInvalidReference,"},{"line_number":405,"context_line":"                          self.driver.manage_existing_get_size,"},{"line_number":406,"context_line":"                          vol1,"},{"line_number":407,"context_line":"                          existing_ref)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        # case 3: good path"},{"line_number":410,"context_line":"        kwargs \u003d {\u0027name\u0027: u\u0027unmanage-vol-01\u0027, \u0027size\u0027: u\u002710001\u0027, \u0027unit\u0027: \u0027gb\u0027}"},{"line_number":411,"context_line":"        self.sim._cmd_mkvdisk(**kwargs)"},{"line_number":412,"context_line":"        vol1 \u003d self._generate_vol_info(None)"},{"line_number":413,"context_line":"        existing_ref \u003d {\u0027source-name\u0027: u\u0027unmanage-vol-01\u0027}"},{"line_number":414,"context_line":"        vdisk_size \u003d self.driver.manage_existing_get_size(vol1, existing_ref)"},{"line_number":415,"context_line":"        self.assertEqual(10001, vdisk_size)"},{"line_number":416,"context_line":"        self.driver.delete_volume(vol1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ac8d9432","line":416,"range":{"start_line":394,"start_character":8,"end_line":416,"end_character":39},"in_reply_to":"9ad45d7e_343d948f","updated":"2016-08-13 00:28:08.000000000","message":"Done","commit_id":"e10491c90598a51880ce06d797d496f98a57fb54"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"bad12b0c0503520f455884e1220bd72a1d5201db","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        existing_ref \u003d {\u0027source-name\u0027: u\u0027unmanage-vol-01\u0027}"},{"line_number":414,"context_line":"        vdisk_size \u003d self.driver.manage_existing_get_size(vol1, existing_ref)"},{"line_number":415,"context_line":"        self.assertEqual(10001, vdisk_size)"},{"line_number":416,"context_line":"        self.driver.delete_volume(vol1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ec830c01","line":416,"range":{"start_line":416,"start_character":8,"end_line":416,"end_character":39},"in_reply_to":"9ad45d7e_6a43936c","updated":"2016-08-13 00:28:08.000000000","message":"Done","commit_id":"e10491c90598a51880ce06d797d496f98a57fb54"}],"cinder/volume/drivers/ibm/flashsystem_common.py":[{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"c99b95a815d6f698c46f38161e0bd94e46ba9b04","unresolved":false,"context_lines":[{"line_number":843,"context_line":"        # No output should be returned from chvdisk"},{"line_number":844,"context_line":"        self._assert_ssh_return("},{"line_number":845,"context_line":"            (not out.strip()),"},{"line_number":846,"context_line":"            (\u0027_rename_vdisk %(name)s\u0027) % {\u0027name\u0027: vdisk_name},"},{"line_number":847,"context_line":"            ssh_cmd, out, err)"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"        LOG.debug(\u0027leave: _rename_vdisk: vdisk %(vdisk)s to %(newname)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_af291de8","line":846,"range":{"start_line":846,"start_character":12,"end_line":846,"end_character":38},"updated":"2016-08-11 20:36:31.000000000","message":"Parentheses not needed here.","commit_id":"e10491c90598a51880ce06d797d496f98a57fb54"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"bad12b0c0503520f455884e1220bd72a1d5201db","unresolved":false,"context_lines":[{"line_number":843,"context_line":"        # No output should be returned from chvdisk"},{"line_number":844,"context_line":"        self._assert_ssh_return("},{"line_number":845,"context_line":"            (not out.strip()),"},{"line_number":846,"context_line":"            (\u0027_rename_vdisk %(name)s\u0027) % {\u0027name\u0027: vdisk_name},"},{"line_number":847,"context_line":"            ssh_cmd, out, err)"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"        LOG.debug(\u0027leave: _rename_vdisk: vdisk %(vdisk)s to %(newname)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_6c70bc40","line":846,"range":{"start_line":846,"start_character":12,"end_line":846,"end_character":38},"in_reply_to":"9ad45d7e_af291de8","updated":"2016-08-13 00:28:08.000000000","message":"Done","commit_id":"e10491c90598a51880ce06d797d496f98a57fb54"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"c99b95a815d6f698c46f38161e0bd94e46ba9b04","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"        \"\"\""},{"line_number":1167,"context_line":"        LOG.debug(\u0027enter: manage_existing: volume %(vol)s ref %(ref)s.\u0027,"},{"line_number":1168,"context_line":"                  {\u0027vol\u0027: volume, \u0027ref\u0027: existing_ref})"},{"line_number":1169,"context_line":"        vdisk \u003d self._manage_input_check(existing_ref)"},{"line_number":1170,"context_line":"        new_name \u003d \u0027volume-\u0027 + volume[\u0027id\u0027]"},{"line_number":1171,"context_line":"        self._rename_vdisk(vdisk[\u0027name\u0027], new_name)"},{"line_number":1172,"context_line":"        LOG.debug(\u0027leave: manage_existing: volume %(vol)s ref %(ref)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_4a220fa4","line":1169,"range":{"start_line":1169,"start_character":8,"end_line":1169,"end_character":54},"updated":"2016-08-11 20:36:31.000000000","message":"Is it necessary to check the input again? It was already checked on \"manage_existing_get_size\"","commit_id":"e10491c90598a51880ce06d797d496f98a57fb54"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"bad12b0c0503520f455884e1220bd72a1d5201db","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"        \"\"\""},{"line_number":1167,"context_line":"        LOG.debug(\u0027enter: manage_existing: volume %(vol)s ref %(ref)s.\u0027,"},{"line_number":1168,"context_line":"                  {\u0027vol\u0027: volume, \u0027ref\u0027: existing_ref})"},{"line_number":1169,"context_line":"        vdisk \u003d self._manage_input_check(existing_ref)"},{"line_number":1170,"context_line":"        new_name \u003d \u0027volume-\u0027 + volume[\u0027id\u0027]"},{"line_number":1171,"context_line":"        self._rename_vdisk(vdisk[\u0027name\u0027], new_name)"},{"line_number":1172,"context_line":"        LOG.debug(\u0027leave: manage_existing: volume %(vol)s ref %(ref)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_76d1b022","line":1169,"range":{"start_line":1169,"start_character":8,"end_line":1169,"end_character":54},"in_reply_to":"9ad45d7e_4a220fa4","updated":"2016-08-13 00:28:08.000000000","message":"There is a possibility that the vdisk deleted/renamed between manage_existing_get_size() and manage_existing(). And also it is a way to get the vdisk properties as the vdisk[\u0027name\u0027] will be used in _rename_vdisk() but existing_ref may only provide vdisk id.","commit_id":"e10491c90598a51880ce06d797d496f98a57fb54"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"c99b95a815d6f698c46f38161e0bd94e46ba9b04","unresolved":false,"context_lines":[{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"    def unmanage(self, volume):"},{"line_number":1186,"context_line":"        \"\"\"Removes the specified volume from Cinder management.\"\"\""},{"line_number":1187,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_0fc2e9e8","line":1187,"updated":"2016-08-11 20:36:31.000000000","message":"It would be nice to add some log here, confirming that the volume is no longer managed by cinder.","commit_id":"e10491c90598a51880ce06d797d496f98a57fb54"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"bad12b0c0503520f455884e1220bd72a1d5201db","unresolved":false,"context_lines":[{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"    def unmanage(self, volume):"},{"line_number":1186,"context_line":"        \"\"\"Removes the specified volume from Cinder management.\"\"\""},{"line_number":1187,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_0c982069","line":1187,"in_reply_to":"9ad45d7e_0fc2e9e8","updated":"2016-08-13 00:28:08.000000000","message":"Done","commit_id":"e10491c90598a51880ce06d797d496f98a57fb54"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7299df7315f2d50733cd833c7187d73b3fa97852","unresolved":false,"context_lines":[{"line_number":720,"context_line":"            raise exception.ManageExistingInvalidReference("},{"line_number":721,"context_line":"                existing_ref\u003dexisting_ref, reason\u003dreason)"},{"line_number":722,"context_line":"        if vdisk is None:"},{"line_number":723,"context_line":"            reason \u003d (_(\u0027No vdisk with the UID specified by ref %s.\u0027)"},{"line_number":724,"context_line":"                      % manage_source)"},{"line_number":725,"context_line":"            raise exception.ManageExistingInvalidReference("},{"line_number":726,"context_line":"                existing_ref\u003dexisting_ref, reason\u003dreason)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_7abd9a67","line":723,"range":{"start_line":723,"start_character":43,"end_line":723,"end_character":46},"updated":"2016-08-16 15:14:35.000000000","message":"I think this should be UUID .","commit_id":"987b5e4c0428a738212cf3860ec49bef45b91424"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"c08bf65b9cb766d5b150870934047ba3380c7689","unresolved":false,"context_lines":[{"line_number":720,"context_line":"            raise exception.ManageExistingInvalidReference("},{"line_number":721,"context_line":"                existing_ref\u003dexisting_ref, reason\u003dreason)"},{"line_number":722,"context_line":"        if vdisk is None:"},{"line_number":723,"context_line":"            reason \u003d (_(\u0027No vdisk with the UID specified by ref %s.\u0027)"},{"line_number":724,"context_line":"                      % manage_source)"},{"line_number":725,"context_line":"            raise exception.ManageExistingInvalidReference("},{"line_number":726,"context_line":"                existing_ref\u003dexisting_ref, reason\u003dreason)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_63ae7c99","line":723,"range":{"start_line":723,"start_character":43,"end_line":723,"end_character":46},"in_reply_to":"3ac371cc_7abd9a67","updated":"2016-08-17 09:10:55.000000000","message":"UID is incorrect, but I don\u0027t know if it should be UUID.\nI changed it to ID.\nSee the help of command chvdisk:\n\u003e\u003e- chvdisk -- --+- -name -- new_name_arg ----------------+-----\u003e\n                 +- -udid  -- vdisk_udid  ----------------+   \n                 \u0027- -open_access_scsi_id -- vdisk_scsi_id-\u0027   \n\n\u003e--+- vdisk_name -+--------------------------------------------\u003e\u003c\n   \u0027- vdisk_id ---\u0027   \n\nvdisk_name | vdisk_id \n   (Required) Specifies the volume to modify, either by ID or by name.","commit_id":"987b5e4c0428a738212cf3860ec49bef45b91424"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7299df7315f2d50733cd833c7187d73b3fa97852","unresolved":false,"context_lines":[{"line_number":845,"context_line":"            (not out.strip()),"},{"line_number":846,"context_line":"            \u0027_rename_vdisk %(name)s\u0027 % {\u0027name\u0027: vdisk_name},"},{"line_number":847,"context_line":"            ssh_cmd, out, err)"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"        LOG.debug(\u0027leave: _rename_vdisk: vdisk %(vdisk)s to %(newname)s.\u0027,"},{"line_number":850,"context_line":"                  {\u0027vdisk\u0027: vdisk_name, \u0027newname\u0027: new_name})"},{"line_number":851,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_cd369ae6","line":848,"updated":"2016-08-16 15:14:35.000000000","message":"I think we should have a LOG.info(LI_(\"Renamed %(vdisk)s to %(newname)s .\"))  Here.","commit_id":"987b5e4c0428a738212cf3860ec49bef45b91424"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"c08bf65b9cb766d5b150870934047ba3380c7689","unresolved":false,"context_lines":[{"line_number":845,"context_line":"            (not out.strip()),"},{"line_number":846,"context_line":"            \u0027_rename_vdisk %(name)s\u0027 % {\u0027name\u0027: vdisk_name},"},{"line_number":847,"context_line":"            ssh_cmd, out, err)"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"        LOG.debug(\u0027leave: _rename_vdisk: vdisk %(vdisk)s to %(newname)s.\u0027,"},{"line_number":850,"context_line":"                  {\u0027vdisk\u0027: vdisk_name, \u0027newname\u0027: new_name})"},{"line_number":851,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_a9eb2b77","line":848,"in_reply_to":"3ac371cc_cd369ae6","updated":"2016-08-17 09:10:55.000000000","message":"Done. LOG.debug() removed as there will be too many logs. I accept this because _rename_vdisk() is internal and no high level log can cover it.","commit_id":"987b5e4c0428a738212cf3860ec49bef45b91424"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7299df7315f2d50733cd833c7187d73b3fa97852","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"        vdisk \u003d self._manage_input_check(existing_ref)"},{"line_number":1170,"context_line":"        new_name \u003d \u0027volume-\u0027 + volume[\u0027id\u0027]"},{"line_number":1171,"context_line":"        self._rename_vdisk(vdisk[\u0027name\u0027], new_name)"},{"line_number":1172,"context_line":"        LOG.debug(\u0027leave: manage_existing: volume %(vol)s ref %(ref)s.\u0027,"},{"line_number":1173,"context_line":"                  {\u0027vol\u0027: volume, \u0027ref\u0027: existing_ref})"},{"line_number":1174,"context_line":"        return"},{"line_number":1175,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_4d30ea9e","line":1172,"range":{"start_line":1172,"start_character":7,"end_line":1172,"end_character":17},"updated":"2016-08-16 15:14:35.000000000","message":"I would add a message here to do \"LOG.info\" here indicating that the volume is now managed by Cinder to be similar to the unmanage.","commit_id":"987b5e4c0428a738212cf3860ec49bef45b91424"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"c08bf65b9cb766d5b150870934047ba3380c7689","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"        vdisk \u003d self._manage_input_check(existing_ref)"},{"line_number":1170,"context_line":"        new_name \u003d \u0027volume-\u0027 + volume[\u0027id\u0027]"},{"line_number":1171,"context_line":"        self._rename_vdisk(vdisk[\u0027name\u0027], new_name)"},{"line_number":1172,"context_line":"        LOG.debug(\u0027leave: manage_existing: volume %(vol)s ref %(ref)s.\u0027,"},{"line_number":1173,"context_line":"                  {\u0027vol\u0027: volume, \u0027ref\u0027: existing_ref})"},{"line_number":1174,"context_line":"        return"},{"line_number":1175,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_058fc5cc","line":1172,"range":{"start_line":1172,"start_character":7,"end_line":1172,"end_character":17},"in_reply_to":"3ac371cc_4d30ea9e","updated":"2016-08-17 09:10:55.000000000","message":"If there is a necessary to add a LOG.info for managed a volume, I think it should be printed by some high level code, not the driver.","commit_id":"987b5e4c0428a738212cf3860ec49bef45b91424"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7299df7315f2d50733cd833c7187d73b3fa97852","unresolved":false,"context_lines":[{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"    def unmanage(self, volume):"},{"line_number":1186,"context_line":"        \"\"\"Removes the specified volume from Cinder management.\"\"\""},{"line_number":1187,"context_line":"        LOG.debug(\u0027unmanage: volume %(vol)s no longer managed by cinder.\u0027,"},{"line_number":1188,"context_line":"                  {\u0027vol\u0027: volume})"},{"line_number":1189,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_2d576ecf","line":1187,"range":{"start_line":1187,"start_character":8,"end_line":1187,"end_character":17},"updated":"2016-08-16 15:14:35.000000000","message":"I would make this LOG.info","commit_id":"987b5e4c0428a738212cf3860ec49bef45b91424"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7299df7315f2d50733cd833c7187d73b3fa97852","unresolved":false,"context_lines":[{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"    def unmanage(self, volume):"},{"line_number":1186,"context_line":"        \"\"\"Removes the specified volume from Cinder management.\"\"\""},{"line_number":1187,"context_line":"        LOG.debug(\u0027unmanage: volume %(vol)s no longer managed by cinder.\u0027,"},{"line_number":1188,"context_line":"                  {\u0027vol\u0027: volume})"},{"line_number":1189,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_ad423e0e","line":1187,"range":{"start_line":1187,"start_character":43,"end_line":1187,"end_character":47},"updated":"2016-08-16 15:14:35.000000000","message":"is no longer","commit_id":"987b5e4c0428a738212cf3860ec49bef45b91424"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"c08bf65b9cb766d5b150870934047ba3380c7689","unresolved":false,"context_lines":[{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"    def unmanage(self, volume):"},{"line_number":1186,"context_line":"        \"\"\"Removes the specified volume from Cinder management.\"\"\""},{"line_number":1187,"context_line":"        LOG.debug(\u0027unmanage: volume %(vol)s no longer managed by cinder.\u0027,"},{"line_number":1188,"context_line":"                  {\u0027vol\u0027: volume})"},{"line_number":1189,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_b45d4549","line":1187,"range":{"start_line":1187,"start_character":8,"end_line":1187,"end_character":17},"in_reply_to":"3ac371cc_2d576ecf","updated":"2016-08-17 09:10:55.000000000","message":"See my replay as manage_existing()","commit_id":"987b5e4c0428a738212cf3860ec49bef45b91424"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"c08bf65b9cb766d5b150870934047ba3380c7689","unresolved":false,"context_lines":[{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"    def unmanage(self, volume):"},{"line_number":1186,"context_line":"        \"\"\"Removes the specified volume from Cinder management.\"\"\""},{"line_number":1187,"context_line":"        LOG.debug(\u0027unmanage: volume %(vol)s no longer managed by cinder.\u0027,"},{"line_number":1188,"context_line":"                  {\u0027vol\u0027: volume})"},{"line_number":1189,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_34515537","line":1187,"range":{"start_line":1187,"start_character":43,"end_line":1187,"end_character":47},"in_reply_to":"3ac371cc_ad423e0e","updated":"2016-08-17 09:10:55.000000000","message":"Done","commit_id":"987b5e4c0428a738212cf3860ec49bef45b91424"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eced733805a7f968c1c1c374a638a4e75e2138d5","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"        \"\"\"Removes the specified volume from Cinder management.\"\"\""},{"line_number":1185,"context_line":"        LOG.debug(\u0027unmanage: volume %(vol)s is no longer managed by cinder.\u0027,"},{"line_number":1186,"context_line":"                  {\u0027vol\u0027: volume})"},{"line_number":1187,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_51efb7af","line":1187,"updated":"2016-08-28 20:27:57.000000000","message":"pass not needed.","commit_id":"5242d1f09f2b50b9ced65b72f7aa157ed73a53d8"}]}