)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a6d1895e4e180eee1c1866e8f67b1573765f8f2a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"example:"},{"line_number":11,"context_line":"[root@2C5_19_CG1 ~]# rados -p vms_20 ls |grep rbd_data.63bd1445fe6 |wc -l"},{"line_number":12,"context_line":"478"},{"line_number":13,"context_line":"after delete files in the virtual machine"},{"line_number":14,"context_line":"[root@2C5_19_CG1 ~]# rados -p vms_20 ls |grep rbd_data.63bd1445fe6 |wc -l"},{"line_number":15,"context_line":"354"},{"line_number":16,"context_line":"so this bp add ability for ceph driver to report discard"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_24a434b8","line":13,"range":{"start_line":13,"start_character":6,"end_line":13,"end_character":12},"updated":"2016-08-11 19:43:37.000000000","message":"s/delete/deleting","commit_id":"40414f7a3ef002ae55b06ce20ca5760d088260ec"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a6d1895e4e180eee1c1866e8f67b1573765f8f2a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"after delete files in the virtual machine"},{"line_number":14,"context_line":"[root@2C5_19_CG1 ~]# rados -p vms_20 ls |grep rbd_data.63bd1445fe6 |wc -l"},{"line_number":15,"context_line":"354"},{"line_number":16,"context_line":"so this bp add ability for ceph driver to report discard"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I094163b99d858384584966d65e9d8756c74a0c15"},{"line_number":19,"context_line":"Implements: blueprint ceph-report-discard"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_447e886a","line":16,"range":{"start_line":16,"start_character":49,"end_line":16,"end_character":56},"updated":"2016-08-11 19:43:37.000000000","message":"period","commit_id":"40414f7a3ef002ae55b06ce20ca5760d088260ec"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"a6d1895e4e180eee1c1866e8f67b1573765f8f2a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"after delete files in the virtual machine"},{"line_number":14,"context_line":"[root@2C5_19_CG1 ~]# rados -p vms_20 ls |grep rbd_data.63bd1445fe6 |wc -l"},{"line_number":15,"context_line":"354"},{"line_number":16,"context_line":"so this bp add ability for ceph driver to report discard"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I094163b99d858384584966d65e9d8756c74a0c15"},{"line_number":19,"context_line":"Implements: blueprint ceph-report-discard"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_e4e69c42","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":14},"updated":"2016-08-11 19:43:37.000000000","message":"so this bp add - \u003e So, this patch adds","commit_id":"40414f7a3ef002ae55b06ce20ca5760d088260ec"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"faff6aa93877f925f8a9f80632c674ad8828c568","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability for ceph driver to report discard"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, ceph backend has supported discard."},{"line_number":10,"context_line":"example:"},{"line_number":11,"context_line":"[root@2C5_19_CG1 ~]# rados -p vms_20 ls|grep rbd_data.63bd1445fe6 |wc -l"},{"line_number":12,"context_line":"478"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_873a28e6","line":9,"updated":"2016-08-31 12:27:53.000000000","message":"It would be good if you explained what discard for Ceph actually is. And better to give a link to external (Ceph) docs that describe the feature.\nFrom this, it is not apparent what this feature does.","commit_id":"16d7e477c9eb8d05f3ffaf0a00241c5b0237638d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"faff6aa93877f925f8a9f80632c674ad8828c568","unresolved":false,"context_lines":[{"line_number":16,"context_line":"So, this patch adds ability for ceph driver to report discard"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I094163b99d858384584966d65e9d8756c74a0c15"},{"line_number":19,"context_line":"Implements: blueprint ceph-report-discard"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_e75a1450","line":19,"updated":"2016-08-31 12:27:53.000000000","message":"It looks like this BP is new, and not yet approved. As of today (Wed Aug31) we are in the week of Feature Freeze, so be aware that time is limited to get this in for Newton.","commit_id":"16d7e477c9eb8d05f3ffaf0a00241c5b0237638d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"79331413c3713f24f2320e49b56cf7cd57abcb2f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"However thanks to the discard support on the block device,"},{"line_number":18,"context_line":"the filesystem can send discard flush commands to the block."},{"line_number":19,"context_line":"In the end, the storage will free up blocks."},{"line_number":20,"context_line":"This feature was added into the Kernel 3.18."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"So far the openstack enable discard support for virtual machine"},{"line_number":23,"context_line":"ephemeral root disk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_ef6bc283","line":20,"updated":"2016-08-31 14:31:16.000000000","message":"I believe this refers to the RBD kernel client supporting discard?  Is that relevant here, since we generally use the qemu rbd client?","commit_id":"bea5437ecb95a1994828793939473b39671a5d01"},{"author":{"_account_id":21428,"name":"JiWei","email":"17366060309@163.com","username":"WeiJi"},"change_message_id":"64fca5a7e5f37ddfed7be0a43362166f7bbcc5c8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"However thanks to the discard support on the block device,"},{"line_number":18,"context_line":"the filesystem can send discard flush commands to the block."},{"line_number":19,"context_line":"In the end, the storage will free up blocks."},{"line_number":20,"context_line":"This feature was added into the Kernel 3.18."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"So far the openstack enable discard support for virtual machine"},{"line_number":23,"context_line":"ephemeral root disk."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_2c3cd52e","line":20,"in_reply_to":"fa7ab95a_ef6bc283","updated":"2016-08-31 14:59:41.000000000","message":"yes， this refers to the RBD kernel client supporting discard in Kernel 3.18.\nWe will use its in https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/rbd.py#L402  _update_volume_stats reported the use of backend, if you use the discard, delete files inside the virtual machine, and free_capacity_gb increases","commit_id":"bea5437ecb95a1994828793939473b39671a5d01"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"faff6aa93877f925f8a9f80632c674ad8828c568","unresolved":false,"context_lines":[{"line_number":880,"context_line":"                    \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":881,"context_line":"                    \u0027secret_uuid\u0027: None,"},{"line_number":882,"context_line":"                    \u0027volume_id\u0027: self.volume_a.id,"},{"line_number":883,"context_line":"                    \u0027discard\u0027: True,"},{"line_number":884,"context_line":"                }"},{"line_number":885,"context_line":"            }"},{"line_number":886,"context_line":"            actual \u003d self.driver.initialize_connection(self.volume_a, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_524c6076","line":883,"updated":"2016-08-31 12:27:53.000000000","message":"It is not clear to me what this feature actually does, but it doesn\u0027t seem like adding this line is much of a test.","commit_id":"16d7e477c9eb8d05f3ffaf0a00241c5b0237638d"}]}