)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0966a030dc93fdd70467b7de3cc56a71218c2671","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: Error when manage an already-managed volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When you try to manage an already-managed volume, you received an"},{"line_number":10,"context_line":"unhandled error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch allow the RBD driver to catch the exception and show a custom"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_ed0040ad","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":48},"updated":"2016-08-26 08:37:31.000000000","message":"?: Is it really an already-managed volume and not an nonexistent volume?","commit_id":"37f35558af8517480414d24282b374918a71fdc5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0966a030dc93fdd70467b7de3cc56a71218c2671","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When you try to manage an already-managed volume, you received an"},{"line_number":10,"context_line":"unhandled error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch allow the RBD driver to catch the exception and show a custom"},{"line_number":13,"context_line":"message notifying the user."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2f4d93cce3241edd6457efb1cf5a2f1dbaea2144"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_0d0564c1","line":12,"updated":"2016-08-26 08:37:31.000000000","message":"nit: It would be great to mention the exception like you did in your bug report:\n\n\"When you try to manage an already-managed volume, you received an unhandled error: \u0027UnboundLocalError: local variable \u0027rbd_image\u0027 referenced before assignment\u0027\"","commit_id":"37f35558af8517480414d24282b374918a71fdc5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c53a55cca4af220b932728da481c1c5c720a5b52","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: Error when manage an already-managed volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When you try to manage an already-managed volume, you received an"},{"line_number":10,"context_line":"unhandled error: \u0027UnboundLocalError: local variable \u0027rbd_image\u0027"},{"line_number":11,"context_line":"referenced before assignment"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_d111ab05","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":48},"updated":"2016-08-30 09:05:24.000000000","message":"?: I still believe this happens when you request to manage a non nonexistent volume, not when the volume is already being managed.","commit_id":"127b1adbcd6a19eab7bd41e2c9ab74f989a8a1de"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bd7d72ef73c087b8e2232a5251e24dd88d20576b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: Error when manage an already-managed volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When you try to manage an already-managed volume, you received an"},{"line_number":10,"context_line":"unhandled error: \u0027UnboundLocalError: local variable \u0027rbd_image\u0027"},{"line_number":11,"context_line":"referenced before assignment"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_d44f4368","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":48},"in_reply_to":"fa7ab95a_7af3e19f","updated":"2016-09-01 08:41:00.000000000","message":"It does happen in both cases, but in the case of doing a manage command for the second time it happens because on the first manage we have renamed the volume and therefore it no longer exists.\n\nSo the root cause for both cases is that the volume doesn\u0027t exist in the backend, that\u0027s why I\u0027m saying that this is not entirely correct.\n\nIf you expand this description to something that conveys the whole issue I\u0027ll be glad to +2 the patch, since this is the only thing holding me back.\n\nYou could write something like: \"When you try to manage a nonexistent volume or one that has already been managed (and therefore renamed on the backend), you receive an unhandled\" ...","commit_id":"127b1adbcd6a19eab7bd41e2c9ab74f989a8a1de"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"071c76ae839b75e9b0fb635733aaf96e1cae0186","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: Error when manage an already-managed volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When you try to manage an already-managed volume, you received an"},{"line_number":10,"context_line":"unhandled error: \u0027UnboundLocalError: local variable \u0027rbd_image\u0027"},{"line_number":11,"context_line":"referenced before assignment"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_7af3e19f","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":48},"in_reply_to":"fa7ab95a_d111ab05","updated":"2016-08-31 18:55:53.000000000","message":"It happens in both cases. Both of them doesn\u0027t have a suitable image to match with them.","commit_id":"127b1adbcd6a19eab7bd41e2c9ab74f989a8a1de"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"28138afbc7d0171ccf684a88b45126b81e0fc548","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofia Enriquez \u003clsofia.enriquez@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-05 16:58:09 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: Error when manage an already-managed volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When you try to manage a nonexistent volume or one that has already been"},{"line_number":10,"context_line":"managed (and therefore renamed on the backend), you received an unhandled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_6b7871c5","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":41},"updated":"2016-09-05 19:42:53.000000000","message":"nit: managing a nonexistent volume","commit_id":"f974b51f5b0098217576d959180d36794ca0577f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"28138afbc7d0171ccf684a88b45126b81e0fc548","unresolved":false,"context_lines":[{"line_number":7,"context_line":"RBD: Error when manage an already-managed volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When you try to manage a nonexistent volume or one that has already been"},{"line_number":10,"context_line":"managed (and therefore renamed on the backend), you received an unhandled"},{"line_number":11,"context_line":"error: \u0027UnboundLocalError: local variable \u0027rbd_image\u0027referenced before"},{"line_number":12,"context_line":"assignment"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_ab827992","line":10,"range":{"start_line":10,"start_character":64,"end_line":10,"end_character":73},"updated":"2016-09-05 19:42:53.000000000","message":"nit: This world should go on the next line since we should not exceed 72 columns on the commit message body.","commit_id":"f974b51f5b0098217576d959180d36794ca0577f"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0966a030dc93fdd70467b7de3cc56a71218c2671","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    @common_mocks"},{"line_number":288,"context_line":"    def test_manage_existing_with_invalid_rbd_image(self):"},{"line_number":289,"context_line":"        client \u003d self.mock_client.return_value"},{"line_number":290,"context_line":"        client.__enter__.return_value \u003d client"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        self.mock_rbd.Image.side_effect \u003d self.mock_rbd.ImageNotFound"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_0d5e44e9","line":290,"range":{"start_line":289,"start_character":0,"end_line":290,"end_character":46},"updated":"2016-08-26 08:37:31.000000000","message":"-1: This is unnecessary, the client\u0027s __enter__ method will return a Mock object on its own, and that\u0027s all that\u0027s necessary for this test.","commit_id":"37f35558af8517480414d24282b374918a71fdc5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0966a030dc93fdd70467b7de3cc56a71218c2671","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                          self.volume_a, invalid_ref)"},{"line_number":300,"context_line":"        # Make sure the exception was raised"},{"line_number":301,"context_line":"        self.assertEqual(RAISED_EXCEPTIONS,"},{"line_number":302,"context_line":"                         [self.mock_rbd.ImageNotFound])"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    @common_mocks"},{"line_number":305,"context_line":"    def test_delete_backup_snaps(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_7a1148ac","line":302,"updated":"2016-08-26 08:37:31.000000000","message":"-1: Assert order is expected, actual:\n\n self.assertEqual([self.mock_rbd.ImageNotFound],\n                  RAISED_EXCEPTIONS)","commit_id":"37f35558af8517480414d24282b374918a71fdc5"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dd30458bab81def10e854a62a684767c2990e51c","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"            # Raise an exception if we didn\u0027t find a suitable rbd image."},{"line_number":1048,"context_line":"            try:"},{"line_number":1049,"context_line":"                rbd_image \u003d self.rbd.Image(client.ioctx, rbd_name)"},{"line_number":1050,"context_line":"                image_size \u003d rbd_image.size()"},{"line_number":1051,"context_line":"                rbd_image.close()"},{"line_number":1052,"context_line":"            except self.rbd.ImageNotFound:"},{"line_number":1053,"context_line":"                kwargs \u003d {\u0027existing_ref\u0027: rbd_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_e05eed10","line":1050,"updated":"2016-08-22 16:29:08.000000000","message":"It would be cleaner to move lines 1050 and 1051 below the except ImageNotFound block, since that exception is only for the Image() call.","commit_id":"d632749be51aebafcefc8b214298c87927216ef6"}]}