)]}'
{"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"774c9501d8ebfa92fa814207de4a74e5976a4743","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"                                        \u0027description\u0027,"},{"line_number":1097,"context_line":"                                        volume_type\u003ddb_vol_type)"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        self.assertIsNotNone(volume[\u0027encryption_key_id\u0027])"},{"line_number":1100,"context_line":"        self.assertEqual(db_vol_type[\u0027id\u0027], volume[\u0027volume_type_id\u0027])"},{"line_number":1101,"context_line":"        self.assertIsNotNone(volume[\u0027encryption_key_id\u0027])"},{"line_number":1102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_8c0db692","line":1099,"range":{"start_line":1099,"start_character":8,"end_line":1099,"end_character":57},"updated":"2016-08-16 20:23:59.000000000","message":"This should not be changed. If encryption_key_id does not exist this will through an exception. That\u0027s why volume.get() is being used here.","commit_id":"8c9f3e8b7d11d6b040191cbede841c2bd9ce83fb"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"ada0d97259c61a4aee4914445ffe793117384ac9","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"                                        \u0027description\u0027,"},{"line_number":1097,"context_line":"                                        volume_type\u003ddb_vol_type)"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        self.assertIsNotNone(volume[\u0027encryption_key_id\u0027])"},{"line_number":1100,"context_line":"        self.assertEqual(db_vol_type[\u0027id\u0027], volume[\u0027volume_type_id\u0027])"},{"line_number":1101,"context_line":"        self.assertIsNotNone(volume[\u0027encryption_key_id\u0027])"},{"line_number":1102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_a38874c6","line":1099,"range":{"start_line":1099,"start_character":8,"end_line":1099,"end_character":57},"in_reply_to":"3ac371cc_43eb8013","updated":"2016-08-17 02:30:59.000000000","message":"Hmm, Yes, you\u0027re right.\nBut sounds only L1099 is enough if we keep it.\nThe L1101 should be deleted as indeed it is duplicated.","commit_id":"8c9f3e8b7d11d6b040191cbede841c2bd9ce83fb"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"887f38ca84f56cf784aa178d8b48a47746b240d7","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"                                        \u0027description\u0027,"},{"line_number":1097,"context_line":"                                        volume_type\u003ddb_vol_type)"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        self.assertIsNotNone(volume[\u0027encryption_key_id\u0027])"},{"line_number":1100,"context_line":"        self.assertEqual(db_vol_type[\u0027id\u0027], volume[\u0027volume_type_id\u0027])"},{"line_number":1101,"context_line":"        self.assertIsNotNone(volume[\u0027encryption_key_id\u0027])"},{"line_number":1102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_43eb8013","line":1099,"range":{"start_line":1099,"start_character":8,"end_line":1099,"end_character":57},"in_reply_to":"3ac371cc_8c0db692","updated":"2016-08-17 01:48:09.000000000","message":"If so, I think we\u0027d better use assertIn() to assert the existence explicitly, it will cooperate with L1101.","commit_id":"8c9f3e8b7d11d6b040191cbede841c2bd9ce83fb"},{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"8108b650d50210e3ef52e93b84e604bbb1c6c84c","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                                        volume_type\u003ddb_vol_type)"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        self.assertIsNotNone(volume.get(\u0027encryption_key_id\u0027, None))"},{"line_number":1100,"context_line":"        self.assertEqual(db_vol_type[\u0027id\u0027], volume[\u0027volume_type_id\u0027])"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"        volume[\u0027host\u0027] \u003d \u0027fake_host\u0027"},{"line_number":1103,"context_line":"        volume[\u0027status\u0027] \u003d \u0027available\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_58e991e5","line":1100,"range":{"start_line":1100,"start_character":25,"end_line":1100,"end_character":42},"updated":"2016-08-17 12:58:39.000000000","message":"I think you\u0027re missing an assertIn before if you are making this change.","commit_id":"95d662a6b83e946793cde52e12714967822593ce"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"ee8648973dc3564bf2097d736e0ca1a6bf32301b","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                                        volume_type\u003ddb_vol_type)"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"        self.assertIsNotNone(volume.get(\u0027encryption_key_id\u0027, None))"},{"line_number":1100,"context_line":"        self.assertEqual(db_vol_type[\u0027id\u0027], volume[\u0027volume_type_id\u0027])"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"        volume[\u0027host\u0027] \u003d \u0027fake_host\u0027"},{"line_number":1103,"context_line":"        volume[\u0027status\u0027] \u003d \u0027available\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_1b39d3f2","line":1100,"range":{"start_line":1100,"start_character":25,"end_line":1100,"end_character":42},"in_reply_to":"3ac371cc_58e991e5","updated":"2016-08-17 13:26:00.000000000","message":"I think should just fix the assertIsNotNone and assertIsNone and leave this a alone.","commit_id":"95d662a6b83e946793cde52e12714967822593ce"}]}