)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eab0cd7a57d1584ad710271702527d81df0c9ef7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"   will log an error and then check to see if the driver section configuration"},{"line_number":20,"context_line":"   setting of \u0027enable_unsupported_driver \u003d True\u0027.  If the conf setting is"},{"line_number":21,"context_line":"   not enabled, the driver will not be started."},{"line_number":22,"context_line":"4) If the driver section in cinder.conf has the enable_unsupported_driver set,"},{"line_number":23,"context_line":"   then the volume manager will start the driver, but log a warning on every"},{"line_number":24,"context_line":"   driver call saying the driver isn\u0027t supported and may be removed in the"},{"line_number":25,"context_line":"   future."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3ac371cc_3925530a","line":22,"updated":"2016-08-18 19:06:38.000000000","message":"#4 should be a sub-bullet under #3?  This is only for drivers with supported flag set to False.","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d5f5f0e0ce3dbcaef4d90124e0ba8d32e68670de","unresolved":false,"context_lines":[{"line_number":19,"context_line":"   will log an error and then check to see if the driver section configuration"},{"line_number":20,"context_line":"   setting of \u0027enable_unsupported_driver \u003d True\u0027.  If the conf setting is"},{"line_number":21,"context_line":"   not enabled, the driver will not be started."},{"line_number":22,"context_line":"4) If the driver section in cinder.conf has the enable_unsupported_driver set,"},{"line_number":23,"context_line":"   then the volume manager will start the driver, but log a warning on every"},{"line_number":24,"context_line":"   driver call saying the driver isn\u0027t supported and may be removed in the"},{"line_number":25,"context_line":"   future."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1ac06dbe_ed03e20b","line":22,"in_reply_to":"3ac371cc_3925530a","updated":"2016-08-19 17:01:16.000000000","message":"Done","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eab0cd7a57d1584ad710271702527d81df0c9ef7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"   future."},{"line_number":26,"context_line":"5) When the driver maintainer conforms to the community testing standards,"},{"line_number":27,"context_line":"   then a follow up patch will be submitted to re-enable the supported flag."},{"line_number":28,"context_line":"6) If the driver maintainer continues to not support the community testing"},{"line_number":29,"context_line":"   standards, then the Cinder community will revisit removing the driver in"},{"line_number":30,"context_line":"   the following release."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3ac371cc_3953936e","line":28,"updated":"2016-08-18 19:06:38.000000000","message":"#5 and 6 should also be sub-bullets under #3 with the condition that supported is False.","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d5f5f0e0ce3dbcaef4d90124e0ba8d32e68670de","unresolved":false,"context_lines":[{"line_number":25,"context_line":"   future."},{"line_number":26,"context_line":"5) When the driver maintainer conforms to the community testing standards,"},{"line_number":27,"context_line":"   then a follow up patch will be submitted to re-enable the supported flag."},{"line_number":28,"context_line":"6) If the driver maintainer continues to not support the community testing"},{"line_number":29,"context_line":"   standards, then the Cinder community will revisit removing the driver in"},{"line_number":30,"context_line":"   the following release."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1ac06dbe_cd76e63d","line":28,"in_reply_to":"3ac371cc_3953936e","updated":"2016-08-19 17:01:16.000000000","message":"Done","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eab0cd7a57d1584ad710271702527d81df0c9ef7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"5) When the driver maintainer conforms to the community testing standards,"},{"line_number":27,"context_line":"   then a follow up patch will be submitted to re-enable the supported flag."},{"line_number":28,"context_line":"6) If the driver maintainer continues to not support the community testing"},{"line_number":29,"context_line":"   standards, then the Cinder community will revisit removing the driver in"},{"line_number":30,"context_line":"   the following release."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Implements: blueprint supported-drivers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3ac371cc_b92943f5","line":29,"updated":"2016-08-18 19:06:38.000000000","message":"nit: Please wrap the line to 72 characters or less.","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d5f5f0e0ce3dbcaef4d90124e0ba8d32e68670de","unresolved":false,"context_lines":[{"line_number":26,"context_line":"5) When the driver maintainer conforms to the community testing standards,"},{"line_number":27,"context_line":"   then a follow up patch will be submitted to re-enable the supported flag."},{"line_number":28,"context_line":"6) If the driver maintainer continues to not support the community testing"},{"line_number":29,"context_line":"   standards, then the Cinder community will revisit removing the driver in"},{"line_number":30,"context_line":"   the following release."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Implements: blueprint supported-drivers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1ac06dbe_ed93e24d","line":29,"in_reply_to":"3ac371cc_b92943f5","updated":"2016-08-19 17:01:16.000000000","message":"Done","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"}],"cinder/utils.py":[{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"cc94eb16772ea5cdb81113cb05647547dcd29dd2","unresolved":false,"context_lines":[{"line_number":527,"context_line":"def log_unsupported_driver_warning(driver):"},{"line_number":528,"context_line":"    \"\"\"Annoy the log about unsupported drivers.\"\"\""},{"line_number":529,"context_line":"    if not driver.supported:"},{"line_number":530,"context_line":"        # Check to see if the driver is flagged as supported."},{"line_number":531,"context_line":"        LOG.warning(_LW(\"Using an unsupported driver %(driver_name)s \""},{"line_number":532,"context_line":"                        \"(%(version)s) may not work properly.  \""},{"line_number":533,"context_line":"                        \"Use at your own risk.\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_dc6486e6","line":530,"range":{"start_line":530,"start_character":8,"end_line":530,"end_character":61},"updated":"2016-08-16 16:37:37.000000000","message":"Should this comment go above the if statement?","commit_id":"c97de54fc6bb2e34d1f658ceddf82db4bf5ad7be"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"6865f43118a5bed503a2a68a8e536402b21f9650","unresolved":false,"context_lines":[{"line_number":528,"context_line":"    \"\"\"Annoy the log about unsupported drivers.\"\"\""},{"line_number":529,"context_line":"    if not driver.supported:"},{"line_number":530,"context_line":"        # Check to see if the driver is flagged as supported."},{"line_number":531,"context_line":"        LOG.warning(_LW(\"Volume driver (%(driver_name)s %(version)s) is \""},{"line_number":532,"context_line":"                        \"currently unsupported and may be removed in the \""},{"line_number":533,"context_line":"                        \"next release of OpenStack.  Use at your own risk.\"),"},{"line_number":534,"context_line":"                    {\u0027driver_name\u0027: driver.__class__.__name__,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_a59e2a61","line":531,"updated":"2016-08-19 00:34:04.000000000","message":"I think the wording here should be consistent with the help text for the option: enable_unsupported_driver.\nCurrently the help text mentions deprecation and this log message mentions \"use at your own risk\". My preference is to use the help text as it is more clear to me what this really means.","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d5f5f0e0ce3dbcaef4d90124e0ba8d32e68670de","unresolved":false,"context_lines":[{"line_number":528,"context_line":"    \"\"\"Annoy the log about unsupported drivers.\"\"\""},{"line_number":529,"context_line":"    if not driver.supported:"},{"line_number":530,"context_line":"        # Check to see if the driver is flagged as supported."},{"line_number":531,"context_line":"        LOG.warning(_LW(\"Volume driver (%(driver_name)s %(version)s) is \""},{"line_number":532,"context_line":"                        \"currently unsupported and may be removed in the \""},{"line_number":533,"context_line":"                        \"next release of OpenStack.  Use at your own risk.\"),"},{"line_number":534,"context_line":"                    {\u0027driver_name\u0027: driver.__class__.__name__,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_adb60a3b","line":531,"in_reply_to":"3ac371cc_a59e2a61","updated":"2016-08-19 17:01:16.000000000","message":"This messaging here is very clear and to the point.   The driver isn\u0027t supported and may not even function and may be removed.  it\u0027s not deprecated, it\u0027s unsupported.   Use at your own risk is on purpose, because the driver is unsupported and may not even work.","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"}],"cinder/volume/driver.py":[{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"cc94eb16772ea5cdb81113cb05647547dcd29dd2","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027enable_unsupported_driver\u0027,"},{"line_number":269,"context_line":"                default\u003dFalse,"},{"line_number":270,"context_line":"                help\u003d\"Set this to True when you want to allow an usupported \""},{"line_number":271,"context_line":"                     \"driver to start.  Drivers that haven\u0027t maintained a \""},{"line_number":272,"context_line":"                     \"working CI system and testing are marked as unsupported \""},{"line_number":273,"context_line":"                     \"until CI is working again.  This also marks a driver as \""},{"line_number":274,"context_line":"                     \"deprecated and may be removed in the next release.\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_fc73427e","line":271,"range":{"start_line":271,"start_character":38,"end_line":271,"end_character":40},"updated":"2016-08-16 16:37:37.000000000","message":"Double spaces after a period died out with the \"digital age\". :)\nhttps://en.wikipedia.org/wiki/Sentence_spacing","commit_id":"c97de54fc6bb2e34d1f658ceddf82db4bf5ad7be"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1efe55199017cf0cff846812c3c7ce820d1dc32b","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027enable_unsupported_driver\u0027,"},{"line_number":269,"context_line":"                default\u003dFalse,"},{"line_number":270,"context_line":"                help\u003d\"Set this to True when you want to allow an usupported \""},{"line_number":271,"context_line":"                     \"driver to start.  Drivers that haven\u0027t maintained a \""},{"line_number":272,"context_line":"                     \"working CI system and testing are marked as unsupported \""},{"line_number":273,"context_line":"                     \"until CI is working again.  This also marks a driver as \""},{"line_number":274,"context_line":"                     \"deprecated and may be removed in the next release.\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_4b3bab9c","line":271,"range":{"start_line":271,"start_character":38,"end_line":271,"end_character":40},"in_reply_to":"3ac371cc_fc73427e","updated":"2016-08-16 17:50:09.000000000","message":"completely disagree.","commit_id":"c97de54fc6bb2e34d1f658ceddf82db4bf5ad7be"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eab0cd7a57d1584ad710271702527d81df0c9ef7","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027enable_unsupported_driver\u0027,"},{"line_number":269,"context_line":"                default\u003dFalse,"},{"line_number":270,"context_line":"                help\u003d\"Set this to True when you want to allow an usupported \""},{"line_number":271,"context_line":"                     \"driver to start.  Drivers that haven\u0027t maintained a \""},{"line_number":272,"context_line":"                     \"working CI system and testing are marked as unsupported \""},{"line_number":273,"context_line":"                     \"until CI is working again.  This also marks a driver as \""},{"line_number":274,"context_line":"                     \"deprecated and may be removed in the next release.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_59f80f4a","line":271,"updated":"2016-08-18 19:06:38.000000000","message":"Need only 1 space after period.","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d5f5f0e0ce3dbcaef4d90124e0ba8d32e68670de","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027enable_unsupported_driver\u0027,"},{"line_number":269,"context_line":"                default\u003dFalse,"},{"line_number":270,"context_line":"                help\u003d\"Set this to True when you want to allow an usupported \""},{"line_number":271,"context_line":"                     \"driver to start.  Drivers that haven\u0027t maintained a \""},{"line_number":272,"context_line":"                     \"working CI system and testing are marked as unsupported \""},{"line_number":273,"context_line":"                     \"until CI is working again.  This also marks a driver as \""},{"line_number":274,"context_line":"                     \"deprecated and may be removed in the next release.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_8ddd0e73","line":271,"in_reply_to":"1ac06dbe_647c3621","updated":"2016-08-19 17:01:16.000000000","message":"I don\u0027t agree.  One space makes it much harder to read, and doesn\u0027t distinguish one sentence from another.","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b8740758d0e59265f13342cca454ada7fcd43e82","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027enable_unsupported_driver\u0027,"},{"line_number":269,"context_line":"                default\u003dFalse,"},{"line_number":270,"context_line":"                help\u003d\"Set this to True when you want to allow an usupported \""},{"line_number":271,"context_line":"                     \"driver to start.  Drivers that haven\u0027t maintained a \""},{"line_number":272,"context_line":"                     \"working CI system and testing are marked as unsupported \""},{"line_number":273,"context_line":"                     \"until CI is working again.  This also marks a driver as \""},{"line_number":274,"context_line":"                     \"deprecated and may be removed in the next release.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_6702f3b5","line":271,"in_reply_to":"1ac06dbe_8ddd0e73","updated":"2016-08-23 05:43:32.000000000","message":"When submitting a doc patch, only single space is allowed between sentences.  Personally I prefer double spaces as well.  Any way, no big deal.","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"bd6a31e7e321c3e18bb5df112b8de1e990676125","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    cfg.BoolOpt(\u0027enable_unsupported_driver\u0027,"},{"line_number":269,"context_line":"                default\u003dFalse,"},{"line_number":270,"context_line":"                help\u003d\"Set this to True when you want to allow an usupported \""},{"line_number":271,"context_line":"                     \"driver to start.  Drivers that haven\u0027t maintained a \""},{"line_number":272,"context_line":"                     \"working CI system and testing are marked as unsupported \""},{"line_number":273,"context_line":"                     \"until CI is working again.  This also marks a driver as \""},{"line_number":274,"context_line":"                     \"deprecated and may be removed in the next release.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_647c3621","line":271,"in_reply_to":"3ac371cc_59f80f4a","updated":"2016-08-19 14:58:40.000000000","message":"This really has become the new standard that most people expect. Other than the wikipedia article that I linked to in a previous review you can use iMessage as an example. If you double space after a word it will add a period and a single space. Just my $0.02.","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eab0cd7a57d1584ad710271702527d81df0c9ef7","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                help\u003d\"Set this to True when you want to allow an usupported \""},{"line_number":271,"context_line":"                     \"driver to start.  Drivers that haven\u0027t maintained a \""},{"line_number":272,"context_line":"                     \"working CI system and testing are marked as unsupported \""},{"line_number":273,"context_line":"                     \"until CI is working again.  This also marks a driver as \""},{"line_number":274,"context_line":"                     \"deprecated and may be removed in the next release.\"),"},{"line_number":275,"context_line":"]"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_9998c71d","line":273,"updated":"2016-08-18 19:06:38.000000000","message":"Same","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eab0cd7a57d1584ad710271702527d81df0c9ef7","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        self._initialized \u003d False"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        # If a driver hasn\u0027t maintained their CI system, this will get"},{"line_number":367,"context_line":"        # set to false, which prevents the driver from starting."},{"line_number":368,"context_line":"        # You will have to set the enable_unsupported_driver \u003d True in"},{"line_number":369,"context_line":"        # cinder.conf"},{"line_number":370,"context_line":"        self._supported \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_79922bf8","line":367,"updated":"2016-08-18 19:06:38.000000000","message":"nit: False","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d5f5f0e0ce3dbcaef4d90124e0ba8d32e68670de","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        self._initialized \u003d False"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        # If a driver hasn\u0027t maintained their CI system, this will get"},{"line_number":367,"context_line":"        # set to false, which prevents the driver from starting."},{"line_number":368,"context_line":"        # You will have to set the enable_unsupported_driver \u003d True in"},{"line_number":369,"context_line":"        # cinder.conf"},{"line_number":370,"context_line":"        self._supported \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_cd6c269f","line":367,"in_reply_to":"3ac371cc_79922bf8","updated":"2016-08-19 17:01:16.000000000","message":"Done","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eab0cd7a57d1584ad710271702527d81df0c9ef7","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        # If a driver hasn\u0027t maintained their CI system, this will get"},{"line_number":367,"context_line":"        # set to false, which prevents the driver from starting."},{"line_number":368,"context_line":"        # You will have to set the enable_unsupported_driver \u003d True in"},{"line_number":369,"context_line":"        # cinder.conf"},{"line_number":370,"context_line":"        self._supported \u003d True"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def _driver_data_namespace(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_19acd734","line":369,"updated":"2016-08-18 19:06:38.000000000","message":"Add \"to get the unsupported driver started.\"","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d5f5f0e0ce3dbcaef4d90124e0ba8d32e68670de","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        # If a driver hasn\u0027t maintained their CI system, this will get"},{"line_number":367,"context_line":"        # set to false, which prevents the driver from starting."},{"line_number":368,"context_line":"        # You will have to set the enable_unsupported_driver \u003d True in"},{"line_number":369,"context_line":"        # cinder.conf"},{"line_number":370,"context_line":"        self._supported \u003d True"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def _driver_data_namespace(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_0d059ec1","line":369,"in_reply_to":"3ac371cc_19acd734","updated":"2016-08-19 17:01:16.000000000","message":"Done","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"}],"cinder/volume/drivers/emc/emc_vmax_iscsi.py":[{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"cc0a91ae9d18d22ee781be8004e66e08f7e1917a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    CI_WIKI_NAME \u003d \"EMC_VMAX_CI\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":88,"context_line":"        super(EMCVMAXISCSIDriver, self).__init__(*args, **kwargs)"},{"line_number":89,"context_line":"        # This is a supported driver"},{"line_number":90,"context_line":"        self.set_supported()"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_775e81ea","line":88,"updated":"2016-08-15 19:42:47.000000000","message":"looks like a blank line is deleted.","commit_id":"fa556b18b89b3e5a6184e605bcac5d7b97186833"}],"cinder/volume/drivers/fujitsu/eternus_dx_fc.py":[{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"cc0a91ae9d18d22ee781be8004e66e08f7e1917a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    CI_WIKI_NAME \u003d \"Fujitsu_ETERNUS_CI\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":41,"context_line":"        super(FJDXFCDriver, self).__init__(*args, **kwargs)"},{"line_number":42,"context_line":"        # This is a supported driver"},{"line_number":43,"context_line":"        self.set_supported()"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_d76f7590","line":41,"updated":"2016-08-15 19:42:47.000000000","message":"same","commit_id":"fa556b18b89b3e5a6184e605bcac5d7b97186833"}],"cinder/volume/manager.py":[{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"cc94eb16772ea5cdb81113cb05647547dcd29dd2","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        \"\"\"Perform any required initialization.\"\"\""},{"line_number":381,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":382,"context_line":"        if not self.driver.supported:"},{"line_number":383,"context_line":"            LOG.error(_LE(\"Volume driver is currently unsupported and may \""},{"line_number":384,"context_line":"                          \"be removed in the next release of OpenStack. \""},{"line_number":385,"context_line":"                          \"%(driver_name)s (%(version)s)\"),"},{"line_number":386,"context_line":"                      {\u0027driver_name\u0027: self.driver.__class__.__name__,"},{"line_number":387,"context_line":"                       \u0027version\u0027: self.driver.get_version()},"},{"line_number":388,"context_line":"                      resource\u003d{\u0027type\u0027: \u0027driver\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_5ccb761e","line":385,"range":{"start_line":383,"start_character":12,"end_line":385,"end_character":59},"updated":"2016-08-16 16:37:37.000000000","message":"Should this be an error since utils#log_unsupported_driver_warning uses a warning? Also, you may be able to reduce code duplication by using log_unsupported_driver_warning here.","commit_id":"c97de54fc6bb2e34d1f658ceddf82db4bf5ad7be"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1efe55199017cf0cff846812c3c7ce820d1dc32b","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        \"\"\"Perform any required initialization.\"\"\""},{"line_number":381,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":382,"context_line":"        if not self.driver.supported:"},{"line_number":383,"context_line":"            LOG.error(_LE(\"Volume driver is currently unsupported and may \""},{"line_number":384,"context_line":"                          \"be removed in the next release of OpenStack. \""},{"line_number":385,"context_line":"                          \"%(driver_name)s (%(version)s)\"),"},{"line_number":386,"context_line":"                      {\u0027driver_name\u0027: self.driver.__class__.__name__,"},{"line_number":387,"context_line":"                       \u0027version\u0027: self.driver.get_version()},"},{"line_number":388,"context_line":"                      resource\u003d{\u0027type\u0027: \u0027driver\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_2bf3cfd7","line":385,"range":{"start_line":383,"start_character":12,"end_line":385,"end_character":59},"in_reply_to":"3ac371cc_5ccb761e","updated":"2016-08-16 17:50:09.000000000","message":"ok I\u0027ll combine the messaging between these 2 and reuse.","commit_id":"c97de54fc6bb2e34d1f658ceddf82db4bf5ad7be"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eab0cd7a57d1584ad710271702527d81df0c9ef7","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                          \"driver isn\u0027t initialized properly.\"),"},{"line_number":510,"context_line":"                      resource\u003d{\u0027type\u0027: \u0027driver\u0027,"},{"line_number":511,"context_line":"                                \u0027id\u0027: self.driver.__class__.__name__})"},{"line_number":512,"context_line":"            return"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":515,"context_line":"        svc_host \u003d vol_utils.extract_host(self.host, \u0027backend\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_2b64dae3","line":512,"updated":"2016-08-18 19:06:38.000000000","message":"Should this do save_and_reraise_exception as on line 522?","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d5f5f0e0ce3dbcaef4d90124e0ba8d32e68670de","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                          \"driver isn\u0027t initialized properly.\"),"},{"line_number":510,"context_line":"                      resource\u003d{\u0027type\u0027: \u0027driver\u0027,"},{"line_number":511,"context_line":"                                \u0027id\u0027: self.driver.__class__.__name__})"},{"line_number":512,"context_line":"            return"},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"        stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":515,"context_line":"        svc_host \u003d vol_utils.extract_host(self.host, \u0027backend\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_ede122d2","line":512,"in_reply_to":"3ac371cc_2b64dae3","updated":"2016-08-19 17:01:16.000000000","message":"I don\u0027t believe so.  I don\u0027t think it\u0027s worth showing a stack dump for an uninitialized driver here.","commit_id":"bcfde912f505739b0d40a36055a0c940d61d6804"}]}